[MediaWiki-commits] [Gerrit] Modify cache conditions for replacing the last-modified-bar - change (mediawiki...MobileFrontend)

2015-07-28 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Modify cache conditions for replacing the last-modified-bar
..


Modify cache conditions for replacing the last-modified-bar

Under normal page view, the .last-modified-bar element should also
have the classes, .pre-content and .post-content

In certain cached page situations the child element
causing the padding to be applied inside the .last-modified-bar
(this was introduced by I0cabfe404d17232521eacf9d19dcd3b36b52a7b1)

Bug: T107104
Change-Id: Iba6e4160d23282ecd309ed64cfa8fbb1da012b6c
---
M resources/mobile.head/init.js
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.head/init.js b/resources/mobile.head/init.js
index d0df854..a4fb107 100644
--- a/resources/mobile.head/init.js
+++ b/resources/mobile.head/init.js
@@ -57,7 +57,11 @@
] );
 
// FIXME: remove the if part when the cache clears.
-   if ( isPageCached || $lastModifiedLink.hasClass( 
'truncated-text' ) ) {
+   if (
+   isPageCached ||
+   $lastModifiedLink.hasClass( 'truncated-text' ) 
||
+   $lastModified.hasClass( 'pre-content' )
+   ) {
$lastModifiedBar.replaceWith(
$( '' )
.html(

-- 
To view, visit https://gerrit.wikimedia.org/r/227495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba6e4160d23282ecd309ed64cfa8fbb1da012b6c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen 
Gerrit-Reviewer: BarryTheBrowserTestBot 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Modify cache conditions for replacing the last-modified-bar - change (mediawiki...MobileFrontend)

2015-07-28 Thread Robmoen (Code Review)
Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227495

Change subject: Modify cache conditions for replacing the last-modified-bar
..

Modify cache conditions for replacing the last-modified-bar

Under normal page view, the .last-modified-bar element should also
have the classes, .pre-content and .post-content

In certain cached page situations the child element
causing the padding to be applied inside the .last-modified-bar

Bug: T107104
Change-Id: Iba6e4160d23282ecd309ed64cfa8fbb1da012b6c
---
M resources/mobile.head/init.js
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/95/227495/1

diff --git a/resources/mobile.head/init.js b/resources/mobile.head/init.js
index d0df854..a4fb107 100644
--- a/resources/mobile.head/init.js
+++ b/resources/mobile.head/init.js
@@ -57,7 +57,11 @@
] );
 
// FIXME: remove the if part when the cache clears.
-   if ( isPageCached || $lastModifiedLink.hasClass( 
'truncated-text' ) ) {
+   if (
+   isPageCached ||
+   $lastModifiedLink.hasClass( 'truncated-text' ) 
||
+   $lastModified.hasClass( 'pre-content' )
+   ) {
$lastModifiedBar.replaceWith(
$( '' )
.html(

-- 
To view, visit https://gerrit.wikimedia.org/r/227495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba6e4160d23282ecd309ed64cfa8fbb1da012b6c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits