[MediaWiki-commits] [Gerrit] Modifying survey banner bucketing - change (wikimedia/portals)
jenkins-bot has submitted this change and it was merged.
Change subject: Modifying survey banner bucketing
..
Modifying survey banner bucketing
Change-Id: I58ccf192d76f559e8b527a4a5702ea5a75ccd5f9
---
M dev/wikipedia.org/assets/js/wm-test.js
M dev/wikipedia.org/assets/rev-manifest.json
R prod/wikipedia.org/assets/js/index-25047ca0f0.js
M prod/wikipedia.org/index.html
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jdrewniak: Looks good to me, approved
jenkins-bot: Verified
diff --git a/dev/wikipedia.org/assets/js/wm-test.js
b/dev/wikipedia.org/assets/js/wm-test.js
index c578c29..7185f79 100644
--- a/dev/wikipedia.org/assets/js/wm-test.js
+++ b/dev/wikipedia.org/assets/js/wm-test.js
@@ -111,7 +111,7 @@
/**
* Qaultrics Survey Banner
* ---
-* Display survey banner to 1 in 500 users in the 'rejected' group.
+* Display survey banner to 1 in 30 users in the 'rejected' group.
* We only target rejected users because our schema doesn't have a
* 'survey-banner' clickthrough group, and thus clickthough events
* for these users would not be logged.
@@ -119,8 +119,8 @@
*/
function surveyBanner() {
- // only display banner to 1 in 500 users in the 'rejected' group
- if ( ( oneIn( sessionId, 50 ) && group === 'rejected' ) ||
testOnly ) {
+ // only display banner to 1 in 30 users in the 'rejected' group
+ if ( ( oneIn( sessionId, 30 ) && group === 'rejected' ) ||
testOnly ) {
// see if existing cookie to hide banner exists.
if ( document.cookie.match( /hideBanner/ ) && testOnly
=== false ) {
diff --git a/dev/wikipedia.org/assets/rev-manifest.json
b/dev/wikipedia.org/assets/rev-manifest.json
index e6f9b21..f8dc768 100644
--- a/dev/wikipedia.org/assets/rev-manifest.json
+++ b/dev/wikipedia.org/assets/rev-manifest.json
@@ -1,4 +1,4 @@
{
"portal/wikipedia.org/assets/js/gt-ie9.js":
"portal/wikipedia.org/assets/js/gt-ie9-c84bf66d33.js",
- "portal/wikipedia.org/assets/js/index.js":
"portal/wikipedia.org/assets/js/index-4ca9781cc0.js"
+ "portal/wikipedia.org/assets/js/index.js":
"portal/wikipedia.org/assets/js/index-25047ca0f0.js"
}
\ No newline at end of file
diff --git a/prod/wikipedia.org/assets/js/index-4ca9781cc0.js
b/prod/wikipedia.org/assets/js/index-25047ca0f0.js
similarity index 99%
rename from prod/wikipedia.org/assets/js/index-4ca9781cc0.js
rename to prod/wikipedia.org/assets/js/index-25047ca0f0.js
index 1dd8a14..3678e61 100644
--- a/prod/wikipedia.org/assets/js/index-4ca9781cc0.js
+++ b/prod/wikipedia.org/assets/js/index-25047ca0f0.js
@@ -1 +1 @@
-function
addEvent(e,t,n){e&&(e.addEventListener?e.addEventListener(t,n,!1):e.attachEvent&&(attachedEvents.push([e,t,n]),e.attachEvent("on"+t,n)))}function
removeEvent(e,t,n){e&&(e.removeEventListener?e.removeEventListener(t,n):e.detachEvent&&e.detachEvent("on"+t,n))}function
doWhenReady(e){var
t=function(){removeEvent(document,"DOMContentLoaded",t),removeEvent(window,"load",t),e()};"complete"===document.readyState?e():(addEvent(document,"DOMContentLoaded",t),addEvent(window,"load",t))}function
getIso639(e){var t=e&&e.match(/^\w+/);if(t)return
t="nb"===t[0]?"no":t[0]}function getDevicePixelRatio(){return void
0!==window.devicePixelRatio?window.devicePixelRatio:void
0!==window.msMatchMedia?window.msMatchMedia("(min-resolution:
192dpi)").matches?2:window.msMatchMedia("(min-resolution:
144dpi)").matches?1.5:1:1}window.JSON||(window.JSON={parse:function(sJSON){return
eval("("+sJSON+")")},stringify:function(){var
e=Object.prototype.toString,t=Array.isArray||function(t){return"[object
Array]"===e.call(t)},n={'"':'\\"',"\\":"","\b":"\\b","\f":"\\f","\n":"\\n","\r":"\\r","
":"\\t"},r=function(e){return
n[e]||"\\u"+(e.charCodeAt(0)+65536).toString(16).substr(1)},o=/[\\"\u-\u001F\u2028\u2029]/g;return
function i(n){if(null==n)return"null";if("number"==typeof n)return
isFinite(n)?n.toString():"null";if("boolean"==typeof n)return
n.toString();if("object"==typeof n){if("function"==typeof n.toJSON)return
i(n.toJSON());if(t(n)){for(var a="[",s=0;s>>0;if(0===o)return-1;var
i=+t||0;if(Math.abs(i)===1/0&&(i=0),i>=o)return-1;for(n=Math.max(i>=0?i:o-Math.abs(i),0);o>n;){if(n
in r&&r[n]===e)return
n;n++}return-1}),function(){window.document.querySelectorAll||(document.querySelectorAll=document.body.querySelectorAll=Object.querySelectorAll=function(e,t,n,r,o){var
i=document,a=i.createStyleSheet();for(o=i.all,t=[],e=e.replace(/\[for\b/gi,"[htmlFor").split(","),n=e.length;n--;){for(a.addRule(e[n],"k:v"),r=o.length;r--;)o[r].currentStyle.k&&t.push(o[r]);a.removeRule(0)}return
t})}(),document.querySelector||(document.querySelector=function(e){var
t=document.querySelectorAll(e);return
t.length?t[0]:null}),Function.prototype.bind||(Function.prototyp
[MediaWiki-commits] [Gerrit] Modifying survey banner bucketing - change (wikimedia/portals)
Jdrewniak has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289213
Change subject: Modifying survey banner bucketing
..
Modifying survey banner bucketing
Change-Id: I58ccf192d76f559e8b527a4a5702ea5a75ccd5f9
---
M dev/wikipedia.org/assets/js/wm-test.js
M dev/wikipedia.org/assets/rev-manifest.json
R prod/wikipedia.org/assets/js/index-25047ca0f0.js
M prod/wikipedia.org/index.html
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/portals
refs/changes/13/289213/1
diff --git a/dev/wikipedia.org/assets/js/wm-test.js
b/dev/wikipedia.org/assets/js/wm-test.js
index c578c29..7185f79 100644
--- a/dev/wikipedia.org/assets/js/wm-test.js
+++ b/dev/wikipedia.org/assets/js/wm-test.js
@@ -111,7 +111,7 @@
/**
* Qaultrics Survey Banner
* ---
-* Display survey banner to 1 in 500 users in the 'rejected' group.
+* Display survey banner to 1 in 30 users in the 'rejected' group.
* We only target rejected users because our schema doesn't have a
* 'survey-banner' clickthrough group, and thus clickthough events
* for these users would not be logged.
@@ -119,8 +119,8 @@
*/
function surveyBanner() {
- // only display banner to 1 in 500 users in the 'rejected' group
- if ( ( oneIn( sessionId, 50 ) && group === 'rejected' ) ||
testOnly ) {
+ // only display banner to 1 in 30 users in the 'rejected' group
+ if ( ( oneIn( sessionId, 30 ) && group === 'rejected' ) ||
testOnly ) {
// see if existing cookie to hide banner exists.
if ( document.cookie.match( /hideBanner/ ) && testOnly
=== false ) {
diff --git a/dev/wikipedia.org/assets/rev-manifest.json
b/dev/wikipedia.org/assets/rev-manifest.json
index e6f9b21..f8dc768 100644
--- a/dev/wikipedia.org/assets/rev-manifest.json
+++ b/dev/wikipedia.org/assets/rev-manifest.json
@@ -1,4 +1,4 @@
{
"portal/wikipedia.org/assets/js/gt-ie9.js":
"portal/wikipedia.org/assets/js/gt-ie9-c84bf66d33.js",
- "portal/wikipedia.org/assets/js/index.js":
"portal/wikipedia.org/assets/js/index-4ca9781cc0.js"
+ "portal/wikipedia.org/assets/js/index.js":
"portal/wikipedia.org/assets/js/index-25047ca0f0.js"
}
\ No newline at end of file
diff --git a/prod/wikipedia.org/assets/js/index-4ca9781cc0.js
b/prod/wikipedia.org/assets/js/index-25047ca0f0.js
similarity index 99%
rename from prod/wikipedia.org/assets/js/index-4ca9781cc0.js
rename to prod/wikipedia.org/assets/js/index-25047ca0f0.js
index 1dd8a14..3678e61 100644
--- a/prod/wikipedia.org/assets/js/index-4ca9781cc0.js
+++ b/prod/wikipedia.org/assets/js/index-25047ca0f0.js
@@ -1 +1 @@
-function
addEvent(e,t,n){e&&(e.addEventListener?e.addEventListener(t,n,!1):e.attachEvent&&(attachedEvents.push([e,t,n]),e.attachEvent("on"+t,n)))}function
removeEvent(e,t,n){e&&(e.removeEventListener?e.removeEventListener(t,n):e.detachEvent&&e.detachEvent("on"+t,n))}function
doWhenReady(e){var
t=function(){removeEvent(document,"DOMContentLoaded",t),removeEvent(window,"load",t),e()};"complete"===document.readyState?e():(addEvent(document,"DOMContentLoaded",t),addEvent(window,"load",t))}function
getIso639(e){var t=e&&e.match(/^\w+/);if(t)return
t="nb"===t[0]?"no":t[0]}function getDevicePixelRatio(){return void
0!==window.devicePixelRatio?window.devicePixelRatio:void
0!==window.msMatchMedia?window.msMatchMedia("(min-resolution:
192dpi)").matches?2:window.msMatchMedia("(min-resolution:
144dpi)").matches?1.5:1:1}window.JSON||(window.JSON={parse:function(sJSON){return
eval("("+sJSON+")")},stringify:function(){var
e=Object.prototype.toString,t=Array.isArray||function(t){return"[object
Array]"===e.call(t)},n={'"':'\\"',"\\":"","\b":"\\b","\f":"\\f","\n":"\\n","\r":"\\r","
":"\\t"},r=function(e){return
n[e]||"\\u"+(e.charCodeAt(0)+65536).toString(16).substr(1)},o=/[\\"\u-\u001F\u2028\u2029]/g;return
function i(n){if(null==n)return"null";if("number"==typeof n)return
isFinite(n)?n.toString():"null";if("boolean"==typeof n)return
n.toString();if("object"==typeof n){if("function"==typeof n.toJSON)return
i(n.toJSON());if(t(n)){for(var a="[",s=0;s>>0;if(0===o)return-1;var
i=+t||0;if(Math.abs(i)===1/0&&(i=0),i>=o)return-1;for(n=Math.max(i>=0?i:o-Math.abs(i),0);o>n;){if(n
in r&&r[n]===e)return
n;n++}return-1}),function(){window.document.querySelectorAll||(document.querySelectorAll=document.body.querySelectorAll=Object.querySelectorAll=function(e,t,n,r,o){var
i=document,a=i.createStyleSheet();for(o=i.all,t=[],e=e.replace(/\[for\b/gi,"[htmlFor").split(","),n=e.length;n--;){for(a.addRule(e[n],"k:v"),r=o.length;r--;)o[r].currentStyle.k&&t.push(o[r]);a.removeRule(0)}return
t})}(),document.querySelector||(document.querySelector=function(e){var
t=document.querySelectorAll(e);return
t.length?t[0]:null}),
