[MediaWiki-commits] [Gerrit] More GET not POST fixes. - change (apps...wikipedia)

2014-04-28 Thread Brion VIBBER (Code Review) 
Brion VIBBER has submitted this change and it was merged.

Change subject: More GET not POST fixes.
..


More GET not POST fixes.

Change-Id: Ie31f2c8538567560b7364226a2d48ff3e6b055b0
---
M wikipedia/Data/Operations/DownloadLangLinksOp.m
M wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
M wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
M wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
M wikipedia/Data/Operations/PageHistoryOp.m
M wikipedia/Data/Operations/PreviewWikiTextOp.m
M wikipedia/Data/Operations/SearchOp.m
M wikipedia/Data/Operations/SearchThumbUrlsOp.m
8 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/wikipedia/Data/Operations/DownloadLangLinksOp.m 
b/wikipedia/Data/Operations/DownloadLangLinksOp.m
index 4946b03..0d44e4b 100644
--- a/wikipedia/Data/Operations/DownloadLangLinksOp.m
+++ b/wikipedia/Data/Operations/DownloadLangLinksOp.m
@@ -17,7 +17,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@prop: 
@langlinks,
diff --git a/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m 
b/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
index 2fbaf82..3acf185 100644
--- a/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
+++ b/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
@@ -18,7 +18,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@prop: 
@revisions,
diff --git a/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m 
b/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
index 732dd08..dd0a89b 100644
--- a/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
+++ b/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
@@ -18,7 +18,7 @@
 if (self) {
 // FUTURE FEATURE: Get multiple titles, and cache them so they're 
readily available
 // Will need to consider things like article language changes, though.
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@list: @random,
diff --git a/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m 
b/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
index 801938a..6d3da92 100644
--- a/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
+++ b/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
@@ -16,7 +16,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: 
@zeroconfig,
@type: @message,
diff --git a/wikipedia/Data/Operations/PageHistoryOp.m 
b/wikipedia/Data/Operations/PageHistoryOp.m
index 796c6bb..7ae44f2 100644
--- a/wikipedia/Data/Operations/PageHistoryOp.m
+++ b/wikipedia/Data/Operations/PageHistoryOp.m
@@ -38,7 +38,7 @@
 
 //NSLog(@parameters = %@, parameters);
 
-weakSelf.request = [NSURLRequest postRequestWithURL: [NSURL 
URLWithString:[SessionSingleton sharedInstance].searchApiUrl]
+weakSelf.request = [NSURLRequest getRequestWithURL: [NSURL 
URLWithString:[SessionSingleton sharedInstance].searchApiUrl]
  parameters: parameters
 ];
 };
diff --git a/wikipedia/Data/Operations/PreviewWikiTextOp.m 
b/wikipedia/Data/Operations/PreviewWikiTextOp.m
index c5abe86..b94479c 100644
--- a/wikipedia/Data/Operations/PreviewWikiTextOp.m

[MediaWiki-commits] [Gerrit] More GET not POST fixes. - change (apps...wikipedia)

2014-04-25 Thread Mhurd (Code Review) 
Mhurd has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/129843

Change subject: More GET not POST fixes.
..

More GET not POST fixes.

Change-Id: Ie31f2c8538567560b7364226a2d48ff3e6b055b0
---
M wikipedia/Data/Operations/DownloadLangLinksOp.m
M wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
M wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
M wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
M wikipedia/Data/Operations/PageHistoryOp.m
M wikipedia/Data/Operations/PreviewWikiTextOp.m
M wikipedia/Data/Operations/SearchOp.m
M wikipedia/Data/Operations/SearchThumbUrlsOp.m
8 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/43/129843/1

diff --git a/wikipedia/Data/Operations/DownloadLangLinksOp.m 
b/wikipedia/Data/Operations/DownloadLangLinksOp.m
index 4946b03..0d44e4b 100644
--- a/wikipedia/Data/Operations/DownloadLangLinksOp.m
+++ b/wikipedia/Data/Operations/DownloadLangLinksOp.m
@@ -17,7 +17,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@prop: 
@langlinks,
diff --git a/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m 
b/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
index 2fbaf82..3acf185 100644
--- a/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
+++ b/wikipedia/Data/Operations/DownloadSectionWikiTextOp.m
@@ -18,7 +18,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@prop: 
@revisions,
diff --git a/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m 
b/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
index 732dd08..dd0a89b 100644
--- a/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
+++ b/wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m
@@ -18,7 +18,7 @@
 if (self) {
 // FUTURE FEATURE: Get multiple titles, and cache them so they're 
readily available
 // Will need to consider things like article language changes, though.
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: @query,
@list: @random,
diff --git a/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m 
b/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
index 801938a..6d3da92 100644
--- a/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
+++ b/wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m
@@ -16,7 +16,7 @@
 {
 self = [super init];
 if (self) {
-self.request = [NSURLRequest postRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
+self.request = [NSURLRequest getRequestWithURL: [[SessionSingleton 
sharedInstance] urlForDomain:domain]
  parameters: @{
@action: 
@zeroconfig,
@type: @message,
diff --git a/wikipedia/Data/Operations/PageHistoryOp.m 
b/wikipedia/Data/Operations/PageHistoryOp.m
index 796c6bb..7ae44f2 100644
--- a/wikipedia/Data/Operations/PageHistoryOp.m
+++ b/wikipedia/Data/Operations/PageHistoryOp.m
@@ -38,7 +38,7 @@
 
 //NSLog(@parameters = %@, parameters);
 
-weakSelf.request = [NSURLRequest postRequestWithURL: [NSURL 
URLWithString:[SessionSingleton sharedInstance].searchApiUrl]
+weakSelf.request = [NSURLRequest getRequestWithURL: [NSURL 
URLWithString:[SessionSingleton sharedInstance].searchApiUrl]
  parameters: parameters
 ];
 };
diff --git a/wikipedia/Data/Operations/PreviewWikiTextOp.m 
b/wikipedia/Data/Operations/PreviewWikiTextOp.m
index c5abe86..f20c622 100644
---