[MediaWiki-commits] [Gerrit] Move PageContentSaveComplete out; intended to be in CoreEvents - change (mediawiki...EventLogging)

2013-06-11 Thread Mattflaschen (Code Review) 
Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/68119


Change subject: Move PageContentSaveComplete out; intended to be in CoreEvents
..

Move PageContentSaveComplete out; intended to be in CoreEvents

Change-Id: I2fafa3e5325bdfabbffc74f4691c839fb44c6742
---
M EventLogging.hooks.php
M EventLogging.php
2 files changed, 0 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/19/68119/1

diff --git a/EventLogging.hooks.php b/EventLogging.hooks.php
index d9bf88c..0ea5090 100644
--- a/EventLogging.hooks.php
+++ b/EventLogging.hooks.php
@@ -36,24 +36,6 @@
}
 
/**
-* Log server-side event on successful page edit.
-* @see 
https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
-* @see https://meta.wikimedia.org/wiki/Schema:PageContentSaveComplete
-*/
-   public static function onPageContentSaveComplete( $article, $user, 
$content, $summary,
-   $isMinor, $isWatch, $section, $flags, $revision, $status, 
$baseRevId ) {
-
-   if ( $revision ) {
-   $event = array( 'revisionId' = $revision-getId() );
-   if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
-   $event[ 'userAgent' ] = $_SERVER[ 
'HTTP_USER_AGENT' ];
-   }
-   efLogServerSideEvent( 'PageContentSaveComplete', 
5303086, $event );
-   }
-   return true;
-   }
-
-   /**
 * @param array $vars
 * @return bool
 */
diff --git a/EventLogging.php b/EventLogging.php
index f80c086..aabdd25 100644
--- a/EventLogging.php
+++ b/EventLogging.php
@@ -242,7 +242,6 @@
 
 $wgExtensionFunctions[] = 'EventLoggingHooks::onSetup';
 
-$wgHooks[ 'PageContentSaveComplete' ][] = 
'EventLoggingHooks::onPageContentSaveComplete';
 $wgHooks[ 'ResourceLoaderGetConfigVars' ][] = 
'EventLoggingHooks::onResourceLoaderGetConfigVars';
 $wgHooks[ 'ResourceLoaderTestModules' ][] = 
'EventLoggingHooks::onResourceLoaderTestModules';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/68119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fafa3e5325bdfabbffc74f4691c839fb44c6742
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move PageContentSaveComplete out; intended to be in CoreEvents - change (mediawiki...EventLogging)

2013-06-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Move PageContentSaveComplete out; intended to be in CoreEvents
..


Move PageContentSaveComplete out; intended to be in CoreEvents

Change-Id: I2fafa3e5325bdfabbffc74f4691c839fb44c6742
---
M EventLogging.hooks.php
M EventLogging.php
2 files changed, 0 insertions(+), 19 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/EventLogging.hooks.php b/EventLogging.hooks.php
index d9bf88c..0ea5090 100644
--- a/EventLogging.hooks.php
+++ b/EventLogging.hooks.php
@@ -36,24 +36,6 @@
}
 
/**
-* Log server-side event on successful page edit.
-* @see 
https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
-* @see https://meta.wikimedia.org/wiki/Schema:PageContentSaveComplete
-*/
-   public static function onPageContentSaveComplete( $article, $user, 
$content, $summary,
-   $isMinor, $isWatch, $section, $flags, $revision, $status, 
$baseRevId ) {
-
-   if ( $revision ) {
-   $event = array( 'revisionId' = $revision-getId() );
-   if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
-   $event[ 'userAgent' ] = $_SERVER[ 
'HTTP_USER_AGENT' ];
-   }
-   efLogServerSideEvent( 'PageContentSaveComplete', 
5303086, $event );
-   }
-   return true;
-   }
-
-   /**
 * @param array $vars
 * @return bool
 */
diff --git a/EventLogging.php b/EventLogging.php
index f80c086..aabdd25 100644
--- a/EventLogging.php
+++ b/EventLogging.php
@@ -242,7 +242,6 @@
 
 $wgExtensionFunctions[] = 'EventLoggingHooks::onSetup';
 
-$wgHooks[ 'PageContentSaveComplete' ][] = 
'EventLoggingHooks::onPageContentSaveComplete';
 $wgHooks[ 'ResourceLoaderGetConfigVars' ][] = 
'EventLoggingHooks::onResourceLoaderGetConfigVars';
 $wgHooks[ 'ResourceLoaderTestModules' ][] = 
'EventLoggingHooks::onResourceLoaderTestModules';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/68119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fafa3e5325bdfabbffc74f4691c839fb44c6742
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Spage sp...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits