[MediaWiki-commits] [Gerrit] Move Client Hooks classes to Hooks folder/namespace - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Move Client Hooks classes to Hooks folder/namespace .. Move Client Hooks classes to Hooks folder/namespace The folder in Wikibase Client was called "hooks" (lowercase plural), the folder in Wikibase Repo was called "Hook" (uppercase singular). The two patches If466217 and If9295f0 make these two equal. A lot more folders/namespaces need to be cleaned up the same way but I want to do this in patches that are as small as possible. Change-Id: If4662170bf8c644d27a32c522d30bd62258eb9a2 --- M client/WikibaseClient.hooks.php R client/includes/Hooks/BaseTemplateAfterPortletHandler.php R client/includes/Hooks/BeforePageDisplayHandler.php R client/includes/Hooks/ChangesPageWikibaseFilterHandler.php R client/includes/Hooks/DataUpdateHookHandlers.php R client/includes/Hooks/DeletePageNoticeCreator.php R client/includes/Hooks/InfoActionHookHandler.php R client/includes/Hooks/LanguageLinkBadgeDisplay.php R client/includes/Hooks/MovePageNoticeCreator.php R client/includes/Hooks/OtherProjectsSidebarGenerator.php R client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php R client/includes/Hooks/ParserAfterParseHookHandler.php R client/includes/Hooks/ParserFunctionRegistrant.php R client/includes/Hooks/SidebarHookHandlers.php R client/includes/Hooks/SpecialWatchlistQueryHandler.php R client/includes/Hooks/UpdateRepoHookHandlers.php R client/tests/phpunit/includes/Hooks/BaseTemplateAfterPortalHandlerTest.php R client/tests/phpunit/includes/Hooks/BeforePageDisplayHandlerTest.php R client/tests/phpunit/includes/Hooks/ChangesPageWikibaseFilterHandlerTest.php R client/tests/phpunit/includes/Hooks/DataUpdateHookHandlersTest.php R client/tests/phpunit/includes/Hooks/DeletePageNoticeCreatorTest.php R client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php R client/tests/phpunit/includes/Hooks/LanguageLinkBadgeDisplayTest.php R client/tests/phpunit/includes/Hooks/MovePageNoticeCreatorTest.php R client/tests/phpunit/includes/Hooks/NoLangLinkHandlerTest.php R client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorFactoryTest.php R client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php R client/tests/phpunit/includes/Hooks/ParserAfterParserHookHandlerTest.php R client/tests/phpunit/includes/Hooks/ParserFunctionRegistrantTest.php R client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php R client/tests/phpunit/includes/Hooks/SpecialWatchlistQueryHandlerTest.php 31 files changed, 21 insertions(+), 15 deletions(-) Approvals: Hashar: Looks good to me, approved JanZerebecki: Looks good to me, approved jenkins-bot: Verified diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index 82a8139..b62627c 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -23,13 +23,13 @@ use UnexpectedValueException; use User; use Wikibase\Client\Changes\ChangeHandler; -use Wikibase\Client\DeletePageNoticeCreator; use Wikibase\Client\Hooks\BaseTemplateAfterPortletHandler; use Wikibase\Client\Hooks\BeforePageDisplayHandler; use Wikibase\Client\Hooks\ChangesPageWikibaseFilterHandler; +use Wikibase\Client\Hooks\DeletePageNoticeCreator; use Wikibase\Client\Hooks\InfoActionHookHandler; +use Wikibase\Client\Hooks\MovePageNoticeCreator; use Wikibase\Client\Hooks\SpecialWatchlistQueryHandler; -use Wikibase\Client\MovePageNoticeCreator; use Wikibase\Client\RecentChanges\ChangeLineFormatter; use Wikibase\Client\RecentChanges\ExternalChangeFactory; use Wikibase\Client\RecentChanges\RecentChangesFilterOptions; diff --git a/client/includes/hooks/BaseTemplateAfterPortletHandler.php b/client/includes/Hooks/BaseTemplateAfterPortletHandler.php similarity index 100% rename from client/includes/hooks/BaseTemplateAfterPortletHandler.php rename to client/includes/Hooks/BaseTemplateAfterPortletHandler.php diff --git a/client/includes/hooks/BeforePageDisplayHandler.php b/client/includes/Hooks/BeforePageDisplayHandler.php similarity index 100% rename from client/includes/hooks/BeforePageDisplayHandler.php rename to client/includes/Hooks/BeforePageDisplayHandler.php diff --git a/client/includes/hooks/ChangesPageWikibaseFilterHandler.php b/client/includes/Hooks/ChangesPageWikibaseFilterHandler.php similarity index 100% rename from client/includes/hooks/ChangesPageWikibaseFilterHandler.php rename to client/includes/Hooks/ChangesPageWikibaseFilterHandler.php diff --git a/client/includes/hooks/DataUpdateHookHandlers.php b/client/includes/Hooks/DataUpdateHookHandlers.php similarity index 100% rename from client/includes/hooks/DataUpdateHookHandlers.php rename to client/includes/Hooks/DataUpdateHookHandlers.php diff --git a/client/includes/hooks/DeletePageNoticeCreator.php b/client/includes/Hooks/DeletePageNoticeCreator.php similarity index 96% rename from client/includes/hooks/DeletePageNoticeCreator.php rename
[MediaWiki-commits] [Gerrit] Move client Hooks classes to Hooks folder/namespace - change (mediawiki...Wikibase)
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176660 Change subject: Move client Hooks classes to Hooks folder/namespace .. Move client Hooks classes to Hooks folder/namespace Change-Id: If4662170bf8c644d27a32c522d30bd62258eb9a2 --- M client/WikibaseClient.hooks.php R client/includes/Hooks/BaseTemplateAfterPortletHandler.php R client/includes/Hooks/BeforePageDisplayHandler.php R client/includes/Hooks/ChangesPageWikibaseFilterHandler.php R client/includes/Hooks/DataUpdateHookHandlers.php R client/includes/Hooks/DeletePageNoticeCreator.php R client/includes/Hooks/InfoActionHookHandler.php R client/includes/Hooks/LanguageLinkBadgeDisplay.php R client/includes/Hooks/MovePageNoticeCreator.php R client/includes/Hooks/OtherProjectsSidebarGenerator.php R client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php R client/includes/Hooks/ParserAfterParseHookHandler.php R client/includes/Hooks/ParserFunctionRegistrant.php R client/includes/Hooks/SidebarHookHandlers.php R client/includes/Hooks/SpecialWatchlistQueryHandler.php R client/includes/Hooks/UpdateRepoHookHandlers.php M client/tests/phpunit/includes/hooks/DeletePageNoticeCreatorTest.php M client/tests/phpunit/includes/hooks/MovePageNoticeCreatorTest.php 18 files changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/60/176660/1 diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php index 5cc19e5..c6c1fcd 100644 --- a/client/WikibaseClient.hooks.php +++ b/client/WikibaseClient.hooks.php @@ -5,7 +5,6 @@ use Action; use BaseTemplate; use ChangesList; -use Content; use FormOptions; use IContextSource; use Message; @@ -24,23 +23,20 @@ use UnexpectedValueException; use User; use Wikibase\Client\Changes\ChangeHandler; -use Wikibase\Client\DeletePageNoticeCreator; use Wikibase\Client\Hooks\BaseTemplateAfterPortletHandler; use Wikibase\Client\Hooks\BeforePageDisplayHandler; use Wikibase\Client\Hooks\ChangesPageWikibaseFilterHandler; +use Wikibase\Client\Hooks\DeletePageNoticeCreator; use Wikibase\Client\Hooks\InfoActionHookHandler; +use Wikibase\Client\Hooks\MovePageNoticeCreator; use Wikibase\Client\Hooks\SpecialWatchlistQueryHandler; -use Wikibase\Client\MovePageNoticeCreator; use Wikibase\Client\RecentChanges\ChangeLineFormatter; use Wikibase\Client\RecentChanges\ExternalChangeFactory; use Wikibase\Client\RecentChanges\RecentChangesFilterOptions; use Wikibase\Client\RepoItemLinkGenerator; -use Wikibase\Client\UpdateRepo\UpdateRepoOnDelete; -use Wikibase\Client\UpdateRepo\UpdateRepoOnMove; use Wikibase\Client\WikibaseClient; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\SiteLink; -use WikiPage; /** * File defining the hook handlers for the Wikibase Client extension. diff --git a/client/includes/hooks/BaseTemplateAfterPortletHandler.php b/client/includes/Hooks/BaseTemplateAfterPortletHandler.php similarity index 100% rename from client/includes/hooks/BaseTemplateAfterPortletHandler.php rename to client/includes/Hooks/BaseTemplateAfterPortletHandler.php diff --git a/client/includes/hooks/BeforePageDisplayHandler.php b/client/includes/Hooks/BeforePageDisplayHandler.php similarity index 100% rename from client/includes/hooks/BeforePageDisplayHandler.php rename to client/includes/Hooks/BeforePageDisplayHandler.php diff --git a/client/includes/hooks/ChangesPageWikibaseFilterHandler.php b/client/includes/Hooks/ChangesPageWikibaseFilterHandler.php similarity index 100% rename from client/includes/hooks/ChangesPageWikibaseFilterHandler.php rename to client/includes/Hooks/ChangesPageWikibaseFilterHandler.php diff --git a/client/includes/hooks/DataUpdateHookHandlers.php b/client/includes/Hooks/DataUpdateHookHandlers.php similarity index 100% rename from client/includes/hooks/DataUpdateHookHandlers.php rename to client/includes/Hooks/DataUpdateHookHandlers.php diff --git a/client/includes/hooks/DeletePageNoticeCreator.php b/client/includes/Hooks/DeletePageNoticeCreator.php similarity index 96% rename from client/includes/hooks/DeletePageNoticeCreator.php rename to client/includes/Hooks/DeletePageNoticeCreator.php index f1c4cb6..04af59f 100644 --- a/client/includes/hooks/DeletePageNoticeCreator.php +++ b/client/includes/Hooks/DeletePageNoticeCreator.php @@ -1,9 +1,10 @@ https://gerrit.wikimedia.org/r/176660 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4662170bf8c644d27a32c522d30bd62258eb9a2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
