[MediaWiki-commits] [Gerrit] Move dependency on ext.translateHooks to base module - change (mediawiki...Translate)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65338 Change subject: Move dependency on ext.translateHooks to base module .. Move dependency on ext.translateHooks to base module The dependency needs to be migrated to allow hooks to be used with "new" JavaScript. Given the expansion in the use of hooks, it is probably prudent to move it to be a base dependency now, at minimal performance cost. Change-Id: I8e4781852d328732813937831e9de558d7820b4d --- M Resources.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/38/65338/1 diff --git a/Resources.php b/Resources.php index aa3bd2c..dfe8d8a 100644 --- a/Resources.php +++ b/Resources.php @@ -21,6 +21,7 @@ 'dependencies' => array( 'mediawiki.util', 'mediawiki.api', + 'ext.translate.hooks' ), 'messages' => array( 'translate-js-support-unsaved-warning', @@ -209,7 +210,6 @@ 'styles' => 'resources/css/ext.translate.quickedit.css', 'messages' => array( 'translate-js-nonext', 'translate-js-save-failed' ), 'dependencies' => array( - 'ext.translate.hooks', 'jquery.form', 'jquery.ui.dialog', 'jquery.autoresize', -- To view, visit https://gerrit.wikimedia.org/r/65338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e4781852d328732813937831e9de558d7820b4d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Jarry1250 Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move dependency on ext.translateHooks to base module - change (mediawiki...Translate)
jenkins-bot has submitted this change and it was merged. Change subject: Move dependency on ext.translateHooks to base module .. Move dependency on ext.translateHooks to base module The dependency needs to be migrated to allow hooks to be used with "new" JavaScript. Given the expansion in the use of hooks, it is probably prudent to move it to be a base dependency now, at minimal performance cost. Change-Id: I8e4781852d328732813937831e9de558d7820b4d --- M Resources.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/Resources.php b/Resources.php index b0bee99..980a3fa 100644 --- a/Resources.php +++ b/Resources.php @@ -21,6 +21,7 @@ 'dependencies' => array( 'mediawiki.util', 'mediawiki.api', + 'ext.translate.hooks' ), 'messages' => array( 'translate-js-support-unsaved-warning', @@ -229,7 +230,6 @@ 'styles' => 'resources/css/ext.translate.quickedit.css', 'messages' => array( 'translate-js-nonext', 'translate-js-save-failed' ), 'dependencies' => array( - 'ext.translate.hooks', 'jquery.form', 'jquery.ui.dialog', 'jquery.autosize', -- To view, visit https://gerrit.wikimedia.org/r/65338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4781852d328732813937831e9de558d7820b4d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Jarry1250 Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
