[MediaWiki-commits] [Gerrit] Moved Ruby code that multiple repositories use to mediawiki_... - change (mediawiki...CirrusSearch)

2014-02-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Moved Ruby code that multiple repositories use to 
mediawiki_selenium Ruby gem
..


Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem

Bug: 56088
Change-Id: I5b3700173a5d2eda415a2187ee81f1f3cbe5aa3a
---
M tests/browser/Gemfile.lock
M tests/browser/features/step_definitions/general_steps.rb
D tests/browser/features/support/modules/url_module.rb
D tests/browser/features/support/pages/login_page.rb
4 files changed, 2 insertions(+), 31 deletions(-)

Approvals:
  Manybubbles: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
index 1a6578f..4539e75 100644
--- a/tests/browser/Gemfile.lock
+++ b/tests/browser/Gemfile.lock
@@ -22,7 +22,7 @@
 headless (1.0.1)
 i18n (0.6.9)
 json (1.8.1)
-mediawiki_selenium (0.2.1)
+mediawiki_selenium (0.2.2)
   cucumber (~ 1.3, = 1.3.10)
   headless (~ 1.0, = 1.0.1)
   json (~ 1.8, = 1.8.1)
@@ -34,7 +34,7 @@
 mime-types (2.1)
 multi_json (1.8.4)
 multi_test (0.0.3)
-net-http-persistent (2.9.3)
+net-http-persistent (2.9.4)
 page-object (0.9.6)
   page_navigation (= 0.9)
   selenium-webdriver (= 2.39.0)
diff --git a/tests/browser/features/step_definitions/general_steps.rb 
b/tests/browser/features/step_definitions/general_steps.rb
index 86910d5..5058da0 100644
--- a/tests/browser/features/step_definitions/general_steps.rb
+++ b/tests/browser/features/step_definitions/general_steps.rb
@@ -1,7 +1,3 @@
-Given(/^I am logged in$/) do
-  visit(LoginPage).login_with(ENV[MEDIAWIKI_USER], ENV[MEDIAWIKI_PASSWORD])
-end
-
 Given(/^I am at a random page.*$/) do
   visit RandomPage
 end
diff --git a/tests/browser/features/support/modules/url_module.rb 
b/tests/browser/features/support/modules/url_module.rb
deleted file mode 100644
index 1dd1856..000
--- a/tests/browser/features/support/modules/url_module.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-module URL
-  def self.url(name)
-if ENV[MEDIAWIKI_URL]
-  mediawiki_url = ENV[MEDIAWIKI_URL]
-else
-  mediawiki_url = http://en.wikipedia.beta.wmflabs.org/wiki/;
-end
-#{mediawiki_url}#{name}
-  end
-end
diff --git a/tests/browser/features/support/pages/login_page.rb 
b/tests/browser/features/support/pages/login_page.rb
deleted file mode 100644
index 54fc13e..000
--- a/tests/browser/features/support/pages/login_page.rb
+++ /dev/null
@@ -1,15 +0,0 @@
-class LoginPage
-  include PageObject
-
-  page_url URL.url(Special:UserLogin)
-
-  button(:login, id: wpLoginAttempt)
-  text_field(:password, id: wpPassword1)
-  text_field(:username, id: wpName1)
-
-  def login_with(username, password)
-self.username = username
-self.password = password
-login
-  end
-end

-- 
To view, visit https://gerrit.wikimedia.org/r/112672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b3700173a5d2eda415a2187ee81f1f3cbe5aa3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Jhall jh...@wikimedia.org
Gerrit-Reviewer: Manybubbles never...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Moved Ruby code that multiple repositories use to mediawiki_... - change (mediawiki...CirrusSearch)

2014-02-11 Thread Zfilipin (Code Review) 
Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112672

Change subject: Moved Ruby code that multiple repositories use to 
mediawiki_selenium Ruby gem
..

Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem

Bug: 56088
Change-Id: I5b3700173a5d2eda415a2187ee81f1f3cbe5aa3a
---
M tests/browser/Gemfile.lock
M tests/browser/features/step_definitions/general_steps.rb
D tests/browser/features/support/modules/url_module.rb
D tests/browser/features/support/pages/login_page.rb
4 files changed, 2 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/72/112672/1

diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
index 1a6578f..4539e75 100644
--- a/tests/browser/Gemfile.lock
+++ b/tests/browser/Gemfile.lock
@@ -22,7 +22,7 @@
 headless (1.0.1)
 i18n (0.6.9)
 json (1.8.1)
-mediawiki_selenium (0.2.1)
+mediawiki_selenium (0.2.2)
   cucumber (~ 1.3, = 1.3.10)
   headless (~ 1.0, = 1.0.1)
   json (~ 1.8, = 1.8.1)
@@ -34,7 +34,7 @@
 mime-types (2.1)
 multi_json (1.8.4)
 multi_test (0.0.3)
-net-http-persistent (2.9.3)
+net-http-persistent (2.9.4)
 page-object (0.9.6)
   page_navigation (= 0.9)
   selenium-webdriver (= 2.39.0)
diff --git a/tests/browser/features/step_definitions/general_steps.rb 
b/tests/browser/features/step_definitions/general_steps.rb
index 86910d5..5058da0 100644
--- a/tests/browser/features/step_definitions/general_steps.rb
+++ b/tests/browser/features/step_definitions/general_steps.rb
@@ -1,7 +1,3 @@
-Given(/^I am logged in$/) do
-  visit(LoginPage).login_with(ENV[MEDIAWIKI_USER], ENV[MEDIAWIKI_PASSWORD])
-end
-
 Given(/^I am at a random page.*$/) do
   visit RandomPage
 end
diff --git a/tests/browser/features/support/modules/url_module.rb 
b/tests/browser/features/support/modules/url_module.rb
deleted file mode 100644
index 1dd1856..000
--- a/tests/browser/features/support/modules/url_module.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-module URL
-  def self.url(name)
-if ENV[MEDIAWIKI_URL]
-  mediawiki_url = ENV[MEDIAWIKI_URL]
-else
-  mediawiki_url = http://en.wikipedia.beta.wmflabs.org/wiki/;
-end
-#{mediawiki_url}#{name}
-  end
-end
diff --git a/tests/browser/features/support/pages/login_page.rb 
b/tests/browser/features/support/pages/login_page.rb
deleted file mode 100644
index 54fc13e..000
--- a/tests/browser/features/support/pages/login_page.rb
+++ /dev/null
@@ -1,15 +0,0 @@
-class LoginPage
-  include PageObject
-
-  page_url URL.url(Special:UserLogin)
-
-  button(:login, id: wpLoginAttempt)
-  text_field(:password, id: wpPassword1)
-  text_field(:username, id: wpName1)
-
-  def login_with(username, password)
-self.username = username
-self.password = password
-login
-  end
-end

-- 
To view, visit https://gerrit.wikimedia.org/r/112672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3700173a5d2eda415a2187ee81f1f3cbe5aa3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits