[MediaWiki-commits] [Gerrit] Moved openDialog to a separate function - change (mediawiki...LanguageTool)
Amire80 has submitted this change and it was merged.
Change subject: Moved openDialog to a separate function
..
Moved openDialog to a separate function
Change-Id: I383fa72db549457dbec636e0640de2301ea177ec
---
M modules/ext.LanguageToolAction.js
1 file changed, 23 insertions(+), 10 deletions(-)
Approvals:
Amire80: Verified; Looks good to me, approved
diff --git a/modules/ext.LanguageToolAction.js
b/modules/ext.LanguageToolAction.js
index bcd2eab..4c55531 100644
--- a/modules/ext.LanguageToolAction.js
+++ b/modules/ext.LanguageToolAction.js
@@ -77,34 +77,47 @@
var node = textNodes[nodeI];
var nodeRange = node.getRange();
var nodeText =
model.getLinearFragment(nodeRange).getText();
- text += nodeText;
+ text = text + \n + nodeText;
}
var lang = mw.config.get( 'wgPageContentLanguage' );
var params = language= + lang + text= + text;
$.ajax(
{
type: 'POST',
- dataType: 'text',
+ //dataType: 'xml',
url: 'http://tools.wmflabs.org/languageproofing/',
data: {language: lang, text: text}
}
)
- .done(function(d)
- {
- // Example: Creating and opening a message dialog
window.
- var messageDialog = new OO.ui.MessageDialog();
+ .done( this.openDialog );
+ return;
+ }
+mw.languageToolAction.prototype.openDialog = function ( responseXML ) {
+ var messageDialog = new OO.ui.MessageDialog();
// Create and append a window manager.
var windowManager = new OO.ui.WindowManager();
$( 'body' ).append( windowManager.$element );
windowManager.addWindows( [ messageDialog ] );
+
+ var errors = responseXML.getElementsByTagName( error
);
+ console.log(errors);
+ var i;
+ var response = ;
+ for ( i = 0; i errors.length; i++ ) {
+ response = response + ERROR + i + :\n;
+ response = response + error : +
errors[i].getAttribute( 'msg' ) + \n;
+ response = response + context : +
errors[i].getAttribute( 'context' ) + \n;
+ messageDialog.setData( 'error',
errors[i].getAttribute( 'msg' ) );
+ messageDialog.setData( 'context',
errors[i].getAttribute( 'context' ));
+ }
+ console.log(response);
+ // Example: Creating and opening a message dialog
window.
// Open the window.
windowManager.openWindow( messageDialog, {
title: 'LanguageTool Response',
- message: d
+ message: response
} );
- });
- return;
- }
+}
/* Registration */
--
To view, visit https://gerrit.wikimedia.org/r/222109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I383fa72db549457dbec636e0640de2301ea177ec
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks kumariankita...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moved openDialog to a separate function - change (mediawiki...LanguageTool)
Ankita-ks has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222109
Change subject: Moved openDialog to a separate function
..
Moved openDialog to a separate function
Change-Id: I383fa72db549457dbec636e0640de2301ea177ec
---
M modules/ext.LanguageToolAction.js
1 file changed, 24 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LanguageTool
refs/changes/09/222109/1
diff --git a/modules/ext.LanguageToolAction.js
b/modules/ext.LanguageToolAction.js
index 14e09e0..7f75a1a 100644
--- a/modules/ext.LanguageToolAction.js
+++ b/modules/ext.LanguageToolAction.js
@@ -77,34 +77,48 @@
var node = textNodes[nodeI];
var nodeRange = node.getRange();
var nodeText =
model.getLinearFragment(nodeRange).getText();
- text += nodeText;
+ text = text + \n + nodeText;
}
var lang = mw.config.get( 'wgPageContentLanguage' );
var params = language= + lang + text= + text;
$.ajax(
{
type: 'POST',
- dataType: 'text',
+ //dataType: 'xml',
url: 'http://127.0.0.1:8081/',
data: {language: lang, text: text}
}
)
- .done(function(d)
- {
- // Example: Creating and opening a message dialog
window.
- var messageDialog = new OO.ui.MessageDialog();
+ .done( this.openDialog );
+ return;
+ }
+mw.languageToolAction.prototype.openDialog = function ( responseXML ) {
+ var messageDialog = new OO.ui.MessageDialog();
// Create and append a window manager.
var windowManager = new OO.ui.WindowManager();
$( 'body' ).append( windowManager.$element );
windowManager.addWindows( [ messageDialog ] );
+
+ var errors = responseXML.getElementsByTagName( error
);
+ console.log(errors);
+ var i;
+ var response = ;
+ for ( i = 0; i errors.length; i++ ) {
+ response = response + ERROR + i + :\n;
+ response = response + error : +
errors[i].getAttribute( 'msg' ) + \n;
+ response = response + context : +
errors[i].getAttribute( 'context' ) + \n;
+ messageDialog.setData( 'error',
errors[i].getAttribute( 'msg' ) );
+ messageDialog.setData( 'context',
errors[i].getAttribute( 'context' ));
+ }
+ console.log(response);
+ // Example: Creating and opening a message dialog
window.
// Open the window.
windowManager.openWindow( messageDialog, {
title: 'LanguageTool Response',
- message: d
+ message: response
} );
- });
- return;
- }
+}
+
/* Registration */
--
To view, visit https://gerrit.wikimedia.org/r/222109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I383fa72db549457dbec636e0640de2301ea177ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks kumariankita...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
