[MediaWiki-commits] [Gerrit] Omit 'external' changes from ChangesFeed - change (mediawiki/core)

2015-06-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Omit 'external' changes from ChangesFeed
..


Omit 'external' changes from ChangesFeed

The current formatting does not display these
external changes very well (e.g. doesn't distinguish
between local and foreign wiki user or whatnot).

Unless there is better handling or integration of these,
also with the option of hiding or showing, it is best
to simply exclude these from the feed.

This brings the ChangesFeed inline with default
behavior of Special:RecentChanges and Watchlist.

Bug: T88254
Change-Id: I956a3c392e9f163478b9f6994bde4c0be8932163
---
M includes/changes/ChangesFeed.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/changes/ChangesFeed.php b/includes/changes/ChangesFeed.php
index 28c2f7e..28a1cca 100644
--- a/includes/changes/ChangesFeed.php
+++ b/includes/changes/ChangesFeed.php
@@ -187,6 +187,10 @@
$sorted = array();
$n = 0;
foreach ( $rows as $obj ) {
+   if ( $obj-rc_type == RC_EXTERNAL ) {
+   continue;
+   }
+
if ( $n  0 
$obj-rc_type == RC_EDIT 
$obj-rc_namespace = 0 

-- 
To view, visit https://gerrit.wikimedia.org/r/188113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I956a3c392e9f163478b9f6994bde4c0be8932163
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Omit 'external' changes from ChangesFeed - change (mediawiki/core)

2015-02-02 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/188113

Change subject: Omit 'external' changes from ChangesFeed
..

Omit 'external' changes from ChangesFeed

The current formatting does not display these
external changes very well (e.g. doesn't distinguish
between local and foreign wiki user or whatnot).

Unless there is better handling or integration of these,
also with the option of hiding or showing, it is best
to simply exclude these from the feed.

This brings the ChangesFeed inline with default
behavior of Special:RecentChanges and Watchlist.

Change-Id: I956a3c392e9f163478b9f6994bde4c0be8932163
---
M includes/changes/ChangesFeed.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/188113/1

diff --git a/includes/changes/ChangesFeed.php b/includes/changes/ChangesFeed.php
index 28c2f7e..28a1cca 100644
--- a/includes/changes/ChangesFeed.php
+++ b/includes/changes/ChangesFeed.php
@@ -187,6 +187,10 @@
$sorted = array();
$n = 0;
foreach ( $rows as $obj ) {
+   if ( $obj-rc_type == RC_EXTERNAL ) {
+   continue;
+   }
+
if ( $n  0 
$obj-rc_type == RC_EDIT 
$obj-rc_namespace = 0 

-- 
To view, visit https://gerrit.wikimedia.org/r/188113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I956a3c392e9f163478b9f6994bde4c0be8932163
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits