[MediaWiki-commits] [Gerrit] Omit thread_pool_add_delay on Varnish 4 - change (operations/puppet)

[Ema (Code Review)]

Ema has submitted this change and it was merged.

Change subject: Omit thread_pool_add_delay on Varnish 4
..


Omit thread_pool_add_delay on Varnish 4

With Varnish 4 running on modern software/hardware it might not be
necessary to wait after creating a thread.

As we deploy experimental hosts with real traffic we will check
threads_failed and set thread_pool_add_delay (in floating-point
seconds!) only if necessary.

Bug: T126206
Change-Id: I0332374ed44d42a9b2aa0e5957515c826793779d
---
M modules/varnish/templates/initscripts/varnish.systemd.erb
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ema: Verified; Looks good to me, approved
  BBlack: Looks good to me, but someone else must approve



diff --git a/modules/varnish/templates/initscripts/varnish.systemd.erb 
b/modules/varnish/templates/initscripts/varnish.systemd.erb
index 6d3f020..a16418a 100644
--- a/modules/varnish/templates/initscripts/varnish.systemd.erb
+++ b/modules/varnish/templates/initscripts/varnish.systemd.erb
@@ -24,10 +24,11 @@
 -p shm_reclen=2048 \
 -p user=varnish \
 -p shm_workspace=16384 \
+-p thread_pool_add_delay=1 \
 <% end -%>
 -S /etc/varnish/secret \
 <%= @storage -%> \
--p thread_pool_add_delay=1 -p thread_pool_stack=131072 \
+-p thread_pool_stack=131072 \
 -p listen_depth=4096 -p session_max=20 -p vcc_err_unref=off \
 -p nuke_limit=300 \
 -p http_req_size=24576 \

-- 
To view, visit https://gerrit.wikimedia.org/r/269686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0332374ed44d42a9b2aa0e5957515c826793779d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Ema 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Omit thread_pool_add_delay on Varnish 4 - change (operations/puppet)

[Ema (Code Review)]

Ema has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/269686

Change subject: Omit thread_pool_add_delay on Varnish 4
..

Omit thread_pool_add_delay on Varnish 4

With Varnish 4 running on modern software/hardware it might not be
necessary to wait after creating a thread.

As we deploy experimental hosts with real traffic we will check
threads_failed and set thread_pool_add_delay (in floating-point
seconds!) only if necessary.

Bug: T126206
Change-Id: I0332374ed44d42a9b2aa0e5957515c826793779d
---
M modules/varnish/templates/initscripts/varnish.systemd.erb
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/86/269686/1

diff --git a/modules/varnish/templates/initscripts/varnish.systemd.erb 
b/modules/varnish/templates/initscripts/varnish.systemd.erb
index 6d3f020..a16418a 100644
--- a/modules/varnish/templates/initscripts/varnish.systemd.erb
+++ b/modules/varnish/templates/initscripts/varnish.systemd.erb
@@ -24,10 +24,11 @@
 -p shm_reclen=2048 \
 -p user=varnish \
 -p shm_workspace=16384 \
+-p thread_pool_add_delay=1 \
 <% end -%>
 -S /etc/varnish/secret \
 <%= @storage -%> \
--p thread_pool_add_delay=1 -p thread_pool_stack=131072 \
+-p thread_pool_stack=131072 \
 -p listen_depth=4096 -p session_max=20 -p vcc_err_unref=off \
 -p nuke_limit=300 \
 -p http_req_size=24576 \

-- 
To view, visit https://gerrit.wikimedia.org/r/269686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0332374ed44d42a9b2aa0e5957515c826793779d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits