[MediaWiki-commits] [Gerrit] Open links in the "tutorial" in the new window - change (mediawiki...RevisionSlider)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Open links in the "tutorial" in the new window
..


Open links in the "tutorial" in the new window

In particular, link to a Meta page on the related community wish
should open in the new window/tab.

Bug: T140875
Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
(cherry picked from commit 8d91433b6177e78824256a6cd8a8b39dd6030ce7)
---
M modules/ext.RevisionSlider.HelpDialog.js
M tests/qunit/RevisionSlider.HelpDialog.test.js
2 files changed, 24 insertions(+), 4 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.RevisionSlider.HelpDialog.js 
b/modules/ext.RevisionSlider.HelpDialog.js
index ee23b4a..1ef6fc0 100644
--- a/modules/ext.RevisionSlider.HelpDialog.js
+++ b/modules/ext.RevisionSlider.HelpDialog.js
@@ -66,6 +66,8 @@
.html( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
);
 
+   slide.$element.find( 'a' ).attr( 'target', '_blank' );
+
return slide;
},
 
diff --git a/tests/qunit/RevisionSlider.HelpDialog.test.js 
b/tests/qunit/RevisionSlider.HelpDialog.test.js
index ee7666d..e7b5ef5 100644
--- a/tests/qunit/RevisionSlider.HelpDialog.test.js
+++ b/tests/qunit/RevisionSlider.HelpDialog.test.js
@@ -11,15 +11,33 @@
return slide.$element.find( 
'.mw-revslider-help-dialog-text' ).html();
}
 
+   function addLinkTargets( parsedMessage ) {
+   var $container = $( '' ).html( parsedMessage );
+   $container.find( 'a' ).attr( 'target', '_blank' );
+   return $container.html();
+   }
+
$( 'body' ).append( windowManager.$element );
windowManager.addWindows( [ helpDialog ] );
 
assert.equal( helpDialog.slides.length, 4 );
assert.equal( helpDialog.slidePointer, 0 );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 0 ] ), 
mw.message( 'revisionslider-help-dialog-slide1' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 1 ] ), 
mw.message( 'revisionslider-help-dialog-slide2' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 2 ] ), 
mw.message( 'revisionslider-help-dialog-slide3' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 3 ] ), 
mw.message( 'revisionslider-help-dialog-slide4' ).parse() );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 0 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 1 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide2' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 2 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide3' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 3 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide4' ).parse() )
+   );
} );
 
 } )( mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/299974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: wmf/1.28.0-wmf.11
Gerrit-Owner: Addshore 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Open links in the "tutorial" in the new window - change (mediawiki...RevisionSlider)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/299974

Change subject: Open links in the "tutorial" in the new window
..

Open links in the "tutorial" in the new window

In particular, link to a Meta page on the related community wish
should open in the new window/tab.

Bug: T140875
Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
(cherry picked from commit 8d91433b6177e78824256a6cd8a8b39dd6030ce7)
---
M modules/ext.RevisionSlider.HelpDialog.js
M tests/qunit/RevisionSlider.HelpDialog.test.js
2 files changed, 24 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/74/299974/1

diff --git a/modules/ext.RevisionSlider.HelpDialog.js 
b/modules/ext.RevisionSlider.HelpDialog.js
index ee23b4a..1ef6fc0 100644
--- a/modules/ext.RevisionSlider.HelpDialog.js
+++ b/modules/ext.RevisionSlider.HelpDialog.js
@@ -66,6 +66,8 @@
.html( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
);
 
+   slide.$element.find( 'a' ).attr( 'target', '_blank' );
+
return slide;
},
 
diff --git a/tests/qunit/RevisionSlider.HelpDialog.test.js 
b/tests/qunit/RevisionSlider.HelpDialog.test.js
index ee7666d..e7b5ef5 100644
--- a/tests/qunit/RevisionSlider.HelpDialog.test.js
+++ b/tests/qunit/RevisionSlider.HelpDialog.test.js
@@ -11,15 +11,33 @@
return slide.$element.find( 
'.mw-revslider-help-dialog-text' ).html();
}
 
+   function addLinkTargets( parsedMessage ) {
+   var $container = $( '' ).html( parsedMessage );
+   $container.find( 'a' ).attr( 'target', '_blank' );
+   return $container.html();
+   }
+
$( 'body' ).append( windowManager.$element );
windowManager.addWindows( [ helpDialog ] );
 
assert.equal( helpDialog.slides.length, 4 );
assert.equal( helpDialog.slidePointer, 0 );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 0 ] ), 
mw.message( 'revisionslider-help-dialog-slide1' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 1 ] ), 
mw.message( 'revisionslider-help-dialog-slide2' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 2 ] ), 
mw.message( 'revisionslider-help-dialog-slide3' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 3 ] ), 
mw.message( 'revisionslider-help-dialog-slide4' ).parse() );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 0 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 1 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide2' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 2 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide3' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 3 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide4' ).parse() )
+   );
} );
 
 } )( mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/299974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: wmf/1.28.0-wmf.11
Gerrit-Owner: Addshore 
Gerrit-Reviewer: WMDE-leszek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Open links in the "tutorial" in the new window - change (mediawiki...RevisionSlider)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Open links in the "tutorial" in the new window
..


Open links in the "tutorial" in the new window

In particular, link to a Meta page on the related community wish
should open in the new window/tab.

Bug: T140875
Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
---
M modules/ext.RevisionSlider.HelpDialog.js
M tests/qunit/RevisionSlider.HelpDialog.test.js
2 files changed, 24 insertions(+), 4 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.RevisionSlider.HelpDialog.js 
b/modules/ext.RevisionSlider.HelpDialog.js
index ee23b4a..1ef6fc0 100644
--- a/modules/ext.RevisionSlider.HelpDialog.js
+++ b/modules/ext.RevisionSlider.HelpDialog.js
@@ -66,6 +66,8 @@
.html( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
);
 
+   slide.$element.find( 'a' ).attr( 'target', '_blank' );
+
return slide;
},
 
diff --git a/tests/qunit/RevisionSlider.HelpDialog.test.js 
b/tests/qunit/RevisionSlider.HelpDialog.test.js
index ee7666d..e7b5ef5 100644
--- a/tests/qunit/RevisionSlider.HelpDialog.test.js
+++ b/tests/qunit/RevisionSlider.HelpDialog.test.js
@@ -11,15 +11,33 @@
return slide.$element.find( 
'.mw-revslider-help-dialog-text' ).html();
}
 
+   function addLinkTargets( parsedMessage ) {
+   var $container = $( '' ).html( parsedMessage );
+   $container.find( 'a' ).attr( 'target', '_blank' );
+   return $container.html();
+   }
+
$( 'body' ).append( windowManager.$element );
windowManager.addWindows( [ helpDialog ] );
 
assert.equal( helpDialog.slides.length, 4 );
assert.equal( helpDialog.slidePointer, 0 );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 0 ] ), 
mw.message( 'revisionslider-help-dialog-slide1' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 1 ] ), 
mw.message( 'revisionslider-help-dialog-slide2' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 2 ] ), 
mw.message( 'revisionslider-help-dialog-slide3' ).parse() );
-   assert.equal( getSlideTextHtml( helpDialog.slides[ 3 ] ), 
mw.message( 'revisionslider-help-dialog-slide4' ).parse() );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 0 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 1 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide2' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 2 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide3' ).parse() )
+   );
+   assert.equal(
+   getSlideTextHtml( helpDialog.slides[ 3 ] ),
+   addLinkTargets( mw.message( 
'revisionslider-help-dialog-slide4' ).parse() )
+   );
} );
 
 } )( mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/299962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Open links in the "tutorial" in the new window - change (mediawiki...RevisionSlider)

[WMDE-leszek (Code Review)]

WMDE-leszek has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/299962

Change subject: Open links in the "tutorial" in the new window
..

Open links in the "tutorial" in the new window

In particular, link to a Meta page on the related community wish
should open in the new window/tab.

Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
---
M modules/ext.RevisionSlider.HelpDialog.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/62/299962/1

diff --git a/modules/ext.RevisionSlider.HelpDialog.js 
b/modules/ext.RevisionSlider.HelpDialog.js
index ee23b4a..1ef6fc0 100644
--- a/modules/ext.RevisionSlider.HelpDialog.js
+++ b/modules/ext.RevisionSlider.HelpDialog.js
@@ -66,6 +66,8 @@
.html( mw.message( 
'revisionslider-help-dialog-slide1' ).parse() )
);
 
+   slide.$element.find( 'a' ).attr( 'target', '_blank' );
+
return slide;
},
 

-- 
To view, visit https://gerrit.wikimedia.org/r/299962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0d7bf679c9ac8a3ee2fdf2289fc53cfdfdaa671
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits