[MediaWiki-commits] [Gerrit] PHP ButtonElement: Fix toggleFramed() to actually be chainable - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: PHP ButtonElement: Fix toggleFramed() to actually be chainable
..


PHP ButtonElement: Fix toggleFramed() to actually be chainable

Change-Id: Iedb970a8ea84173e2f8865880f666a1b9d1d87d3
---
M php/mixins/ButtonElement.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index 875144f..671ebb5 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -61,6 +61,7 @@
$this->framed = $framed !== null ? !!$framed : !$this->framed;
$this->toggleClasses( [ 'oo-ui-buttonElement-framed' ], 
$this->framed );
$this->toggleClasses( [ 'oo-ui-buttonElement-frameless' ], 
!$this->framed );
+   return $this;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/284523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedb970a8ea84173e2f8865880f666a1b9d1d87d3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] PHP ButtonElement: Fix toggleFramed() to actually be chainable - change (oojs/ui)

[Code Review]

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284523

Change subject: PHP ButtonElement: Fix toggleFramed() to actually be chainable
..

PHP ButtonElement: Fix toggleFramed() to actually be chainable

Change-Id: Iedb970a8ea84173e2f8865880f666a1b9d1d87d3
---
M php/mixins/ButtonElement.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/23/284523/1

diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index 875144f..671ebb5 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -61,6 +61,7 @@
$this->framed = $framed !== null ? !!$framed : !$this->framed;
$this->toggleClasses( [ 'oo-ui-buttonElement-framed' ], 
$this->framed );
$this->toggleClasses( [ 'oo-ui-buttonElement-frameless' ], 
!$this->framed );
+   return $this;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/284523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedb970a8ea84173e2f8865880f666a1b9d1d87d3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits