[MediaWiki-commits] [Gerrit] Phragile: Ensure clone before creating storage dir - change (operations/puppet)

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged.

Change subject: Phragile: Ensure clone before creating storage dir
..


Phragile: Ensure clone before creating storage dir

Unless explicitly told Puppet could create a storage directory (a subdir
of the directory where Phragile repository is cloned to) before git clone
has been called. In that case git clone fails due to directory being
non-empty.

Change-Id: I35a114b02fd8330144a62685be9f626b484dec5e
---
M modules/phragile/manifests/init.pp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  WMDE-Fisch: Looks good to me, but someone else must approve
  Jakob: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/phragile/manifests/init.pp 
b/modules/phragile/manifests/init.pp
index b78f791..1114007 100644
--- a/modules/phragile/manifests/init.pp
+++ b/modules/phragile/manifests/init.pp
@@ -117,6 +117,7 @@
 group   => 'www-data',
 mode=> '0775',
 recurse => true,
+require => Git::Clone['phragile'],
 }
 
 exec { '/usr/bin/php artisan migrate':

-- 
To view, visit https://gerrit.wikimedia.org/r/264745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35a114b02fd8330144a62685be9f626b484dec5e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: WMDE-leszek 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Jakob 
Gerrit-Reviewer: JanZerebecki 
Gerrit-Reviewer: Rush 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Phragile: Ensure clone before creating storage dir - change (operations/puppet)

[WMDE-leszek (Code Review)]

WMDE-leszek has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/264745

Change subject: Phragile: Ensure clone before creating storage dir
..

Phragile: Ensure clone before creating storage dir

Unless explicitly told Puppet could create a storage directory (a subdir
of the directory where Phragile repository is cloned to) before git clone
has been called. In that case git clone fails due to directory being
non-empty.

Change-Id: I35a114b02fd8330144a62685be9f626b484dec5e
---
M modules/phragile/manifests/init.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/45/264745/1

diff --git a/modules/phragile/manifests/init.pp 
b/modules/phragile/manifests/init.pp
index b78f791..1114007 100644
--- a/modules/phragile/manifests/init.pp
+++ b/modules/phragile/manifests/init.pp
@@ -117,6 +117,7 @@
 group   => 'www-data',
 mode=> '0775',
 recurse => true,
+require => Git::Clone['phragile'],
 }
 
 exec { '/usr/bin/php artisan migrate':

-- 
To view, visit https://gerrit.wikimedia.org/r/264745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35a114b02fd8330144a62685be9f626b484dec5e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: WMDE-leszek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits