[MediaWiki-commits] [Gerrit] Portable DIRECTORY_SEPARATOR :) - change (mediawiki...Scribunto)

2013-03-14 Thread Jens Ohlig (Code Review) 
Jens Ohlig has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/53754


Change subject: Portable DIRECTORY_SEPARATOR :)
..

Portable DIRECTORY_SEPARATOR :)

Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
---
M engines/LuaCommon/LuaCommon.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/54/53754/1

diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index cbf15d2..10f126c 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -135,7 +135,7 @@
 * @return string
 */
protected function normalizeModuleFileName( $fileName ) {
-   return $fileName[0] !== '/' ? 
{$this-getLuaLibDir()}/{$fileName} : $fileName;
+   return $fileName[0] !== DIRECTORY_SEPARATOR ? 
{$this-getLuaLibDir()}/{$fileName} : $fileName;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/53754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Portable DIRECTORY_SEPARATOR :) - change (mediawiki...Scribunto)

2013-03-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Portable DIRECTORY_SEPARATOR :)
..


Portable DIRECTORY_SEPARATOR :)

Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
---
M engines/LuaCommon/LuaCommon.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Demon: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index cbf15d2..10f126c 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -135,7 +135,7 @@
 * @return string
 */
protected function normalizeModuleFileName( $fileName ) {
-   return $fileName[0] !== '/' ? 
{$this-getLuaLibDir()}/{$fileName} : $fileName;
+   return $fileName[0] !== DIRECTORY_SEPARATOR ? 
{$this-getLuaLibDir()}/{$fileName} : $fileName;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/53754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Anomie bjor...@wikimedia.org
Gerrit-Reviewer: Demon ch...@wikimedia.org
Gerrit-Reviewer: Tim Starling tstarl...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits