[MediaWiki-commits] [Gerrit] Post content with more than 5 lines is showing a scrollbar - change (mediawiki...Flow)
jenkins-bot has submitted this change and it was merged. Change subject: Post content with more than 5 lines is showing a scrollbar .. Post content with more than 5 lines is showing a scrollbar It turns out this is caused by the tipsy link, somehow the icon is creating an overflow even the height/width are the same as icon height/width. Adding overflow: hidden seems to fixe the problem. Not sure if this is a good fix but this does address the issue, :) Change-Id: Iae275a3d1c18e7b9693811e20cf3e742a48f23be --- M modules/discussion/styles/modified.less 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Werdna: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/discussion/styles/modified.less b/modules/discussion/styles/modified.less index 1bfc037..0df43dd 100644 --- a/modules/discussion/styles/modified.less +++ b/modules/discussion/styles/modified.less @@ -7,6 +7,8 @@ display: inline-block; text-indent: -px; vertical-align: middle; + /* Stops tipsy from causing a scroll bar */ + overflow: hidden; background-position: center; background-size: 14px auto; -- To view, visit https://gerrit.wikimedia.org/r/104758 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae275a3d1c18e7b9693811e20cf3e742a48f23be Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Bsitu bs...@wikimedia.org Gerrit-Reviewer: Spage sp...@wikimedia.org Gerrit-Reviewer: Werdna agarr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Post content with more than 5 lines is showing a scrollbar - change (mediawiki...Flow)
Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/104758 Change subject: Post content with more than 5 lines is showing a scrollbar .. Post content with more than 5 lines is showing a scrollbar It turns out this is caused by the tipsy link, somehow the icon is creating an overflow even the height/width are the same as icon height/width. Adding overflow: hidden seems to fixe the problem. Not sure if this is a good fix but this does address the issue, :) Change-Id: Iae275a3d1c18e7b9693811e20cf3e742a48f23be --- M modules/discussion/styles/modified.less 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/58/104758/1 diff --git a/modules/discussion/styles/modified.less b/modules/discussion/styles/modified.less index 1bfc037..454ecb1 100644 --- a/modules/discussion/styles/modified.less +++ b/modules/discussion/styles/modified.less @@ -7,6 +7,7 @@ display: inline-block; text-indent: -px; vertical-align: middle; + overflow: hidden; background-position: center; background-size: 14px auto; -- To view, visit https://gerrit.wikimedia.org/r/104758 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae275a3d1c18e7b9693811e20cf3e742a48f23be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Bsitu bs...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
