[MediaWiki-commits] [Gerrit] Preemptively add image-set to our sanitizer. - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: Preemptively add image-set to our sanitizer. .. Preemptively add image-set to our sanitizer. WebKit's -webkit-image-set() requires a url() to work however css4-images' version of image-set permits strings such that image-set( 'asdf.png' 1x ) would be permitted and would bypass our filters. Change-Id: I366d04807f66df449f791a5e8e2cb58768124a9a --- M includes/Sanitizer.php M tests/phpunit/includes/SanitizerTest.php 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/28668 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366d04807f66df449f791a5e8e2cb58768124a9a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Friesen Gerrit-Reviewer: CSteipp Gerrit-Reviewer: Hashar Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Platonides Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Preemptively add image-set to our sanitizer. - change (mediawiki/core[master])
Daniel Friesen has uploaded a new change for review. Change subject: Preemptively add image-set to our sanitizer. .. Preemptively add image-set to our sanitizer. WebKit's -webkit-image-set() requires a url() to work however css4-images' version of image-set permits strings such that image-set( 'asdf.png' 1x ) would be permitted and would bypass our filters. Change-Id: I366d04807f66df449f791a5e8e2cb58768124a9a --- M includes/Sanitizer.php M tests/phpunit/includes/SanitizerTest.php 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/68/28668/1 -- To view, visit https://gerrit.wikimedia.org/r/28668 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I366d04807f66df449f791a5e8e2cb58768124a9a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Friesen ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
