[MediaWiki-commits] [Gerrit] Prevent PHP timeout when importing large files - change (wikimedia...crm)

2015-11-18 Thread Awight (Code Review) 
Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/253975

Change subject: Prevent PHP timeout when importing large files
..

Prevent PHP timeout when importing large files

Bug: T118981
Change-Id: Iaa6abb2769ef96b478def29398e5c6a46073552d
---
M sites/all/modules/offline2civicrm/ChecksFile.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/75/253975/1

diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php 
b/sites/all/modules/offline2civicrm/ChecksFile.php
index 0dadaf3..c8b098f 100644
--- a/sites/all/modules/offline2civicrm/ChecksFile.php
+++ b/sites/all/modules/offline2civicrm/ChecksFile.php
@@ -51,6 +51,9 @@
 $this->row_index = -1 + $this->numSkippedRows;
 
 while( ( $row = fgetcsv( $file, 0, ',', '"', '\\')) !== FALSE) {
+// Reset the PHP timeout for each row.
+set_time_limit( 10 );
+
 $this->row_index++;
 
 // Zip headers and row into a dict

-- 
To view, visit https://gerrit.wikimedia.org/r/253975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa6abb2769ef96b478def29398e5c6a46073552d
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Awight 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Prevent PHP timeout when importing large files - change (wikimedia...crm)

2015-11-18 Thread XenoRyet (Code Review) 
XenoRyet has submitted this change and it was merged.

Change subject: Prevent PHP timeout when importing large files
..


Prevent PHP timeout when importing large files

Bug: T118981
Change-Id: Iaa6abb2769ef96b478def29398e5c6a46073552d
---
M sites/all/modules/offline2civicrm/ChecksFile.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php 
b/sites/all/modules/offline2civicrm/ChecksFile.php
index 0dadaf3..c8b098f 100644
--- a/sites/all/modules/offline2civicrm/ChecksFile.php
+++ b/sites/all/modules/offline2civicrm/ChecksFile.php
@@ -51,6 +51,9 @@
 $this->row_index = -1 + $this->numSkippedRows;
 
 while( ( $row = fgetcsv( $file, 0, ',', '"', '\\')) !== FALSE) {
+// Reset the PHP timeout for each row.
+set_time_limit( 10 );
+
 $this->row_index++;
 
 // Zip headers and row into a dict

-- 
To view, visit https://gerrit.wikimedia.org/r/253975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa6abb2769ef96b478def29398e5c6a46073552d
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Awight 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Eileen 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Katie Horn 
Gerrit-Reviewer: Pcoombe 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits