[MediaWiki-commits] [Gerrit] Prevent app from using css if 200 response but error message... - change (apps...wikipedia)
Mhurd has uploaded a new change for review. https://gerrit.wikimedia.org/r/165928 Change subject: Prevent app from using css if 200 response but error message found. .. Prevent app from using css if 200 response but error message found. Change-Id: I58462c3a20f96df4411f444e049a441c92007aec --- M wikipedia/Data/Operations/SyncAssetsFileOp.m 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia refs/changes/28/165928/1 diff --git a/wikipedia/Data/Operations/SyncAssetsFileOp.m b/wikipedia/Data/Operations/SyncAssetsFileOp.m index d8c89ad..c6f08c5 100644 --- a/wikipedia/Data/Operations/SyncAssetsFileOp.m +++ b/wikipedia/Data/Operations/SyncAssetsFileOp.m @@ -47,6 +47,9 @@ NSString *jsonString = [[NSString alloc] initWithData:weakSelf.dataRetrieved encoding:NSUTF8StringEncoding]; //NSLog(@"jsonString = %@", jsonString); if (!jsonString || (jsonString.length == 0)) return; + +if ([jsonString hasPrefix:@"/*\nInternal error\n*"]) return; + NSString *filePath = assetsFile.path; NSError *error = nil; [jsonString writeToFile:filePath atomically:YES encoding:NSUTF8StringEncoding error:&error]; -- To view, visit https://gerrit.wikimedia.org/r/165928 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I58462c3a20f96df4411f444e049a441c92007aec Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Prevent app from using css if 200 response but error message... - change (apps...wikipedia)
Brion VIBBER has submitted this change and it was merged. Change subject: Prevent app from using css if 200 response but error message found. .. Prevent app from using css if 200 response but error message found. Change-Id: I58462c3a20f96df4411f444e049a441c92007aec --- M wikipedia/Data/Operations/SyncAssetsFileOp.m 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved diff --git a/wikipedia/Data/Operations/SyncAssetsFileOp.m b/wikipedia/Data/Operations/SyncAssetsFileOp.m index d8c89ad..c6f08c5 100644 --- a/wikipedia/Data/Operations/SyncAssetsFileOp.m +++ b/wikipedia/Data/Operations/SyncAssetsFileOp.m @@ -47,6 +47,9 @@ NSString *jsonString = [[NSString alloc] initWithData:weakSelf.dataRetrieved encoding:NSUTF8StringEncoding]; //NSLog(@"jsonString = %@", jsonString); if (!jsonString || (jsonString.length == 0)) return; + +if ([jsonString hasPrefix:@"/*\nInternal error\n*"]) return; + NSString *filePath = assetsFile.path; NSError *error = nil; [jsonString writeToFile:filePath atomically:YES encoding:NSUTF8StringEncoding error:&error]; -- To view, visit https://gerrit.wikimedia.org/r/165928 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58462c3a20f96df4411f444e049a441c92007aec Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
