[MediaWiki-commits] [Gerrit] Puppetize icinga log file permission fix. - change (operations/puppet)

2014-09-16 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged.

Change subject: Puppetize icinga log file permission fix.
..


Puppetize icinga log file permission fix.

Without this after applying icinga::monitor incinga ends up not being able to
write to its own log file because it is still owned by the user nagios instead
of icinga. Also echoirc needs to be able to read the irc log files in icingas
log directory.

Change-Id: I33f4f52f94aae0f124671d23144fcd79353c6150
---
M manifests/misc/icinga.pp
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/misc/icinga.pp b/manifests/misc/icinga.pp
index 0427472..d9c3611 100644
--- a/manifests/misc/icinga.pp
+++ b/manifests/misc/icinga.pp
@@ -303,6 +303,19 @@
 exec { 'fix_icinga_command_file':
 command => '/bin/chmod a+rw /var/lib/nagios/rw/nagios.cmd';
 }
+file { '/var/log/icinga':
+ensure => directory,
+owner => 'icinga',
+mode => '2755',
+}
+file { '/var/log/icinga/archives':
+ensure => directory,
+owner => 'icinga',
+}
+file { '/var/log/icinga/icinga.log':
+ensure => file,
+owner => 'icinga',
+}
 }
 
 class icinga::monitor::files::nagios-plugins {

-- 
To view, visit https://gerrit.wikimedia.org/r/158633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33f4f52f94aae0f124671d23144fcd79353c6150
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: JanZerebecki 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: JanZerebecki 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Puppetize icinga log file permission fix. - change (operations/puppet)

2014-09-05 Thread JanZerebecki (Code Review) 
JanZerebecki has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/158633

Change subject: Puppetize icinga log file permission fix.
..

Puppetize icinga log file permission fix.

Change-Id: I33f4f52f94aae0f124671d23144fcd79353c6150
---
M manifests/misc/icinga.pp
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/33/158633/1

diff --git a/manifests/misc/icinga.pp b/manifests/misc/icinga.pp
index c7914a2..ebef75d 100644
--- a/manifests/misc/icinga.pp
+++ b/manifests/misc/icinga.pp
@@ -303,6 +303,19 @@
 exec { 'fix_icinga_command_file':
 command => '/bin/chmod a+rw /var/lib/nagios/rw/nagios.cmd';
 }
+file { '/var/log/icinga':
+ensure => directory,
+owner => 'icinga',
+mode => '0755',
+}
+file { '/var/log/icinga/archives':
+ensure => directory,
+owner => 'icinga',
+}
+file { '/var/log/icinga/icinga.log':
+ensure => file,
+owner => 'icinga',
+}
 }
 
 class icinga::monitor::files::nagios-plugins {

-- 
To view, visit https://gerrit.wikimedia.org/r/158633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f4f52f94aae0f124671d23144fcd79353c6150
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: JanZerebecki 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Puppetize icinga log file permission fix. - change (operations/puppet)

2014-09-04 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged.

Change subject: Puppetize icinga log file permission fix.
..


Puppetize icinga log file permission fix.

Change-Id: I3128485d42f68df34d4fee2112e6a4c0af0549ff
---
M manifests/misc/icinga.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/misc/icinga.pp b/manifests/misc/icinga.pp
index c7914a2..2057ea2 100644
--- a/manifests/misc/icinga.pp
+++ b/manifests/misc/icinga.pp
@@ -297,6 +297,9 @@
 exec { 'fix_icinga_temp_files':
 command => '/bin/chown -R icinga /var/lib/icinga';
 }
+exec { 'fix_icinga_log_files':
+command => '/bin/chown -R icinga /var/log/icinga';
+}
 exec { 'fix_nagios_plugins_files':
 command => '/bin/chmod -R a+w /var/lib/nagios';
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/158345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3128485d42f68df34d4fee2112e6a4c0af0549ff
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: JanZerebecki 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Puppetize icinga log file permission fix. - change (operations/puppet)

2014-09-04 Thread JanZerebecki (Code Review) 
JanZerebecki has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/158345

Change subject: Puppetize icinga log file permission fix.
..

Puppetize icinga log file permission fix.

Change-Id: I3128485d42f68df34d4fee2112e6a4c0af0549ff
---
M manifests/misc/icinga.pp
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/45/158345/1

diff --git a/manifests/misc/icinga.pp b/manifests/misc/icinga.pp
index 06dc6e2..e631831 100644
--- a/manifests/misc/icinga.pp
+++ b/manifests/misc/icinga.pp
@@ -297,6 +297,9 @@
 exec { 'fix_icinga_temp_files':
 command => '/bin/chown -R icinga /var/lib/icinga';
 }
+exec { 'fix_icinga_log_files':
+command => '/bin/chown -R icinga /var/log/icinga';
+}
 exec { 'fix_nagios_plugins_files':
 command => '/bin/chmod -R a+w /var/lib/nagios';
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/158345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3128485d42f68df34d4fee2112e6a4c0af0549ff
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: JanZerebecki 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits