[MediaWiki-commits] [Gerrit] QA: Fix broken browser tests - change (mediawiki...MobileFrontend)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/134805 Change subject: QA: Fix broken browser tests .. QA: Fix broken browser tests * KeepGoing was visiting the login page not the signup page * Other tests broken due to reference to LoginPage rather than SpecialUserLoginPage Change-Id: Ic6f2c69f6a13527c38ee3a4ec18ef622679eef85 --- M tests/browser/features/step_definitions/common_steps.rb M tests/browser/features/step_definitions/special_userlogin_steps.rb 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/05/134805/1 diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index d4654e1..b391890 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -30,7 +30,7 @@ username = 'NewUser' + Time.now.to_i.to_s #the call to Random creates a long string of the form 0.10879935166988186 pwd = Random.new.rand.to_s - visit(SpecialUserLoginPage) do |page| + on(SpecialUserLoginPage) do |page| # undo auto complete page.username_element.when_present.send_keys(username) page.password_element.when_present.send_keys(pwd) diff --git a/tests/browser/features/step_definitions/special_userlogin_steps.rb b/tests/browser/features/step_definitions/special_userlogin_steps.rb index bfb49b8..5bd17a2 100644 --- a/tests/browser/features/step_definitions/special_userlogin_steps.rb +++ b/tests/browser/features/step_definitions/special_userlogin_steps.rb @@ -1,23 +1,23 @@ Then(/^I see a message box at the top of the login page$/) do - on(LoginPage).message_box_element.should be_visible + on(SpecialUserLoginPage).message_box_element.should be_visible end Then /^I see the log in prompt message (.+)$/ do |text| - on(LoginPage).login_head_message_element.when_present.text.should match text + on(SpecialUserLoginPage).login_head_message_element.when_present.text.should match text end Then(/^I do not see a message box at the top of the login page$/) do - on(LoginPage).message_box_element.should_not be_visible + on(SpecialUserLoginPage).message_box_element.should_not be_visible end Then(/^I see a message warning me I am already logged in$/) do - on(LoginPage).warning_box_element.should be_visible + on(SpecialUserLoginPage).warning_box_element.should be_visible end Then(/^I do not see a message warning me I am already logged in$/) do - on(LoginPage).warning_box_element.should_not be_visible + on(SpecialUserLoginPage).warning_box_element.should_not be_visible end Then(/^I see a password reset link$/) do - on(LoginPage).password_reset_element.should be_visible + on(SpecialUserLoginPage).password_reset_element.should be_visible end -- To view, visit https://gerrit.wikimedia.org/r/134805 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6f2c69f6a13527c38ee3a4ec18ef622679eef85 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] QA: Fix broken browser tests - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: QA: Fix broken browser tests .. QA: Fix broken browser tests * KeepGoing was visiting the login page not the signup page * Other tests broken due to reference to LoginPage rather than SpecialUserLoginPage Change-Id: Ic6f2c69f6a13527c38ee3a4ec18ef622679eef85 --- M tests/browser/features/step_definitions/common_steps.rb M tests/browser/features/step_definitions/special_userlogin_steps.rb 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index d4654e1..b391890 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -30,7 +30,7 @@ username = 'NewUser' + Time.now.to_i.to_s #the call to Random creates a long string of the form 0.10879935166988186 pwd = Random.new.rand.to_s - visit(SpecialUserLoginPage) do |page| + on(SpecialUserLoginPage) do |page| # undo auto complete page.username_element.when_present.send_keys(username) page.password_element.when_present.send_keys(pwd) diff --git a/tests/browser/features/step_definitions/special_userlogin_steps.rb b/tests/browser/features/step_definitions/special_userlogin_steps.rb index bfb49b8..5bd17a2 100644 --- a/tests/browser/features/step_definitions/special_userlogin_steps.rb +++ b/tests/browser/features/step_definitions/special_userlogin_steps.rb @@ -1,23 +1,23 @@ Then(/^I see a message box at the top of the login page$/) do - on(LoginPage).message_box_element.should be_visible + on(SpecialUserLoginPage).message_box_element.should be_visible end Then /^I see the log in prompt message (.+)$/ do |text| - on(LoginPage).login_head_message_element.when_present.text.should match text + on(SpecialUserLoginPage).login_head_message_element.when_present.text.should match text end Then(/^I do not see a message box at the top of the login page$/) do - on(LoginPage).message_box_element.should_not be_visible + on(SpecialUserLoginPage).message_box_element.should_not be_visible end Then(/^I see a message warning me I am already logged in$/) do - on(LoginPage).warning_box_element.should be_visible + on(SpecialUserLoginPage).warning_box_element.should be_visible end Then(/^I do not see a message warning me I am already logged in$/) do - on(LoginPage).warning_box_element.should_not be_visible + on(SpecialUserLoginPage).warning_box_element.should_not be_visible end Then(/^I see a password reset link$/) do - on(LoginPage).password_reset_element.should be_visible + on(SpecialUserLoginPage).password_reset_element.should be_visible end -- To view, visit https://gerrit.wikimedia.org/r/134805 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f2c69f6a13527c38ee3a4ec18ef622679eef85 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: Awjrichards aricha...@wikimedia.org Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: JGonera jgon...@wikimedia.org Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
