[MediaWiki-commits] [Gerrit] Re-enable images for our users. - change (mediawiki...MobileFrontend)

2015-05-06 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/209225

Change subject: Re-enable images for our users.
..

Re-enable images for our users.

Any user who opted into beta via our new panel would have also
lost images. This temporary fix turns them back on.

It also has the temporary knock on effect of disallowing images for our
beta users. We can turn this off later once we've measured the impact.

Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
---
M resources/mobile.betaoptin/init.js
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/25/209225/1

diff --git a/resources/mobile.betaoptin/init.js 
b/resources/mobile.betaoptin/init.js
index c9c23ad..3b21696 100644
--- a/resources/mobile.betaoptin/init.js
+++ b/resources/mobile.betaoptin/init.js
@@ -11,9 +11,20 @@
token = mw.user.generateRandomSessionId();
settings.save( 'mobile-betaoptin-token', token );
}
+
+   inStable = !context.isBetaGroupMember();
+   // Correct all those poor souls who already opted in to beta 
via panel
+   // and lost their images next time they view a page.
+   // FIXME: Remove this in 30 days.
+   if ( !inStable  mw.config.get( 'wgImagesDisabled' ) ) {
+   $.post( mw.util.getUrl( 'Special:MobileOptions' ), {
+   token: mw.user.tokens.get( 'editToken' ),
+   enableImages: true
+   } );
+   }
+
// a single character has 36 possibilities so this is 2/36 5.6% 
chance (a-z and 0-9)
// 3% chance of this happening
-   inStable = !context.isBetaGroupMember();
inSample = $.inArray( token.charAt( 0 ), [ '3', '2' ] ) !== -1;
if ( inStable  ( inSample || mw.util.getParamValue( 'debug' ) 
) ) {
new BetaOptinPanel()

-- 
To view, visit https://gerrit.wikimedia.org/r/209225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Re-enable images for our users. - change (mediawiki...MobileFrontend)

2015-05-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Re-enable images for our users.
..


Re-enable images for our users.

Any user who opted into beta via our new panel would have also
lost images. This temporary fix turns them back on.

It also has the temporary knock on effect of disallowing images for our
beta users. We can turn this off later once we've measured the impact.

Bug: T98340
Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
(cherry picked from commit 42cb34e366dca1f3a68660d7c8e3c058fa87047e)
---
M resources/mobile.betaoptin/init.js
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Robmoen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.betaoptin/init.js 
b/resources/mobile.betaoptin/init.js
index c9c23ad..3b21696 100644
--- a/resources/mobile.betaoptin/init.js
+++ b/resources/mobile.betaoptin/init.js
@@ -11,9 +11,20 @@
token = mw.user.generateRandomSessionId();
settings.save( 'mobile-betaoptin-token', token );
}
+
+   inStable = !context.isBetaGroupMember();
+   // Correct all those poor souls who already opted in to beta 
via panel
+   // and lost their images next time they view a page.
+   // FIXME: Remove this in 30 days.
+   if ( !inStable  mw.config.get( 'wgImagesDisabled' ) ) {
+   $.post( mw.util.getUrl( 'Special:MobileOptions' ), {
+   token: mw.user.tokens.get( 'editToken' ),
+   enableImages: true
+   } );
+   }
+
// a single character has 36 possibilities so this is 2/36 5.6% 
chance (a-z and 0-9)
// 3% chance of this happening
-   inStable = !context.isBetaGroupMember();
inSample = $.inArray( token.charAt( 0 ), [ '3', '2' ] ) !== -1;
if ( inStable  ( inSample || mw.util.getParamValue( 'debug' ) 
) ) {
new BetaOptinPanel()

-- 
To view, visit https://gerrit.wikimedia.org/r/209320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.26wmf4
Gerrit-Owner: Robmoen rm...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Robmoen rm...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Re-enable images for our users. - change (mediawiki...MobileFrontend)

2015-05-06 Thread Robmoen (Code Review) 
Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/209319

Change subject: Re-enable images for our users.
..

Re-enable images for our users.

Any user who opted into beta via our new panel would have also
lost images. This temporary fix turns them back on.

It also has the temporary knock on effect of disallowing images for our
beta users. We can turn this off later once we've measured the impact.

Bug: T98340
Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
(cherry picked from commit 42cb34e366dca1f3a68660d7c8e3c058fa87047e)
---
M resources/mobile.betaoptin/init.js
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/19/209319/1

diff --git a/resources/mobile.betaoptin/init.js 
b/resources/mobile.betaoptin/init.js
index c9c23ad..3b21696 100644
--- a/resources/mobile.betaoptin/init.js
+++ b/resources/mobile.betaoptin/init.js
@@ -11,9 +11,20 @@
token = mw.user.generateRandomSessionId();
settings.save( 'mobile-betaoptin-token', token );
}
+
+   inStable = !context.isBetaGroupMember();
+   // Correct all those poor souls who already opted in to beta 
via panel
+   // and lost their images next time they view a page.
+   // FIXME: Remove this in 30 days.
+   if ( !inStable  mw.config.get( 'wgImagesDisabled' ) ) {
+   $.post( mw.util.getUrl( 'Special:MobileOptions' ), {
+   token: mw.user.tokens.get( 'editToken' ),
+   enableImages: true
+   } );
+   }
+
// a single character has 36 possibilities so this is 2/36 5.6% 
chance (a-z and 0-9)
// 3% chance of this happening
-   inStable = !context.isBetaGroupMember();
inSample = $.inArray( token.charAt( 0 ), [ '3', '2' ] ) !== -1;
if ( inStable  ( inSample || mw.util.getParamValue( 'debug' ) 
) ) {
new BetaOptinPanel()

-- 
To view, visit https://gerrit.wikimedia.org/r/209319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.26wmf3
Gerrit-Owner: Robmoen rm...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Re-enable images for our users. - change (mediawiki...MobileFrontend)

2015-05-06 Thread Robmoen (Code Review) 
Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/209320

Change subject: Re-enable images for our users.
..

Re-enable images for our users.

Any user who opted into beta via our new panel would have also
lost images. This temporary fix turns them back on.

It also has the temporary knock on effect of disallowing images for our
beta users. We can turn this off later once we've measured the impact.

Bug: T98340
Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
(cherry picked from commit 42cb34e366dca1f3a68660d7c8e3c058fa87047e)
---
M resources/mobile.betaoptin/init.js
1 file changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/20/209320/1

diff --git a/resources/mobile.betaoptin/init.js 
b/resources/mobile.betaoptin/init.js
index c9c23ad..3b21696 100644
--- a/resources/mobile.betaoptin/init.js
+++ b/resources/mobile.betaoptin/init.js
@@ -11,9 +11,20 @@
token = mw.user.generateRandomSessionId();
settings.save( 'mobile-betaoptin-token', token );
}
+
+   inStable = !context.isBetaGroupMember();
+   // Correct all those poor souls who already opted in to beta 
via panel
+   // and lost their images next time they view a page.
+   // FIXME: Remove this in 30 days.
+   if ( !inStable  mw.config.get( 'wgImagesDisabled' ) ) {
+   $.post( mw.util.getUrl( 'Special:MobileOptions' ), {
+   token: mw.user.tokens.get( 'editToken' ),
+   enableImages: true
+   } );
+   }
+
// a single character has 36 possibilities so this is 2/36 5.6% 
chance (a-z and 0-9)
// 3% chance of this happening
-   inStable = !context.isBetaGroupMember();
inSample = $.inArray( token.charAt( 0 ), [ '3', '2' ] ) !== -1;
if ( inStable  ( inSample || mw.util.getParamValue( 'debug' ) 
) ) {
new BetaOptinPanel()

-- 
To view, visit https://gerrit.wikimedia.org/r/209320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.26wmf4
Gerrit-Owner: Robmoen rm...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Re-enable images for our users. - change (mediawiki...MobileFrontend)

2015-05-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Re-enable images for our users.
..


Re-enable images for our users.

Any user who opted into beta via our new panel would have also
lost images. This temporary fix turns them back on.

It also has the temporary knock on effect of disallowing images for our
beta users. We can turn this off later once we've measured the impact.

Bug: T98340
Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
---
M resources/mobile.betaoptin/init.js
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mobile.betaoptin/init.js 
b/resources/mobile.betaoptin/init.js
index c9c23ad..3b21696 100644
--- a/resources/mobile.betaoptin/init.js
+++ b/resources/mobile.betaoptin/init.js
@@ -11,9 +11,20 @@
token = mw.user.generateRandomSessionId();
settings.save( 'mobile-betaoptin-token', token );
}
+
+   inStable = !context.isBetaGroupMember();
+   // Correct all those poor souls who already opted in to beta 
via panel
+   // and lost their images next time they view a page.
+   // FIXME: Remove this in 30 days.
+   if ( !inStable  mw.config.get( 'wgImagesDisabled' ) ) {
+   $.post( mw.util.getUrl( 'Special:MobileOptions' ), {
+   token: mw.user.tokens.get( 'editToken' ),
+   enableImages: true
+   } );
+   }
+
// a single character has 36 possibilities so this is 2/36 5.6% 
chance (a-z and 0-9)
// 3% chance of this happening
-   inStable = !context.isBetaGroupMember();
inSample = $.inArray( token.charAt( 0 ), [ '3', '2' ] ) !== -1;
if ( inStable  ( inSample || mw.util.getParamValue( 'debug' ) 
) ) {
new BetaOptinPanel()

-- 
To view, visit https://gerrit.wikimedia.org/r/209225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c9db46422f59836388134cfdccd1ad5afcf272b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Jhernandez jhernan...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits