[MediaWiki-commits] [Gerrit] Read-only tests for workflow state selector - change (mediawiki...Translate)

2013-12-03 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/98783


Change subject: Read-only tests for workflow state selector
..

Read-only tests for workflow state selector

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3854

Change-Id: Iec2983059d25244de8b76b09b63975441b8494d7
---
A tests/browser/features/special_translate.feature
A tests/browser/features/step_definitions/special_translate_steps.rb
A tests/browser/features/support/pages/translate_page.rb
3 files changed, 56 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/83/98783/1

diff --git a/tests/browser/features/special_translate.feature 
b/tests/browser/features/special_translate.feature
new file mode 100644
index 000..d82e2a4
--- /dev/null
+++ b/tests/browser/features/special_translate.feature
@@ -0,0 +1,24 @@
+Feature: Special:Translate
+
+  This page is the primary web translation interface for users.
+
+  
https://www.mediawiki.org/wiki/Help:Extension:Translate/Quality_assurance#Workflows
+  describes how the workflow state selector can be used.
+  https://commons.wikimedia.org/wiki/File:Translate-workflow-spec.pdf?page=10
+  describes how it is meant to look and behave.
+
+  @meta.wikipedia.org @sandbox.translatewiki.net
+  Scenario: Workflow selector being visible
+Given I am translating a message group which doesn't have workflow states
+Then I should not see a workflow state
+
+  @custom-setup-needed @meta.wikipedia.org
+  Scenario: Workflow selector being visible
+Given I am translating a message group which has workflow states
+Then I should see a workflow state
+
+  @custom-setup-needed @meta.wikipedia.org
+  Scenario: Workflow selector being clickable
+Given I am translating a message group which has workflow states
+When I click the workflow state
+Then I should see a list of states
diff --git a/tests/browser/features/step_definitions/special_translate_steps.rb 
b/tests/browser/features/step_definitions/special_translate_steps.rb
new file mode 100644
index 000..416f8fd
--- /dev/null
+++ b/tests/browser/features/step_definitions/special_translate_steps.rb
@@ -0,0 +1,23 @@
+Given(/^I am translating a message group which doesn't have workflow states$/) 
do
+   visit(TranslatePage, :using_params = {:extra = language=fi})
+end
+
+Given(/^I am translating a message group which has workflow states$/) do
+   visit(TranslatePage, :using_params = {:extra = 
language=figroup=page-Language+committee})
+end
+
+When(/^I click the workflow state$/) do
+   on(TranslatePage).workflow_state_element.click
+end
+
+Then(/^I should see a workflow state$/) do
+   on(TranslatePage).workflow_state_element.should be_visible
+end
+
+Then(/^I should not see a workflow state$/) do
+   on(TranslatePage).workflow_state_element.should_not be_visible
+end
+
+Then(/^I should see a list of states$/) do
+   on(TranslatePage).workflow_state_selector_element.should be_visible
+end
diff --git a/tests/browser/features/support/pages/translate_page.rb 
b/tests/browser/features/support/pages/translate_page.rb
new file mode 100644
index 000..5cf5947
--- /dev/null
+++ b/tests/browser/features/support/pages/translate_page.rb
@@ -0,0 +1,9 @@
+class TranslatePage
+   include PageObject
+
+   include URL
+   page_url URL.url(Special:Translate?%=params[:extra]%)
+
+   div(:workflow_state, class: tux-workflow-status)
+   ul(:workflow_state_selector, class: tux-workflow-status-selector)
+end

-- 
To view, visit https://gerrit.wikimedia.org/r/98783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec2983059d25244de8b76b09b63975441b8494d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Read-only tests for workflow state selector - change (mediawiki...Translate)

2013-12-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Read-only tests for workflow state selector
..


Read-only tests for workflow state selector

https://mingle.corp.wikimedia.org/projects/internationalization/cards/3854

Change-Id: Iec2983059d25244de8b76b09b63975441b8494d7
---
A tests/browser/features/special_translate.feature
A tests/browser/features/step_definitions/special_translate_steps.rb
A tests/browser/features/support/pages/translate_page.rb
3 files changed, 56 insertions(+), 0 deletions(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/special_translate.feature 
b/tests/browser/features/special_translate.feature
new file mode 100644
index 000..d82e2a4
--- /dev/null
+++ b/tests/browser/features/special_translate.feature
@@ -0,0 +1,24 @@
+Feature: Special:Translate
+
+  This page is the primary web translation interface for users.
+
+  
https://www.mediawiki.org/wiki/Help:Extension:Translate/Quality_assurance#Workflows
+  describes how the workflow state selector can be used.
+  https://commons.wikimedia.org/wiki/File:Translate-workflow-spec.pdf?page=10
+  describes how it is meant to look and behave.
+
+  @meta.wikipedia.org @sandbox.translatewiki.net
+  Scenario: Workflow selector being visible
+Given I am translating a message group which doesn't have workflow states
+Then I should not see a workflow state
+
+  @custom-setup-needed @meta.wikipedia.org
+  Scenario: Workflow selector being visible
+Given I am translating a message group which has workflow states
+Then I should see a workflow state
+
+  @custom-setup-needed @meta.wikipedia.org
+  Scenario: Workflow selector being clickable
+Given I am translating a message group which has workflow states
+When I click the workflow state
+Then I should see a list of states
diff --git a/tests/browser/features/step_definitions/special_translate_steps.rb 
b/tests/browser/features/step_definitions/special_translate_steps.rb
new file mode 100644
index 000..416f8fd
--- /dev/null
+++ b/tests/browser/features/step_definitions/special_translate_steps.rb
@@ -0,0 +1,23 @@
+Given(/^I am translating a message group which doesn't have workflow states$/) 
do
+   visit(TranslatePage, :using_params = {:extra = language=fi})
+end
+
+Given(/^I am translating a message group which has workflow states$/) do
+   visit(TranslatePage, :using_params = {:extra = 
language=figroup=page-Language+committee})
+end
+
+When(/^I click the workflow state$/) do
+   on(TranslatePage).workflow_state_element.click
+end
+
+Then(/^I should see a workflow state$/) do
+   on(TranslatePage).workflow_state_element.should be_visible
+end
+
+Then(/^I should not see a workflow state$/) do
+   on(TranslatePage).workflow_state_element.should_not be_visible
+end
+
+Then(/^I should see a list of states$/) do
+   on(TranslatePage).workflow_state_selector_element.should be_visible
+end
diff --git a/tests/browser/features/support/pages/translate_page.rb 
b/tests/browser/features/support/pages/translate_page.rb
new file mode 100644
index 000..5cf5947
--- /dev/null
+++ b/tests/browser/features/support/pages/translate_page.rb
@@ -0,0 +1,9 @@
+class TranslatePage
+   include PageObject
+
+   include URL
+   page_url URL.url(Special:Translate?%=params[:extra]%)
+
+   div(:workflow_state, class: tux-workflow-status)
+   ul(:workflow_state_selector, class: tux-workflow-status-selector)
+end

-- 
To view, visit https://gerrit.wikimedia.org/r/98783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec2983059d25244de8b76b09b63975441b8494d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits