[MediaWiki-commits] [Gerrit] Really fix exceptions on Special:Translations - change (mediawiki...Translate)

2016-01-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Really fix exceptions on Special:Translations
..


Really fix exceptions on Special:Translations

Previous commit was not rebased correctly.

Bug: T93855
Change-Id: Iaafd6b6dec66f5995f14cc5c9da874cee6607acf
---
M specials/SpecialTranslations.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/SpecialTranslations.php b/specials/SpecialTranslations.php
index 1d20988..8f9a8ee 100644
--- a/specials/SpecialTranslations.php
+++ b/specials/SpecialTranslations.php
@@ -224,7 +224,6 @@
$tHandle = new MessageHandle( $tTitle );
 
$code = $tHandle->getCode();
-   $language = Language::factory( $code );
 
$text = TranslateUtils::getLanguageName( $code, 
$this->getLanguage()->getCode() );
$text .= $separator;
@@ -258,6 +257,7 @@
 
$languageAttributes = array();
if ( Language::isKnownLanguageTag( $code ) ) {
+   $language = Language::factory( $code );
$languageAttributes = array(
'lang' => $language->getHtmlCode(),
'dir' => $language->getDir(),

-- 
To view, visit https://gerrit.wikimedia.org/r/265730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaafd6b6dec66f5995f14cc5c9da874cee6607acf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Really fix exceptions on Special:Translations - change (mediawiki...Translate)

2016-01-22 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/265730

Change subject: Really fix exceptions on Special:Translations
..

Really fix exceptions on Special:Translations

Previous commit was not rebased correctly.

Bug: T93855
Change-Id: Iaafd6b6dec66f5995f14cc5c9da874cee6607acf
---
M specials/SpecialTranslations.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/30/265730/1

diff --git a/specials/SpecialTranslations.php b/specials/SpecialTranslations.php
index 1d20988..8f9a8ee 100644
--- a/specials/SpecialTranslations.php
+++ b/specials/SpecialTranslations.php
@@ -224,7 +224,6 @@
$tHandle = new MessageHandle( $tTitle );
 
$code = $tHandle->getCode();
-   $language = Language::factory( $code );
 
$text = TranslateUtils::getLanguageName( $code, 
$this->getLanguage()->getCode() );
$text .= $separator;
@@ -258,6 +257,7 @@
 
$languageAttributes = array();
if ( Language::isKnownLanguageTag( $code ) ) {
+   $language = Language::factory( $code );
$languageAttributes = array(
'lang' => $language->getHtmlCode(),
'dir' => $language->getDir(),

-- 
To view, visit https://gerrit.wikimedia.org/r/265730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaafd6b6dec66f5995f14cc5c9da874cee6607acf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits