[MediaWiki-commits] [Gerrit] Reflect upstream infrastructure change - change (mediawiki...Gather)

2015-06-01 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Reflect upstream infrastructure change
..


Reflect upstream infrastructure change

View now supports enhance mode.

Bug: T98175
Change-Id: I8aa71d7b5d0389b1ac4d7c6861cc84f14486f4d0
---
M resources/ext.gather.collections.list/CollectionsList.js
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.gather.collections.list/CollectionsList.js 
b/resources/ext.gather.collections.list/CollectionsList.js
index e0eca0f..6aaadbd 100644
--- a/resources/ext.gather.collections.list/CollectionsList.js
+++ b/resources/ext.gather.collections.list/CollectionsList.js
@@ -9,8 +9,8 @@
CreateCollectionButton = M.require( 
'ext.gather.collections.list/CreateCollectionButton' );
 
CollectionsList = View.extend( {
+   /** @inheritdoc */
defaults: {
-   enhance: false,
collections: []
},
template: mw.template.get( 'ext.gather.collections.list', 
'CollectionsList.hogan' ),
@@ -19,10 +19,7 @@
image: mw.template.get( 'ext.gather.collections.list', 
'CardImage.hogan' )
},
/** @inheritdoc */
-   initialize: function ( options ) {
-   if ( options.enhance ) {
-   this.template = false;
-   }
+   initialize: function () {
View.prototype.initialize.apply( this, arguments );
// After the initial render initialize the infinite 
scrolling.
this.$pagination = this.$el.find( 
'.collections-pagination' );

-- 
To view, visit https://gerrit.wikimedia.org/r/214370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8aa71d7b5d0389b1ac4d7c6861cc84f14486f4d0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Jhernandez jhernan...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Reflect upstream infrastructure change - change (mediawiki...Gather)

2015-05-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/214370

Change subject: Reflect upstream infrastructure change
..

Reflect upstream infrastructure change

View now supports enhance mode.

Bug: T98175
Change-Id: I8aa71d7b5d0389b1ac4d7c6861cc84f14486f4d0
---
M resources/ext.gather.collections.list/CollectionsList.js
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/70/214370/1

diff --git a/resources/ext.gather.collections.list/CollectionsList.js 
b/resources/ext.gather.collections.list/CollectionsList.js
index e0eca0f..0beba97 100644
--- a/resources/ext.gather.collections.list/CollectionsList.js
+++ b/resources/ext.gather.collections.list/CollectionsList.js
@@ -9,8 +9,8 @@
CreateCollectionButton = M.require( 
'ext.gather.collections.list/CreateCollectionButton' );
 
CollectionsList = View.extend( {
+   /** @inheritdoc */
defaults: {
-   enhance: false,
collections: []
},
template: mw.template.get( 'ext.gather.collections.list', 
'CollectionsList.hogan' ),
@@ -20,9 +20,6 @@
},
/** @inheritdoc */
initialize: function ( options ) {
-   if ( options.enhance ) {
-   this.template = false;
-   }
View.prototype.initialize.apply( this, arguments );
// After the initial render initialize the infinite 
scrolling.
this.$pagination = this.$el.find( 
'.collections-pagination' );

-- 
To view, visit https://gerrit.wikimedia.org/r/214370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8aa71d7b5d0389b1ac4d7c6861cc84f14486f4d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits