[MediaWiki-commits] [Gerrit] Regress RTL fix transclusion icon - change (mediawiki...VisualEditor)

2013-07-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Regress RTL fix transclusion icon
..


Regress RTL fix transclusion icon

The fix to the transclusion icon messed up the way inspectors appear in RTL
wikis. The rtl check/correction (inside 'this.embedded') seems to be the only
rtl fix necessary. Something completely different will have to be done to the
transclusion icon.

Change-Id: I2417e125c99de9b0c5fd922a47de43ed9952d6fd
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index 694af14..007fea8 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -278,12 +278,8 @@
$container = inspector ? this.inspectors.$ : this.$menu;
this.popup.align = 'center';
}
-   // Flip left with right if CE is RTL
-   if ( this.surface.view.getDir() === 'rtl' ) {
-   this.$.css( { 'right': position.x, 'top': position.y } 
);
-   } else {
-   this.$.css( { 'left': position.x, 'top': position.y } );
-   }
+   this.$.css( { 'left': position.x, 'top': position.y } );
+
this.popup.display(
position.x,
position.y,

-- 
To view, visit https://gerrit.wikimedia.org/r/75820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2417e125c99de9b0c5fd922a47de43ed9952d6fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Amire80 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Inez 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Regress RTL fix transclusion icon - change (mediawiki...VisualEditor)

2013-07-24 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/75820


Change subject: Regress RTL fix transclusion icon
..

Regress RTL fix transclusion icon

The fix to the transclusion icon messed up the way inspectors appear in RTL
wikis. The rtl check/correction (inside 'this.embedded') seems to be the only
rtl fix necessary. Something completely different will have to be done to the
transclusion icon.

Change-Id: I2417e125c99de9b0c5fd922a47de43ed9952d6fd
---
M modules/ve/ui/ve.ui.Context.js
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/20/75820/1

diff --git a/modules/ve/ui/ve.ui.Context.js b/modules/ve/ui/ve.ui.Context.js
index 694af14..007fea8 100644
--- a/modules/ve/ui/ve.ui.Context.js
+++ b/modules/ve/ui/ve.ui.Context.js
@@ -278,12 +278,8 @@
$container = inspector ? this.inspectors.$ : this.$menu;
this.popup.align = 'center';
}
-   // Flip left with right if CE is RTL
-   if ( this.surface.view.getDir() === 'rtl' ) {
-   this.$.css( { 'right': position.x, 'top': position.y } 
);
-   } else {
-   this.$.css( { 'left': position.x, 'top': position.y } );
-   }
+   this.$.css( { 'left': position.x, 'top': position.y } );
+
this.popup.display(
position.x,
position.y,

-- 
To view, visit https://gerrit.wikimedia.org/r/75820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2417e125c99de9b0c5fd922a47de43ed9952d6fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits