[MediaWiki-commits] [Gerrit] Regression: Fix broken tests - change (mediawiki...MobileFrontend)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/52889 Change subject: Regression: Fix broken tests .. Regression: Fix broken tests Not sure how these past jenkins! Change-Id: I8efc1de415f3ec5754c654b0c615af5a029b4e66 --- M tests/DeviceDetectionTest.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/89/52889/1 diff --git a/tests/DeviceDetectionTest.php b/tests/DeviceDetectionTest.php index 241fd4e..ebd504d 100644 --- a/tests/DeviceDetectionTest.php +++ b/tests/DeviceDetectionTest.php @@ -90,11 +90,11 @@ array( 'android', '' ), array( 'iphone2', '' ), array( 'palm_pre', '' ), - array( 'html', 'mobile.device.default' ), - array( 'capable', 'mobile.device.default' ), + array( 'html', '' ), + array( 'capable', '' ), array( 'ie', 'mobile.device.ie' ), array( 'iphone', 'mobile.device.iphone' ), - array( 'native_iphone', 'mobile.device.default' ), + array( 'native_iphone', '' ), array( 'kindle', 'mobile.device.kindle' ), array( 'kindle2', 'mobile.device.kindle' ), array( 'blackberry', 'mobile.device.blackberry' ), -- To view, visit https://gerrit.wikimedia.org/r/52889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8efc1de415f3ec5754c654b0c615af5a029b4e66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Regression: Fix broken tests - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: Regression: Fix broken tests .. Regression: Fix broken tests Not sure how these past jenkins! Change-Id: I8efc1de415f3ec5754c654b0c615af5a029b4e66 --- M tests/DeviceDetectionTest.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jdlrobson: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/tests/DeviceDetectionTest.php b/tests/DeviceDetectionTest.php index 241fd4e..ebd504d 100644 --- a/tests/DeviceDetectionTest.php +++ b/tests/DeviceDetectionTest.php @@ -90,11 +90,11 @@ array( 'android', '' ), array( 'iphone2', '' ), array( 'palm_pre', '' ), - array( 'html', 'mobile.device.default' ), - array( 'capable', 'mobile.device.default' ), + array( 'html', '' ), + array( 'capable', '' ), array( 'ie', 'mobile.device.ie' ), array( 'iphone', 'mobile.device.iphone' ), - array( 'native_iphone', 'mobile.device.default' ), + array( 'native_iphone', '' ), array( 'kindle', 'mobile.device.kindle' ), array( 'kindle2', 'mobile.device.kindle' ), array( 'blackberry', 'mobile.device.blackberry' ), -- To view, visit https://gerrit.wikimedia.org/r/52889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8efc1de415f3ec5754c654b0c615af5a029b4e66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Regression: Fix broken tests - change (mediawiki...MobileFrontend)
MaxSem has submitted this change and it was merged. Change subject: Regression: Fix broken tests .. Regression: Fix broken tests Due to renaming of watchlist.js to watchstar.js Change-Id: Icd3fc91e752f05753832beb162efd0e72b74d452 --- M includes/MobileFrontend.hooks.php R tests/js/test_mf-watchstar.js 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: MaxSem: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 07cbca0..d6d05c6 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -142,7 +142,7 @@ 'javascripts/common/mf-notification.js', 'javascripts/modules/mf-photo.js', 'tests/js/test_mf-photo.js', 'javascripts/modules/mf-references.js', 'tests/js/test_references.js', - 'javascripts/modules/mf-watchlist.js', 'tests/js/test_mf-watchlist.js', + 'javascripts/modules/mf-watchstar.js', 'tests/js/test_mf-watchstar.js', 'javascripts/modules/mf-last-modified.js', 'tests/js/test_mf-last-modified.js' ), 'dependencies' = array( ), 'localBasePath' = dirname( dirname( __FILE__ ) ), diff --git a/tests/js/test_mf-watchlist.js b/tests/js/test_mf-watchstar.js similarity index 100% rename from tests/js/test_mf-watchlist.js rename to tests/js/test_mf-watchstar.js -- To view, visit https://gerrit.wikimedia.org/r/51630 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd3fc91e752f05753832beb162efd0e72b74d452 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Regression: Fix broken tests - change (mediawiki...MobileFrontend)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/51630 Change subject: Regression: Fix broken tests .. Regression: Fix broken tests Due to renaming of watchlist.js to watchstar.js Change-Id: Icd3fc91e752f05753832beb162efd0e72b74d452 --- M includes/MobileFrontend.hooks.php R tests/js/test_mf-watchstar.js 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/30/51630/1 diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 07cbca0..d6d05c6 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -142,7 +142,7 @@ 'javascripts/common/mf-notification.js', 'javascripts/modules/mf-photo.js', 'tests/js/test_mf-photo.js', 'javascripts/modules/mf-references.js', 'tests/js/test_references.js', - 'javascripts/modules/mf-watchlist.js', 'tests/js/test_mf-watchlist.js', + 'javascripts/modules/mf-watchstar.js', 'tests/js/test_mf-watchstar.js', 'javascripts/modules/mf-last-modified.js', 'tests/js/test_mf-last-modified.js' ), 'dependencies' = array( ), 'localBasePath' = dirname( dirname( __FILE__ ) ), diff --git a/tests/js/test_mf-watchlist.js b/tests/js/test_mf-watchstar.js similarity index 100% rename from tests/js/test_mf-watchlist.js rename to tests/js/test_mf-watchstar.js -- To view, visit https://gerrit.wikimedia.org/r/51630 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd3fc91e752f05753832beb162efd0e72b74d452 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson jrob...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
