[MediaWiki-commits] [Gerrit] Remove LanguageEo::checkTitleEncoding() - change (mediawiki/core)

[Brion VIBBER (Code Review)]

Brion VIBBER has submitted this change and it was merged.

Change subject: Remove LanguageEo::checkTitleEncoding()
..


Remove LanguageEo::checkTitleEncoding()

In 2005, the code to perform the conversion from the Esperanto
x-system to Unicode was recognized as problematic and commented
out (bug 1512, r10997). Hence this function has done nothing
useful in the last eight years.

Change-Id: I9f4351c638645024b17a828144bba8575db14195
---
M languages/classes/LanguageEo.php
1 file changed, 0 insertions(+), 24 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/languages/classes/LanguageEo.php b/languages/classes/LanguageEo.php
index 39bdfb5..0e2d8b4 100644
--- a/languages/classes/LanguageEo.php
+++ b/languages/classes/LanguageEo.php
@@ -114,30 +114,6 @@
return strtr( $matches[1], $xu ) . strtr( $matches[2], $xu );
}
 
-   /**
-* @param $s string
-* @return string
-*/
-   function checkTitleEncoding( $s ) {
-   # Check for X-system backwards-compatibility URLs
-   $ishigh = preg_match( '/[\x80-\xff]/', $s );
-   $isutf = preg_match( '/^([\x00-\x7f]|[\xc0-\xdf][\x80-\xbf]|' .
-   
'[\xe0-\xef][\x80-\xbf]{2}|[\xf0-\xf7][\x80-\xbf]{3})+$/', $s );
-
-   if ( $ishigh and !$isutf ) {
-   # Assume Latin1
-   $s = utf8_encode( $s );
-   } elseif ( preg_match( 
'/(\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]' .
-   '|\xc5[\x9c\x9d\xac\xad])/', $s )
-   ) {
-   return $s;
-   }
-
-   // if( preg_match( '/[cghjsu]x/i', $s ) )
-   //  return $this-iconv( 'x', 'utf-8', $s );
-   return $s;
-   }
-
function initEncoding() {
global $wgEditEncoding;
$wgEditEncoding = 'x';

-- 
To view, visit https://gerrit.wikimedia.org/r/85410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f4351c638645024b17a828144bba8575db14195
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand pleasest...@live.com
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove LanguageEo::checkTitleEncoding() - change (mediawiki/core)

[PleaseStand (Code Review)]

PleaseStand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/85410


Change subject: Remove LanguageEo::checkTitleEncoding()
..

Remove LanguageEo::checkTitleEncoding()

In 2005, the code to perform the conversion from the Esperanto
x-system to Unicode was recognized as problematic and commented
out (bug 1512, r10997). Hence this function has done nothing
useful in the last eight years.

Change-Id: I9f4351c638645024b17a828144bba8575db14195
---
M languages/classes/LanguageEo.php
1 file changed, 0 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/10/85410/1

diff --git a/languages/classes/LanguageEo.php b/languages/classes/LanguageEo.php
index c5e2bec..0e2d8b4 100644
--- a/languages/classes/LanguageEo.php
+++ b/languages/classes/LanguageEo.php
@@ -114,30 +114,6 @@
return strtr( $matches[1], $xu ) . strtr( $matches[2], $xu );
}
 
-   /**
-* @param $s string
-* @return string
-*/
-   function checkTitleEncoding( $s ) {
-   # Check for X-system backwards-compatibility URLs
-   $ishigh = preg_match( '/[\x80-\xff]/S', $s );
-   $isutf = preg_match( '/^([\x00-\x7f]|[\xc0-\xdf][\x80-\xbf]|' .
-   
'[\xe0-\xef][\x80-\xbf]{2}|[\xf0-\xf7][\x80-\xbf]{3})+$/', $s );
-
-   if ( $ishigh and !$isutf ) {
-   # Assume Latin1
-   $s = utf8_encode( $s );
-   } elseif ( preg_match( 
'/(\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]' .
-   '|\xc5[\x9c\x9d\xac\xad])/', $s )
-   ) {
-   return $s;
-   }
-
-   // if( preg_match( '/[cghjsu]x/i', $s ) )
-   //  return $this-iconv( 'x', 'utf-8', $s );
-   return $s;
-   }
-
function initEncoding() {
global $wgEditEncoding;
$wgEditEncoding = 'x';

-- 
To view, visit https://gerrit.wikimedia.org/r/85410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f4351c638645024b17a828144bba8575db14195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand pleasest...@live.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits