[MediaWiki-commits] [Gerrit] Remove ApiWikibase::mustBePosted - change (mediawiki...Wikibase)

2015-07-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove ApiWikibase::mustBePosted
..


Remove ApiWikibase::mustBePosted

This is already correctly assesed by
ApiBase::mustBePosted which checks if a token
is needed or not.

If we require a token, it must be posted

Change-Id: I4ccc278ce9c4d8e294fc456032078de4a92ae094
---
M repo/includes/api/ApiWikibase.php
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/includes/api/ApiWikibase.php 
b/repo/includes/api/ApiWikibase.php
index eee9cab..c05b6cc 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -161,15 +161,6 @@
}
 
/**
-* @see ApiBase::mustBePosted()
-*
-* @return bool
-*/
-   public function mustBePosted() {
-   return $this->isWriteMode();
-   }
-
-   /**
 * Returns the permissions that are required to perform the operation 
specified by
 * the parameters.
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/222903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ccc278ce9c4d8e294fc456032078de4a92ae094
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove ApiWikibase::mustBePosted - change (mediawiki...Wikibase)

2015-07-05 Thread Addshore (Code Review) 
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222903

Change subject: Remove ApiWikibase::mustBePosted
..

Remove ApiWikibase::mustBePosted

This is already correctly assesed by
ApiBase::mustBePosted which checks if a token
is needed or not.

If we require a token, it must be posted

Change-Id: I4ccc278ce9c4d8e294fc456032078de4a92ae094
---
M repo/includes/api/ApiWikibase.php
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/03/222903/1

diff --git a/repo/includes/api/ApiWikibase.php 
b/repo/includes/api/ApiWikibase.php
index eee9cab..c05b6cc 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -161,15 +161,6 @@
}
 
/**
-* @see ApiBase::mustBePosted()
-*
-* @return bool
-*/
-   public function mustBePosted() {
-   return $this->isWriteMode();
-   }
-
-   /**
 * Returns the permissions that are required to perform the operation 
specified by
 * the parameters.
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/222903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ccc278ce9c4d8e294fc456032078de4a92ae094
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits