Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224754
Change subject: Remove deprecated method Property.getType()
......................................................................
Remove deprecated method Property.getType()
Obsolete for over 1 year, see commit
2c1902849c8d4cb3256aa09db2bd68a7b599e6f9.
Change-Id: Id734cdcbfd13eeeb63b66ce9c98e72006daba623
---
M pywikibot/page.py
M tests/wikibase_tests.py
2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/54/224754/1
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 933a51e..d349248 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3936,20 +3936,6 @@
self._type = self.repo.getPropertyType(self)
return self._type
- @deprecated("Property.type")
- def getType(self):
- """
- Return the type of this property.
-
- It returns 'globecoordinate' for type 'globe-coordinate'
- in order to be backwards compatible. See
- https://gerrit.wikimedia.org/r/#/c/135405/ for background.
- """
- if self.type == 'globe-coordinate':
- return 'globecoordinate'
- else:
- return self._type
-
def getID(self, numeric=False):
"""
Get the identifier of this property.
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index ef98b5d..2e483e9 100644
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -540,11 +540,9 @@
wikidata = self.get_repo()
property_page = pywikibot.PropertyPage(wikidata, 'P625')
self.assertEqual(property_page.type, 'globe-coordinate')
- self.assertEqual(property_page.getType(), 'globecoordinate')
claim = pywikibot.Claim(wikidata, 'P625')
self.assertEqual(claim.type, 'globe-coordinate')
- self.assertEqual(claim.getType(), 'globecoordinate')
def test_get(self):
wikidata = self.get_repo()
--
To view, visit https://gerrit.wikimedia.org/r/224754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id734cdcbfd13eeeb63b66ce9c98e72006daba623
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisa...@openmailbox.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
