[MediaWiki-commits] [Gerrit] Remove getCustomPrinter from ULS extension - change (mediawiki...UniversalLanguageSelector)

2016-01-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove getCustomPrinter from ULS extension
..


Remove getCustomPrinter from ULS extension

Bug: T91457
Change-Id: I0cff2c687a40a4af3b0202255f59f4f37ea41788
---
M api/ApiLanguageSearch.php
M resources/js/ext.uls.mediawiki.js
2 files changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Nikerabbit: Checked; Looks good to me, approved
  Florianschmidtwelzow: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/api/ApiLanguageSearch.php b/api/ApiLanguageSearch.php
index d1c4c97..d77aa26 100644
--- a/api/ApiLanguageSearch.php
+++ b/api/ApiLanguageSearch.php
@@ -23,10 +23,6 @@
  */
 class ApiLanguageSearch extends ApiBase {
 
-   public function getCustomPrinter() {
-   return $this->getMain()->createPrinterByName( 'json' );
-   }
-
public function execute() {
$params = $this->extractRequestParams();
$search = $params['search'];
diff --git a/resources/js/ext.uls.mediawiki.js 
b/resources/js/ext.uls.mediawiki.js
index 3bc0eea..4531041 100644
--- a/resources/js/ext.uls.mediawiki.js
+++ b/resources/js/ext.uls.mediawiki.js
@@ -22,7 +22,7 @@
// MediaWiki overrides for ULS defaults
$.fn.uls.defaults = $.extend( $.fn.uls.defaults, {
languages: mw.config.get( 'wgULSLanguages' ) || {},
-   searchAPI: mw.util.wikiScript( 'api' ) + 
'?action=languagesearch'
+   searchAPI: mw.util.wikiScript( 'api' ) + 
'?action=languagesearch&format=json'
} );
 
// No need of IME in the ULS language search bar

-- 
To view, visit https://gerrit.wikimedia.org/r/264862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0cff2c687a40a4af3b0202255f59f4f37ea41788
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: MtDu 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: MtDu 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove getCustomPrinter from ULS extension - change (mediawiki...UniversalLanguageSelector)

2016-01-18 Thread MtDu (Code Review) 
MtDu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/264862

Change subject: Remove getCustomPrinter from ULS extension
..

Remove getCustomPrinter from ULS extension

Bug: T91457
Change-Id: I0cff2c687a40a4af3b0202255f59f4f37ea41788
---
M api/ApiLanguageSearch.php
M api/ApiULSLocalization.php
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/62/264862/1

diff --git a/api/ApiLanguageSearch.php b/api/ApiLanguageSearch.php
index d1c4c97..d77aa26 100644
--- a/api/ApiLanguageSearch.php
+++ b/api/ApiLanguageSearch.php
@@ -23,10 +23,6 @@
  */
 class ApiLanguageSearch extends ApiBase {
 
-   public function getCustomPrinter() {
-   return $this->getMain()->createPrinterByName( 'json' );
-   }
-
public function execute() {
$params = $this->extractRequestParams();
$search = $params['search'];
diff --git a/api/ApiULSLocalization.php b/api/ApiULSLocalization.php
index 2699a4d..2f5be3c 100644
--- a/api/ApiULSLocalization.php
+++ b/api/ApiULSLocalization.php
@@ -38,13 +38,6 @@
$this->getResult()->addValue( null, 'mime', 'application/json' 
);
}
 
-   public function getCustomPrinter() {
-   return new ApiFormatRaw(
-   $this->getMain(),
-   $this->getMain()->createPrinterByName( 'json' )
-   );
-   }
-
public function getAllowedParams() {
return array(
'language' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/264862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cff2c687a40a4af3b0202255f59f4f37ea41788
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: MtDu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits