[MediaWiki-commits] [Gerrit] Remove i18n shim - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Remove i18n shim .. Remove i18n shim Change-Id: Iab92a7f170d1bdbb0caf4047c9f0b38023526820 --- D UniversalLanguageSelector.i18n.php M UniversalLanguageSelector.php 2 files changed, 0 insertions(+), 37 deletions(-) Approvals: Paladox: Looks good to me, but someone else must approve Umherirrender: Looks good to me, approved jenkins-bot: Verified diff --git a/UniversalLanguageSelector.i18n.php b/UniversalLanguageSelector.i18n.php deleted file mode 100644 index 12624a9..000 --- a/UniversalLanguageSelector.i18n.php +++ /dev/null @@ -1,35 +0,0 @@ -https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php - * - * Beginning with MediaWiki 1.23, translation strings are stored in json files, - * and the EXTENSION.i18n.php file only exists to provide compatibility with - * older releases of MediaWiki. For more information about this migration, see: - * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format - * - * This shim maintains compatibility back to MediaWiki 1.17. - */ -$messages = array(); -if ( !function_exists( 'wfJsonI18nShim29b26b9f5d64bcef' ) ) { - function wfJsonI18nShim29b26b9f5d64bcef( $cache, $code, &$cachedData ) { - $codeSequence = array_merge( array( $code ), $cachedData['fallbackSequence'] ); - foreach ( $codeSequence as $csCode ) { - $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json"; - if ( is_readable( $fileName ) ) { - $data = FormatJson::decode( file_get_contents( $fileName ), true ); - foreach ( array_keys( $data ) as $key ) { - if ( $key === '' || $key[0] === '@' ) { - unset( $data[$key] ); - } - } - $cachedData['messages'] = array_merge( $data, $cachedData['messages'] ); - } - - $cachedData['deps'][] = new FileDependency( $fileName ); - } - return true; - } - - $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 'wfJsonI18nShim29b26b9f5d64bcef'; -} diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php index 59c64f5..d18c1ab 100644 --- a/UniversalLanguageSelector.php +++ b/UniversalLanguageSelector.php @@ -184,8 +184,6 @@ // Internationalization $GLOBALS['wgMessagesDirs']['UniversalLanguageSelector'] = __DIR__ . '/i18n'; -$GLOBALS['wgExtensionMessagesFiles']['UniversalLanguageSelector'] = - __DIR__ . '/UniversalLanguageSelector.i18n.php'; // Register auto load for the page class $GLOBALS['wgAutoloadClasses'] += array( -- To view, visit https://gerrit.wikimedia.org/r/67 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab92a7f170d1bdbb0caf4047c9f0b38023526820 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Nikerabbit Gerrit-Reviewer: KartikMistry Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Paladox Gerrit-Reviewer: Santhosh Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove i18n shim - change (mediawiki...UniversalLanguageSelector)
Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/67 Change subject: Remove i18n shim .. Remove i18n shim Change-Id: Iab92a7f170d1bdbb0caf4047c9f0b38023526820 --- D UniversalLanguageSelector.i18n.php M UniversalLanguageSelector.php 2 files changed, 0 insertions(+), 37 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/67/67/1 diff --git a/UniversalLanguageSelector.i18n.php b/UniversalLanguageSelector.i18n.php deleted file mode 100644 index 12624a9..000 --- a/UniversalLanguageSelector.i18n.php +++ /dev/null @@ -1,35 +0,0 @@ -https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php - * - * Beginning with MediaWiki 1.23, translation strings are stored in json files, - * and the EXTENSION.i18n.php file only exists to provide compatibility with - * older releases of MediaWiki. For more information about this migration, see: - * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format - * - * This shim maintains compatibility back to MediaWiki 1.17. - */ -$messages = array(); -if ( !function_exists( 'wfJsonI18nShim29b26b9f5d64bcef' ) ) { - function wfJsonI18nShim29b26b9f5d64bcef( $cache, $code, &$cachedData ) { - $codeSequence = array_merge( array( $code ), $cachedData['fallbackSequence'] ); - foreach ( $codeSequence as $csCode ) { - $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json"; - if ( is_readable( $fileName ) ) { - $data = FormatJson::decode( file_get_contents( $fileName ), true ); - foreach ( array_keys( $data ) as $key ) { - if ( $key === '' || $key[0] === '@' ) { - unset( $data[$key] ); - } - } - $cachedData['messages'] = array_merge( $data, $cachedData['messages'] ); - } - - $cachedData['deps'][] = new FileDependency( $fileName ); - } - return true; - } - - $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 'wfJsonI18nShim29b26b9f5d64bcef'; -} diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php index 59c64f5..d18c1ab 100644 --- a/UniversalLanguageSelector.php +++ b/UniversalLanguageSelector.php @@ -184,8 +184,6 @@ // Internationalization $GLOBALS['wgMessagesDirs']['UniversalLanguageSelector'] = __DIR__ . '/i18n'; -$GLOBALS['wgExtensionMessagesFiles']['UniversalLanguageSelector'] = - __DIR__ . '/UniversalLanguageSelector.i18n.php'; // Register auto load for the page class $GLOBALS['wgAutoloadClasses'] += array( -- To view, visit https://gerrit.wikimedia.org/r/67 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab92a7f170d1bdbb0caf4047c9f0b38023526820 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits