[MediaWiki-commits] [Gerrit] Remove leading spaces in two messages - change (mediawiki/core)

2013-04-01 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/56900


Change subject: Remove leading spaces in two messages
..

Remove leading spaces in two messages

Also replace two hard coded space by a word separator.

Spotter by 아라 in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Upload_source_url/en

Change-Id: If3fbe2ed9b2bd7e156cc31055e9c74da3d79240a
---
M includes/specials/SpecialUpload.php
M languages/messages/MessagesEn.php
2 files changed, 11 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/56900/1

diff --git a/includes/specials/SpecialUpload.php 
b/includes/specials/SpecialUpload.php
index 89c06b2..b665c4b 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -843,10 +843,13 @@
'upload-type' = 'File',
'radio' = $radio,
'help' = $this-msg( 'upload-maxfilesize',
-   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['file'] )
-   )-parse() . ' ' . $this-msg( 
'upload_source_file' )-escaped(),
+   $this-getContext()-getLanguage()-formatSize( 
$this-mMaxUploadSize['file'] ) )
+   -parse() .
+   $this-msg( 'word-separator' )-escaped() .
+   $this-msg( 'upload_source_file' )-escaped(),
'checked' = $selectedSourceType == 'file',
);
+
if ( $canUploadByUrl ) {
$this-mMaxUploadSize['url'] = 
UploadBase::getMaxUploadSize( 'url' );
$descriptor['UploadFileURL'] = array(
@@ -857,8 +860,10 @@
'upload-type' = 'url',
'radio' = $radio,
'help' = $this-msg( 'upload-maxfilesize',
-   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['url'] )
-   )-parse() . ' ' . $this-msg( 
'upload_source_url' )-escaped(),
+   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['url'] ) )
+   -parse() .
+   $this-msg( 'word-separator' 
)-escaped() .
+   $this-msg( 'upload_source_url' 
)-escaped(),
'checked' = $selectedSourceType == 'url',
);
}
diff --git a/languages/messages/MessagesEn.php 
b/languages/messages/MessagesEn.php
index 9de6aaf..d95f195 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2414,8 +2414,8 @@
 'nolicense'  = 'None selected',
 'licenses'   = '-', # do not translate or duplicate this message to 
other languages
 'license-nopreview'  = '(Preview not available)',
-'upload_source_url'  = ' (a valid, publicly accessible URL)',
-'upload_source_file' = ' (a file on your computer)',
+'upload_source_url'  = '(a valid, publicly accessible URL)',
+'upload_source_file' = '(a file on your computer)',
 
 # Special:ListFiles
 'listfiles-summary' = 'This special page shows all uploaded files.

-- 
To view, visit https://gerrit.wikimedia.org/r/56900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3fbe2ed9b2bd7e156cc31055e9c74da3d79240a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove leading spaces in two messages - change (mediawiki/core)

2013-04-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove leading spaces in two messages
..


Remove leading spaces in two messages

Also replace two hard coded space by a word separator.

Spotted by 아라 in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Upload_source_url/en

Change-Id: If3fbe2ed9b2bd7e156cc31055e9c74da3d79240a
---
M includes/specials/SpecialUpload.php
M languages/messages/MessagesEn.php
2 files changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialUpload.php 
b/includes/specials/SpecialUpload.php
index 89c06b2..b665c4b 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -843,10 +843,13 @@
'upload-type' = 'File',
'radio' = $radio,
'help' = $this-msg( 'upload-maxfilesize',
-   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['file'] )
-   )-parse() . ' ' . $this-msg( 
'upload_source_file' )-escaped(),
+   $this-getContext()-getLanguage()-formatSize( 
$this-mMaxUploadSize['file'] ) )
+   -parse() .
+   $this-msg( 'word-separator' )-escaped() .
+   $this-msg( 'upload_source_file' )-escaped(),
'checked' = $selectedSourceType == 'file',
);
+
if ( $canUploadByUrl ) {
$this-mMaxUploadSize['url'] = 
UploadBase::getMaxUploadSize( 'url' );
$descriptor['UploadFileURL'] = array(
@@ -857,8 +860,10 @@
'upload-type' = 'url',
'radio' = $radio,
'help' = $this-msg( 'upload-maxfilesize',
-   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['url'] )
-   )-parse() . ' ' . $this-msg( 
'upload_source_url' )-escaped(),
+   
$this-getContext()-getLanguage()-formatSize( $this-mMaxUploadSize['url'] ) )
+   -parse() .
+   $this-msg( 'word-separator' 
)-escaped() .
+   $this-msg( 'upload_source_url' 
)-escaped(),
'checked' = $selectedSourceType == 'url',
);
}
diff --git a/languages/messages/MessagesEn.php 
b/languages/messages/MessagesEn.php
index 9de6aaf..d95f195 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2414,8 +2414,8 @@
 'nolicense'  = 'None selected',
 'licenses'   = '-', # do not translate or duplicate this message to 
other languages
 'license-nopreview'  = '(Preview not available)',
-'upload_source_url'  = ' (a valid, publicly accessible URL)',
-'upload_source_file' = ' (a file on your computer)',
+'upload_source_url'  = '(a valid, publicly accessible URL)',
+'upload_source_file' = '(a file on your computer)',
 
 # Special:ListFiles
 'listfiles-summary' = 'This special page shows all uploaded files.

-- 
To view, visit https://gerrit.wikimedia.org/r/56900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3fbe2ed9b2bd7e156cc31055e9c74da3d79240a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: IAlex coderev...@emsenhuber.ch
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits