[MediaWiki-commits] [Gerrit] Remove no longer relevant @todo - change (mediawiki...Flow)

2014-10-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove no longer relevant @todo
..


Remove no longer relevant @todo

Change-Id: I60c9a3283429044f3b37029821367e322864baba
---
M Hooks.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Hooks.php b/Hooks.php
index 888b2de..6a7b9ba 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -277,7 +277,6 @@
/** @var Flow\Formatter\RecentChangesQuery $query */
$query = Container::get( 'query.recentchanges' );
 
-   // @todo: create hook to allow batch-loading this data
$row = $query->getResult( $changesList, $rc, 
$changesList->isWatchlist() );
if ( $row === false ) {
restore_error_handler();

-- 
To view, visit https://gerrit.wikimedia.org/r/167219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60c9a3283429044f3b37029821367e322864baba
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: SG 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove no longer relevant @todo - change (mediawiki...Flow)

2014-10-17 Thread Matthias Mullie (Code Review) 
Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/167219

Change subject: Remove no longer relevant @todo
..

Remove no longer relevant @todo

Change-Id: I60c9a3283429044f3b37029821367e322864baba
---
M Hooks.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/19/167219/1

diff --git a/Hooks.php b/Hooks.php
index 7fad1c6..cf405a5 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -275,7 +275,6 @@
 
$isWatchlist = is_array( $classes ) ? 
$query->isWatchlist( $classes ) : $isWatchlist;
 
-   // @todo: create hook to allow batch-loading this data
$row = $query->getResult( $changesList, $rc, 
$isWatchlist );
if ( $row === false ) {
return false;

-- 
To view, visit https://gerrit.wikimedia.org/r/167219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60c9a3283429044f3b37029821367e322864baba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits