[MediaWiki-commits] [Gerrit] Remove not used interface - change (mediawiki...Wikibase)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/134806 Change subject: Remove not used interface .. Remove not used interface Change-Id: I295e4ef436f3dd236236431d9a7fd37284ffd832 --- M lib/includes/ClaimGuidGenerator.php D lib/includes/GuidGenerator.php M lib/includes/V4GuidGenerator.php 3 files changed, 3 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/06/134806/1 diff --git a/lib/includes/ClaimGuidGenerator.php b/lib/includes/ClaimGuidGenerator.php index 2656a53..1732808 100644 --- a/lib/includes/ClaimGuidGenerator.php +++ b/lib/includes/ClaimGuidGenerator.php @@ -15,10 +15,9 @@ class ClaimGuidGenerator { /** -* @since 0.3 -* @var GuidGenerator +* @var V4GuidGenerator */ - protected $baseGenerator; + private $baseGenerator; /** * @since 0.5 diff --git a/lib/includes/GuidGenerator.php b/lib/includes/GuidGenerator.php deleted file mode 100644 index 3f1a7d7..000 --- a/lib/includes/GuidGenerator.php +++ /dev/null @@ -1,24 +0,0 @@ - - */ -interface GuidGenerator { - - /** -* Generates and returns a Globally Unique Identifier. -* -* @since 0.3 -* -* @return string -*/ - public function newGuid(); - -} diff --git a/lib/includes/V4GuidGenerator.php b/lib/includes/V4GuidGenerator.php index 37aef59..b7fe37a 100644 --- a/lib/includes/V4GuidGenerator.php +++ b/lib/includes/V4GuidGenerator.php @@ -10,7 +10,7 @@ * @licence GNU GPL v2+ * @author Jeroen De Dauw < jeroended...@gmail.com > */ -class V4GuidGenerator implements GuidGenerator { +class V4GuidGenerator { /** * Generates and returns a GUID. -- To view, visit https://gerrit.wikimedia.org/r/134806 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I295e4ef436f3dd236236431d9a7fd37284ffd832 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove not used interface - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Remove not used interface .. Remove not used interface Change-Id: I295e4ef436f3dd236236431d9a7fd37284ffd832 --- M lib/includes/ClaimGuidGenerator.php D lib/includes/GuidGenerator.php M lib/includes/V4GuidGenerator.php 3 files changed, 3 insertions(+), 28 deletions(-) Approvals: Hoo man: Looks good to me, approved WikidataJenkins: Verified jenkins-bot: Verified diff --git a/lib/includes/ClaimGuidGenerator.php b/lib/includes/ClaimGuidGenerator.php index 2656a53..1732808 100644 --- a/lib/includes/ClaimGuidGenerator.php +++ b/lib/includes/ClaimGuidGenerator.php @@ -15,10 +15,9 @@ class ClaimGuidGenerator { /** -* @since 0.3 -* @var GuidGenerator +* @var V4GuidGenerator */ - protected $baseGenerator; + private $baseGenerator; /** * @since 0.5 diff --git a/lib/includes/GuidGenerator.php b/lib/includes/GuidGenerator.php deleted file mode 100644 index 3f1a7d7..000 --- a/lib/includes/GuidGenerator.php +++ /dev/null @@ -1,24 +0,0 @@ - - */ -interface GuidGenerator { - - /** -* Generates and returns a Globally Unique Identifier. -* -* @since 0.3 -* -* @return string -*/ - public function newGuid(); - -} diff --git a/lib/includes/V4GuidGenerator.php b/lib/includes/V4GuidGenerator.php index 37aef59..b7fe37a 100644 --- a/lib/includes/V4GuidGenerator.php +++ b/lib/includes/V4GuidGenerator.php @@ -10,7 +10,7 @@ * @licence GNU GPL v2+ * @author Jeroen De Dauw < jeroended...@gmail.com > */ -class V4GuidGenerator implements GuidGenerator { +class V4GuidGenerator { /** * Generates and returns a GUID. -- To view, visit https://gerrit.wikimedia.org/r/134806 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295e4ef436f3dd236236431d9a7fd37284ffd832 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Hoo man Gerrit-Reviewer: WikidataJenkins Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits