TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/187298

Change subject: Remove superfluos role=text from TextInputWidget
......................................................................

Remove superfluos role=text from TextInputWidget

The wrapped <input> and <textarea> already have native text roles, so
no additional role is required here

Bug: T87830
Change-Id: I710297d38d9b7546c58089db8aa5e39183841843
---
M src/widgets/TextInputWidget.js
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/98/187298/1

diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index 116a354..7f8a501 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -73,7 +73,6 @@
        if ( config.autofocus ) {
                this.$input.attr( 'autofocus', 'autofocus' );
        }
-       this.$element.attr( 'role', 'textbox' );
 };
 
 /* Setup */

-- 
To view, visit https://gerrit.wikimedia.org/r/187298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I710297d38d9b7546c58089db8aa5e39183841843
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to