[MediaWiki-commits] [Gerrit] Remove tests for jquery.delayedBind (deprecated) - change (mediawiki/core)

2014-03-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove tests for jquery.delayedBind (deprecated)
..


Remove tests for jquery.delayedBind (deprecated)

It's slated to be removed and deprecation warnings
are polluting test output.

Change-Id: I880d75874926f0945f9aba72cc176fb6eda6195b
---
M tests/qunit/QUnitTestResources.php
D tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
2 files changed, 0 insertions(+), 38 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/qunit/QUnitTestResources.php 
b/tests/qunit/QUnitTestResources.php
index f674819..33ff2fb 100644
--- a/tests/qunit/QUnitTestResources.php
+++ b/tests/qunit/QUnitTestResources.php
@@ -44,7 +44,6 @@

'tests/qunit/suites/resources/jquery/jquery.client.test.js',

'tests/qunit/suites/resources/jquery/jquery.color.test.js',

'tests/qunit/suites/resources/jquery/jquery.colorUtil.test.js',
-   
'tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js',

'tests/qunit/suites/resources/jquery/jquery.getAttrs.test.js',

'tests/qunit/suites/resources/jquery/jquery.hidpi.test.js',

'tests/qunit/suites/resources/jquery/jquery.highlightText.test.js',
diff --git a/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js 
b/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
deleted file mode 100644
index 234b19c..000
--- a/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
+++ /dev/null
@@ -1,37 +0,0 @@
-( function ( $ ) {
-   QUnit.asyncTest( 'jquery.delayedBind with data option', 2, function ( 
assert ) {
-   var $fixture = $( 'div' ).appendTo( '#qunit-fixture' ),
-   data = {
-   magic: 'beeswax'
-   },
-   delay = 50;
-
-   $fixture.delayedBind( delay, 'testevent', data, function ( e ) {
-   assert.ok( true, 'testevent fired' );
-   assert.ok( e.data === data, 'data is passed through 
delayedBind' );
-   QUnit.start();
-   } );
-
-   // We'll trigger it thrice, but it should only happen once.
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   } );
-
-   QUnit.asyncTest( 'jquery.delayedBind without data option', 1, function 
( assert ) {
-   var $fixture = $( 'div' ).appendTo( '#qunit-fixture' ),
-   delay = 50;
-
-   $fixture.delayedBind( delay, 'testevent', function () {
-   assert.ok( true, 'testevent fired' );
-   QUnit.start();
-   } );
-
-   // We'll trigger it thrice, but it should only happen once.
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   } );
-}( jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/117117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I880d75874926f0945f9aba72cc176fb6eda6195b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove tests for jquery.delayedBind (deprecated) - change (mediawiki/core)

2014-03-05 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117117

Change subject: Remove tests for jquery.delayedBind (deprecated)
..

Remove tests for jquery.delayedBind (deprecated)

Change-Id: I880d75874926f0945f9aba72cc176fb6eda6195b
---
M tests/qunit/QUnitTestResources.php
D tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
2 files changed, 0 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/117117/1

diff --git a/tests/qunit/QUnitTestResources.php 
b/tests/qunit/QUnitTestResources.php
index f674819..33ff2fb 100644
--- a/tests/qunit/QUnitTestResources.php
+++ b/tests/qunit/QUnitTestResources.php
@@ -44,7 +44,6 @@

'tests/qunit/suites/resources/jquery/jquery.client.test.js',

'tests/qunit/suites/resources/jquery/jquery.color.test.js',

'tests/qunit/suites/resources/jquery/jquery.colorUtil.test.js',
-   
'tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js',

'tests/qunit/suites/resources/jquery/jquery.getAttrs.test.js',

'tests/qunit/suites/resources/jquery/jquery.hidpi.test.js',

'tests/qunit/suites/resources/jquery/jquery.highlightText.test.js',
diff --git a/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js 
b/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
deleted file mode 100644
index 234b19c..000
--- a/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
+++ /dev/null
@@ -1,37 +0,0 @@
-( function ( $ ) {
-   QUnit.asyncTest( 'jquery.delayedBind with data option', 2, function ( 
assert ) {
-   var $fixture = $( 'div' ).appendTo( '#qunit-fixture' ),
-   data = {
-   magic: 'beeswax'
-   },
-   delay = 50;
-
-   $fixture.delayedBind( delay, 'testevent', data, function ( e ) {
-   assert.ok( true, 'testevent fired' );
-   assert.ok( e.data === data, 'data is passed through 
delayedBind' );
-   QUnit.start();
-   } );
-
-   // We'll trigger it thrice, but it should only happen once.
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   } );
-
-   QUnit.asyncTest( 'jquery.delayedBind without data option', 1, function 
( assert ) {
-   var $fixture = $( 'div' ).appendTo( '#qunit-fixture' ),
-   delay = 50;
-
-   $fixture.delayedBind( delay, 'testevent', function () {
-   assert.ok( true, 'testevent fired' );
-   QUnit.start();
-   } );
-
-   // We'll trigger it thrice, but it should only happen once.
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   $fixture.trigger( 'testevent', {} );
-   } );
-}( jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/117117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I880d75874926f0945f9aba72cc176fb6eda6195b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits