[MediaWiki-commits] [Gerrit] Remove undeclared dependency on mw.user - change (mediawiki...ImageMetrics)

2015-03-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove undeclared dependency on mw.user
..


Remove undeclared dependency on mw.user

Bug: T93310
Change-Id: I6ab988be43c93780d01077a0b08e627488df8d51
---
M resources/loader.js
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Gilles: Looks good to me, approved
  Bmansurov: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/resources/loader.js b/resources/loader.js
index 521f919..9adc84e 100644
--- a/resources/loader.js
+++ b/resources/loader.js
@@ -30,7 +30,10 @@
 
if ( mw.config.get( 'wgCanonicalNamespace' ) !== 'File' ) {
imageFactor = 0;
-   } else if ( !mw.user.isAnon() && loggedinImageFactor ) {
+   } else if (
+   mw.config.get( 'wgUserName' ) !== null && // same as 
!mw.user.isAnon() - don't require mw.user just for this
+   loggedinImageFactor
+   ) {
imageFactor = loggedinImageFactor;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/198414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab988be43c93780d01077a0b08e627488df8d51
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/ImageMetrics
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Gilles 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove undeclared dependency on mw.user - change (mediawiki...ImageMetrics)

2015-03-20 Thread Code Review 
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/198414

Change subject: Remove undeclared dependency on mw.user
..

Remove undeclared dependency on mw.user

Bug: T93310
Change-Id: I6ab988be43c93780d01077a0b08e627488df8d51
---
M resources/loader.js
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ImageMetrics 
refs/changes/14/198414/1

diff --git a/resources/loader.js b/resources/loader.js
index 521f919..3235e55 100644
--- a/resources/loader.js
+++ b/resources/loader.js
@@ -30,7 +30,10 @@
 
if ( mw.config.get( 'wgCanonicalNamespace' ) !== 'File' ) {
imageFactor = 0;
-   } else if ( !mw.user.isAnon() && loggedinImageFactor ) {
+   } else if (
+   mw.config.get( 'wgUserName' ) === null // same as 
!mw.user.isAnon() - don't require mw.user just for this
+   && loggedinImageFactor
+   ) {
imageFactor = loggedinImageFactor;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/198414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ab988be43c93780d01077a0b08e627488df8d51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ImageMetrics
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits