Robmoen has uploaded a new change for review. https://gerrit.wikimedia.org/r/97735
Change subject: Remove unused badtoken error handling as it is covered in onSaveError ...................................................................... Remove unused badtoken error handling as it is covered in onSaveError Change-Id: If2124c68aab0d313f4ddd698014d2a4296bbabb8 --- M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 0 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/35/97735/1 diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index 0055582..96fee3d 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -69,7 +69,6 @@ 'save': 'onSave', 'loadError': 'onLoadError', 'surfaceReady': 'onSurfaceReady', - 'tokenError': 'onTokenError', 'saveError': 'onSaveError', 'editConflict': 'onEditConflict', 'showChanges': 'onShowChanges', @@ -219,24 +218,6 @@ ve.init.mw.ViewPageTarget.prototype.onLoadError = function ( response, status ) { // Don't show an error if the load was manually aborted if ( status !== 'abort' && confirm( ve.msg( 'visualeditor-loadwarning', status ) ) ) { - this.load(); - } else { - this.activating = false; - // User interface changes - this.deactivate( true ); - } -}; - -/** - * Handle failed token refresh event. - * - * @method - * @param {Object} response Response object - * @param {string} status Text status message - * @param {Mixed} error Thrown exception or HTTP error string - */ -ve.init.mw.ViewPageTarget.prototype.onTokenError = function ( response, status ) { - if ( confirm( ve.msg( 'visualeditor-loadwarning-token', status ) ) ) { this.load(); } else { this.activating = false; -- To view, visit https://gerrit.wikimedia.org/r/97735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2124c68aab0d313f4ddd698014d2a4296bbabb8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen <rm...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits