[MediaWiki-commits] [Gerrit] Removed comma as nick separator for deployment events - change (wikimedia...jouncebot)
Dzahn has submitted this change and it was merged. Change subject: Removed comma as nick separator for deployment events .. Removed comma as nick separator for deployment events Some IRC clients like irssi don't highlight out of the box for nickcomma. We'll so increase the notifications' effectiveness, at the expense of the grammar level. Change-Id: Iadb90d347f0d27c64847bb87da7d57ebd328f432 --- M jouncebot.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/jouncebot.py b/jouncebot.py index 03e07cf..ca7d58a 100755 --- a/jouncebot.py +++ b/jouncebot.py @@ -139,7 +139,7 @@ if len(next_events) 0: for event in next_events: if len(event.owners) 0: -nicks = %s: % (, .join(event.owners)) +nicks = %s: % ( .join(event.owners)) else: nicks = message = random.choice(self.config['messages']) -- To view, visit https://gerrit.wikimedia.org/r/214361 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadb90d347f0d27c64847bb87da7d57ebd328f432 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bots/jouncebot Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org Gerrit-Reviewer: Dzahn dz...@wikimedia.org Gerrit-Reviewer: Yuvipanda yuvipa...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed comma as nick separator for deployment events - change (wikimedia...jouncebot)
Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/214361 Change subject: Removed comma as nick separator for deployment events .. Removed comma as nick separator for deployment events Some IRC clients like irssi don't highlight out of the box for nickcomma. We'll so increase the notifications' effectiveness, at the expense of the grammar level. Change-Id: Iadb90d347f0d27c64847bb87da7d57ebd328f432 --- M jouncebot.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bots/jouncebot refs/changes/61/214361/1 diff --git a/jouncebot.py b/jouncebot.py index 03e07cf..ca7d58a 100755 --- a/jouncebot.py +++ b/jouncebot.py @@ -139,7 +139,7 @@ if len(next_events) 0: for event in next_events: if len(event.owners) 0: -nicks = %s: % (, .join(event.owners)) +nicks = %s: % ( .join(event.owners)) else: nicks = message = random.choice(self.config['messages']) -- To view, visit https://gerrit.wikimedia.org/r/214361 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iadb90d347f0d27c64847bb87da7d57ebd328f432 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bots/jouncebot Gerrit-Branch: master Gerrit-Owner: Dereckson dereck...@espace-win.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
