[MediaWiki-commits] [Gerrit] Rename getSiteLinkTable to getSiteLinkLookup - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177194

Change subject: Rename getSiteLinkTable to getSiteLinkLookup
..

Rename getSiteLinkTable to getSiteLinkLookup

Looks like the interface was introduced later and that's why the
getter is called after the sub class instead of the interface.

Change-Id: Ib41e33e8306ac4cdf7d82342a5b72784c08405b3
---
M client/WikibaseClient.hooks.php
M client/includes/WikibaseClient.php
M client/includes/hooks/UpdateRepoHookHandlers.php
M client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
M client/includes/store/ClientStore.php
M client/includes/store/sql/DirectSqlStore.php
M client/tests/phpunit/MockClientStore.php
M client/tests/phpunit/includes/store/sql/DirectSqlStoreTest.php
8 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/94/177194/1

diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index ad9078e..a10073f 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -174,7 +174,7 @@
public static function onSpecialMovepageAfterMove( MovePageForm 
$movePage, Title $oldTitle,
Title $newTitle ) {
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
$repoLinker = $wikibaseClient-newRepoLinker();
 
$movePageNotice = new MovePageNoticeCreator(
@@ -377,7 +377,7 @@
}
 
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
return $siteLinkLookup-getEntityIdForSiteLink(
new SiteLink(
$wikibaseClient-getSite()-getGlobalId(),
@@ -672,7 +672,7 @@
$infoActionHookHandler = new InfoActionHookHandler(
$namespaceChecker,
$wikibaseClient-newRepoLinker(),
-   $wikibaseClient-getStore()-getSiteLinkTable(),
+   $wikibaseClient-getStore()-getSiteLinkLookup(),
$settings-getSetting( 'siteGlobalID' )
);
 
@@ -692,7 +692,7 @@
 */
public static function onArticleDeleteAfterSuccess( Title $title, 
OutputPage $out ) {
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
$repoLinker = $wikibaseClient-newRepoLinker();
 
$deletePageNotice = new DeletePageNoticeCreator(
diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index 7ed0f92..1a0f182 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -536,7 +536,7 @@
$this-getLanguageLinkBadgeDisplay(),
$this-settings-getSetting( 'siteGlobalID' ),
$this-getNamespaceChecker(),
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-getStore()-getEntityLookup(),
$this-getSiteStore()-getSites(),
$this-getLangLinkSiteGroup()
@@ -645,7 +645,7 @@
public function getOtherProjectsSidebarGeneratorFactory() {
return new OtherProjectsSidebarGeneratorFactory(
$this-settings,
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-getSiteStore()
);
}
@@ -704,7 +704,7 @@
public function getPropertyParserFunctionRunner() {
return new Runner(
$this-getPropertyClaimsRendererFactory(),
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-settings-getSetting( 'siteGlobalID' )
);
}
diff --git a/client/includes/hooks/UpdateRepoHookHandlers.php 
b/client/includes/hooks/UpdateRepoHookHandlers.php
index 45566a2..e609901 100644
--- a/client/includes/hooks/UpdateRepoHookHandlers.php
+++ b/client/includes/hooks/UpdateRepoHookHandlers.php
@@ -75,7 +75,7 @@
return true;
}
 
-   $siteLinkLookup =

[MediaWiki-commits] [Gerrit] Rename getSiteLinkTable to getSiteLinkLookup - change (mediawiki...Wikibase)

2014-12-03 Thread Daniel Kinzler (Code Review) 
Daniel Kinzler has submitted this change and it was merged.

Change subject: Rename getSiteLinkTable to getSiteLinkLookup
..


Rename getSiteLinkTable to getSiteLinkLookup

Looks like the interface was introduced later and that's why the
getter is called after the sub class instead of the interface.

Change-Id: Ib41e33e8306ac4cdf7d82342a5b72784c08405b3
---
M client/WikibaseClient.hooks.php
M client/includes/WikibaseClient.php
M client/includes/hooks/UpdateRepoHookHandlers.php
M client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
M client/includes/store/ClientStore.php
M client/includes/store/sql/DirectSqlStore.php
M client/tests/phpunit/MockClientStore.php
M client/tests/phpunit/includes/store/sql/DirectSqlStoreTest.php
8 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index ad9078e..a10073f 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -174,7 +174,7 @@
public static function onSpecialMovepageAfterMove( MovePageForm 
$movePage, Title $oldTitle,
Title $newTitle ) {
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
$repoLinker = $wikibaseClient-newRepoLinker();
 
$movePageNotice = new MovePageNoticeCreator(
@@ -377,7 +377,7 @@
}
 
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
return $siteLinkLookup-getEntityIdForSiteLink(
new SiteLink(
$wikibaseClient-getSite()-getGlobalId(),
@@ -672,7 +672,7 @@
$infoActionHookHandler = new InfoActionHookHandler(
$namespaceChecker,
$wikibaseClient-newRepoLinker(),
-   $wikibaseClient-getStore()-getSiteLinkTable(),
+   $wikibaseClient-getStore()-getSiteLinkLookup(),
$settings-getSetting( 'siteGlobalID' )
);
 
@@ -692,7 +692,7 @@
 */
public static function onArticleDeleteAfterSuccess( Title $title, 
OutputPage $out ) {
$wikibaseClient = WikibaseClient::getDefaultInstance();
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkLookup();
$repoLinker = $wikibaseClient-newRepoLinker();
 
$deletePageNotice = new DeletePageNoticeCreator(
diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index d3cb261..f3163ca 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -539,7 +539,7 @@
$this-getLanguageLinkBadgeDisplay(),
$this-settings-getSetting( 'siteGlobalID' ),
$this-getNamespaceChecker(),
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-getStore()-getEntityLookup(),
$this-getSiteStore()-getSites(),
$this-getLangLinkSiteGroup()
@@ -649,7 +649,7 @@
public function getOtherProjectsSidebarGeneratorFactory() {
return new OtherProjectsSidebarGeneratorFactory(
$this-settings,
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-getSiteStore()
);
}
@@ -708,7 +708,7 @@
public function getPropertyParserFunctionRunner() {
return new Runner(
$this-getPropertyClaimsRendererFactory(),
-   $this-getStore()-getSiteLinkTable(),
+   $this-getStore()-getSiteLinkLookup(),
$this-settings-getSetting( 'siteGlobalID' )
);
}
diff --git a/client/includes/hooks/UpdateRepoHookHandlers.php 
b/client/includes/hooks/UpdateRepoHookHandlers.php
index 45566a2..e609901 100644
--- a/client/includes/hooks/UpdateRepoHookHandlers.php
+++ b/client/includes/hooks/UpdateRepoHookHandlers.php
@@ -75,7 +75,7 @@
return true;
}
 
-   $siteLinkLookup = 
$wikibaseClient-getStore()-getSiteLinkTable();
+   $siteLinkLookup =