[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...ApiFeatureUsage)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I0340cd8687d097867f7278428f3f2e0129c1ba10
---
M ApiFeatureUsage.php
M SpecialApiFeatureUsage.php
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ApiFeatureUsage.php b/ApiFeatureUsage.php
index feac398..fb77678 100644
--- a/ApiFeatureUsage.php
+++ b/ApiFeatureUsage.php
@@ -40,7 +40,6 @@
 $wgMessagesDirs['ApiFeatureUsage'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['ApiFeatureUsageAlias'] = __DIR__ . 
'/ApiFeatureUsage.alias.php';
 $wgSpecialPages['ApiFeatureUsage'] = 'SpecialApiFeatureUsage';
-$wgSpecialPageGroups['ApiFeatureUsage'] = 'wiki';
 $wgAPIMetaModules['featureusage'] = 'ApiQueryFeatureUsage';
 $wgConfigRegistry['ApiFeatureUsage'] = 'GlobalVarConfig::newInstance';
 
diff --git a/SpecialApiFeatureUsage.php b/SpecialApiFeatureUsage.php
index 2970bd5..c6aa923 100644
--- a/SpecialApiFeatureUsage.php
+++ b/SpecialApiFeatureUsage.php
@@ -125,4 +125,7 @@
return $this->engine->execute( $agent, $start, $end );
}
 
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0340cd8687d097867f7278428f3f2e0129c1ba10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiFeatureUsage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...ApiFeatureUsage)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211366

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I0340cd8687d097867f7278428f3f2e0129c1ba10
---
M ApiFeatureUsage.php
M SpecialApiFeatureUsage.php
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApiFeatureUsage 
refs/changes/66/211366/1

diff --git a/ApiFeatureUsage.php b/ApiFeatureUsage.php
index feac398..fb77678 100644
--- a/ApiFeatureUsage.php
+++ b/ApiFeatureUsage.php
@@ -40,7 +40,6 @@
 $wgMessagesDirs['ApiFeatureUsage'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['ApiFeatureUsageAlias'] = __DIR__ . 
'/ApiFeatureUsage.alias.php';
 $wgSpecialPages['ApiFeatureUsage'] = 'SpecialApiFeatureUsage';
-$wgSpecialPageGroups['ApiFeatureUsage'] = 'wiki';
 $wgAPIMetaModules['featureusage'] = 'ApiQueryFeatureUsage';
 $wgConfigRegistry['ApiFeatureUsage'] = 'GlobalVarConfig::newInstance';
 
diff --git a/SpecialApiFeatureUsage.php b/SpecialApiFeatureUsage.php
index 2970bd5..c6aa923 100644
--- a/SpecialApiFeatureUsage.php
+++ b/SpecialApiFeatureUsage.php
@@ -125,4 +125,7 @@
return $this->engine->execute( $agent, $start, $end );
}
 
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0340cd8687d097867f7278428f3f2e0129c1ba10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiFeatureUsage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits