[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...CentralNotice)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I355ace367c7a744677b404c30e077cb3408ebca2
---
M CentralNotice.hooks.php
M special/SpecialCentralNotice.php
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 60fb03a..240da9e 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -36,7 +36,7 @@
  */
 function efCentralNoticeSetup() {
global $wgHooks, $wgNoticeInfrastructure, $wgAutoloadClasses, 
$wgSpecialPages,
-  $wgCentralNoticeLoader, $wgSpecialPageGroups, $wgScript,
+  $wgCentralNoticeLoader, $wgScript,
   $wgNoticeUseTranslateExtension, $wgAPIModules, 
$wgAPIListModules,
   $wgAvailableRights, $wgGroupPermissions, $wgCentralDBname, 
$wgDBname;
 
@@ -154,7 +154,6 @@
}
 
$wgSpecialPages[ 'CentralNotice' ] = 'CentralNotice';
-   $wgSpecialPageGroups[ 'CentralNotice' ] = 'wiki'; // Wiki data 
and tools
$wgSpecialPages[ 'NoticeTemplate' ] = 'SpecialNoticeTemplate';
$wgSpecialPages[ 'GlobalAllocation' ] = 
'SpecialGlobalAllocation';
$wgSpecialPages[ 'BannerAllocation' ] = 
'SpecialBannerAllocation';
diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index c25584d..94a9022 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -1484,4 +1484,8 @@
}
return $this-getContext()-getLanguage()-listToText( 
array_values( $list ) );
}
+
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I355ace367c7a744677b404c30e077cb3408ebca2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de
Gerrit-Reviewer: Awight awi...@wikimedia.org
Gerrit-Reviewer: Ejegg eeggles...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Ssmith ssm...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...CentralNotice)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211387

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I355ace367c7a744677b404c30e077cb3408ebca2
---
M CentralNotice.hooks.php
M special/SpecialCentralNotice.php
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/87/211387/1

diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 60fb03a..240da9e 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -36,7 +36,7 @@
  */
 function efCentralNoticeSetup() {
global $wgHooks, $wgNoticeInfrastructure, $wgAutoloadClasses, 
$wgSpecialPages,
-  $wgCentralNoticeLoader, $wgSpecialPageGroups, $wgScript,
+  $wgCentralNoticeLoader, $wgScript,
   $wgNoticeUseTranslateExtension, $wgAPIModules, 
$wgAPIListModules,
   $wgAvailableRights, $wgGroupPermissions, $wgCentralDBname, 
$wgDBname;
 
@@ -154,7 +154,6 @@
}
 
$wgSpecialPages[ 'CentralNotice' ] = 'CentralNotice';
-   $wgSpecialPageGroups[ 'CentralNotice' ] = 'wiki'; // Wiki data 
and tools
$wgSpecialPages[ 'NoticeTemplate' ] = 'SpecialNoticeTemplate';
$wgSpecialPages[ 'GlobalAllocation' ] = 
'SpecialGlobalAllocation';
$wgSpecialPages[ 'BannerAllocation' ] = 
'SpecialBannerAllocation';
diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index c25584d..94a9022 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -1484,4 +1484,8 @@
}
return $this-getContext()-getLanguage()-listToText( 
array_values( $list ) );
}
+
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I355ace367c7a744677b404c30e077cb3408ebca2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits