[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...GlobalContributions)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Min version on mw.org is 1.23

Change-Id: I18de171b5a9750ed3e04b76660e07d2780d5a4b3
---
M GlobalContributions.php
M SpecialGlobalContributions.php
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/GlobalContributions.php b/GlobalContributions.php
index 7a44453..91c2a10 100644
--- a/GlobalContributions.php
+++ b/GlobalContributions.php
@@ -36,7 +36,6 @@
 $wgAutoloadClasses['SpecialGlobalContributions'] = __DIR__ . 
'/SpecialGlobalContributions.php';
 
 $wgSpecialPages['GlobalContributions'] = 'SpecialGlobalContributions';
-$wgSpecialPageGroups['GlobalContributions'] = 'users';
 $wgMessagesDirs['GlobalContributions'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['GlobalContributions'] = __DIR__ . 
'/GlobalContributions.i18n.php';
 $wgExtensionMessagesFiles['GlobalContributionsAlias'] = __DIR__ . 
'/GlobalContributions.alias.php';
diff --git a/SpecialGlobalContributions.php b/SpecialGlobalContributions.php
index 13203a1..9ac7b27 100644
--- a/SpecialGlobalContributions.php
+++ b/SpecialGlobalContributions.php
@@ -55,5 +55,7 @@
return true;
}
 
-
+   protected function getGroupName() {
+   return 'users';
+   }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/211420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18de171b5a9750ed3e04b76660e07d2780d5a4b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalContributions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...GlobalContributions)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211420

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Min version on mw.org is 1.23

Change-Id: I18de171b5a9750ed3e04b76660e07d2780d5a4b3
---
M GlobalContributions.php
M SpecialGlobalContributions.php
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalContributions 
refs/changes/20/211420/1

diff --git a/GlobalContributions.php b/GlobalContributions.php
index 7a44453..91c2a10 100644
--- a/GlobalContributions.php
+++ b/GlobalContributions.php
@@ -36,7 +36,6 @@
 $wgAutoloadClasses['SpecialGlobalContributions'] = __DIR__ . 
'/SpecialGlobalContributions.php';
 
 $wgSpecialPages['GlobalContributions'] = 'SpecialGlobalContributions';
-$wgSpecialPageGroups['GlobalContributions'] = 'users';
 $wgMessagesDirs['GlobalContributions'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['GlobalContributions'] = __DIR__ . 
'/GlobalContributions.i18n.php';
 $wgExtensionMessagesFiles['GlobalContributionsAlias'] = __DIR__ . 
'/GlobalContributions.alias.php';
diff --git a/SpecialGlobalContributions.php b/SpecialGlobalContributions.php
index 13203a1..9ac7b27 100644
--- a/SpecialGlobalContributions.php
+++ b/SpecialGlobalContributions.php
@@ -55,5 +55,7 @@
return true;
}
 
-
+   protected function getGroupName() {
+   return 'users';
+   }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/211420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18de171b5a9750ed3e04b76660e07d2780d5a4b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalContributions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits