[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...MaintenanceShell)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Min version on mw.org is 1.21

Change-Id: I47ac713cd4d161793aa0957f9515b75b8e0a0adc
---
M MaintenanceShell.php
M includes/SpecialMaintenanceShell.php
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MaintenanceShell.php b/MaintenanceShell.php
index 443cde7..02b5666 100644
--- a/MaintenanceShell.php
+++ b/MaintenanceShell.php
@@ -35,7 +35,6 @@
 
 // Register special pages
 $wgSpecialPages['MaintenanceShell'] = 'SpecialMaintenanceShell';
-$wgSpecialPageGroups['MaintenanceShell'] = 'wiki';
 
 // Register user rights
 $wgAvailableRights[] = 'maintenanceshell';
diff --git a/includes/SpecialMaintenanceShell.php 
b/includes/SpecialMaintenanceShell.php
index c22dd06..5c43c45 100644
--- a/includes/SpecialMaintenanceShell.php
+++ b/includes/SpecialMaintenanceShell.php
@@ -174,4 +174,8 @@
// If the script doesn't explictly exit, we'll exit anyway
exit;
}
+
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I47ac713cd4d161793aa0957f9515b75b8e0a0adc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MaintenanceShell
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...MaintenanceShell)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211423

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Min version on mw.org is 1.21

Change-Id: I47ac713cd4d161793aa0957f9515b75b8e0a0adc
---
M MaintenanceShell.php
M includes/SpecialMaintenanceShell.php
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MaintenanceShell 
refs/changes/23/211423/1

diff --git a/MaintenanceShell.php b/MaintenanceShell.php
index 443cde7..02b5666 100644
--- a/MaintenanceShell.php
+++ b/MaintenanceShell.php
@@ -35,7 +35,6 @@
 
 // Register special pages
 $wgSpecialPages['MaintenanceShell'] = 'SpecialMaintenanceShell';
-$wgSpecialPageGroups['MaintenanceShell'] = 'wiki';
 
 // Register user rights
 $wgAvailableRights[] = 'maintenanceshell';
diff --git a/includes/SpecialMaintenanceShell.php 
b/includes/SpecialMaintenanceShell.php
index c22dd06..5c43c45 100644
--- a/includes/SpecialMaintenanceShell.php
+++ b/includes/SpecialMaintenanceShell.php
@@ -174,4 +174,8 @@
// If the script doesn't explictly exit, we'll exit anyway
exit;
}
+
+   protected function getGroupName() {
+   return 'wiki';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47ac713cd4d161793aa0957f9515b75b8e0a0adc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MaintenanceShell
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits