[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...Math)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I7540d2d607caba45ce311b0dafa2a6642412c57f
---
M Math.php
M SpecialMathShowImage.php
M SpecialMathStatus.php
3 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Polybuildr: Looks good to me, but someone else must approve
  Physikerwelt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Math.php b/Math.php
index 3f45333..746f0b1 100644
--- a/Math.php
+++ b/Math.php
@@ -238,8 +238,6 @@
 
 $wgParserTestFiles[] = $dir . 'mathParserTests.txt';
 
-$wgSpecialPageGroups[ 'MathShowImage' ] = 'other';
-$wgSpecialPageGroups[ 'MathStatus' ] = 'other';
 $wgSpecialPages['MathShowImage'] = 'SpecialMathShowImage';
 $wgSpecialPages['MathStatus'] = 'SpecialMathStatus';
 
diff --git a/SpecialMathShowImage.php b/SpecialMathShowImage.php
index 3b57c40..154e40d 100644
--- a/SpecialMathShowImage.php
+++ b/SpecialMathShowImage.php
@@ -129,4 +129,7 @@
return $result;
}
 
+   protected function getGroupName() {
+   return 'other';
+   }
 }
diff --git a/SpecialMathStatus.php b/SpecialMathStatus.php
index 488500e..74bc8da 100644
--- a/SpecialMathStatus.php
+++ b/SpecialMathStatus.php
@@ -138,4 +138,8 @@
private function assertEquals( $expected, $real, $message = '' ) {
$this-assertTrue( $expected == $real, $message );
}
+
+   protected function getGroupName() {
+   return 'other';
+   }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/211379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7540d2d607caba45ce311b0dafa2a6642412c57f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de
Gerrit-Reviewer: Physikerwelt w...@physikerwelt.de
Gerrit-Reviewer: Polybuildr v.a.ghai...@gmail.com
Gerrit-Reviewer: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...Math)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211379

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I7540d2d607caba45ce311b0dafa2a6642412c57f
---
M Math.php
M SpecialMathShowImage.php
M SpecialMathStatus.php
3 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math 
refs/changes/79/211379/1

diff --git a/Math.php b/Math.php
index 3f45333..746f0b1 100644
--- a/Math.php
+++ b/Math.php
@@ -238,8 +238,6 @@
 
 $wgParserTestFiles[] = $dir . 'mathParserTests.txt';
 
-$wgSpecialPageGroups[ 'MathShowImage' ] = 'other';
-$wgSpecialPageGroups[ 'MathStatus' ] = 'other';
 $wgSpecialPages['MathShowImage'] = 'SpecialMathShowImage';
 $wgSpecialPages['MathStatus'] = 'SpecialMathStatus';
 
diff --git a/SpecialMathShowImage.php b/SpecialMathShowImage.php
index 3b57c40..154e40d 100644
--- a/SpecialMathShowImage.php
+++ b/SpecialMathShowImage.php
@@ -129,4 +129,7 @@
return $result;
}
 
+   protected function getGroupName() {
+   return 'other';
+   }
 }
diff --git a/SpecialMathStatus.php b/SpecialMathStatus.php
index 488500e..74bc8da 100644
--- a/SpecialMathStatus.php
+++ b/SpecialMathStatus.php
@@ -138,4 +138,8 @@
private function assertEquals( $expected, $real, $message = '' ) {
$this-assertTrue( $expected == $real, $message );
}
+
+   protected function getGroupName() {
+   return 'other';
+   }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/211379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7540d2d607caba45ce311b0dafa2a6642412c57f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Umherirrender umherirrender_de...@web.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits