[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...ProofreadPage)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: Id79f960c274b582f4be0ece4ab862975f4c0d094
---
M ProofreadPage.php
M SpecialPagesWithoutScans.php
M SpecialProofreadPages.php
3 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ProofreadPage.php b/ProofreadPage.php
index cd9510c..a53de7d 100644
--- a/ProofreadPage.php
+++ b/ProofreadPage.php
@@ -114,12 +114,10 @@
 # special page
 $wgAutoloadClasses['ProofreadPages'] = $dir . 'SpecialProofreadPages.php';
 $wgSpecialPages['IndexPages'] = 'ProofreadPages';
-$wgSpecialPageGroups['IndexPages'] = 'pages';
 
 # special page
 $wgAutoloadClasses['PagesWithoutScans'] = $dir . 
'SpecialPagesWithoutScans.php';
 $wgSpecialPages['PagesWithoutScans'] = 'PagesWithoutScans';
-$wgSpecialPageGroups['PagesWithoutScans'] = 'maintenance';
 
 # api prop
 $wgAutoloadClasses['ApiQueryProofread'] = $dir . 'ApiQueryProofread.php';
diff --git a/SpecialPagesWithoutScans.php b/SpecialPagesWithoutScans.php
index 308ced5..a1a42b9 100644
--- a/SpecialPagesWithoutScans.php
+++ b/SpecialPagesWithoutScans.php
@@ -146,4 +146,8 @@
? "({$hlink}) {$dm}{$plink} {$dm}[{$size}]"
: "({$hlink}) {$dm}{$plink} 
{$dm}[{$size}]";
}
+
+   protected function getGroupName() {
+   return 'maintenance';
+   }
 }
diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index 892b9f4..e5bb538 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -223,4 +223,8 @@
 
return $output;
}
+
+   protected function getGroupName() {
+   return 'pages';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id79f960c274b582f4be0ece4ab862975f4c0d094
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...ProofreadPage)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211377

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: Id79f960c274b582f4be0ece4ab862975f4c0d094
---
M ProofreadPage.php
M SpecialPagesWithoutScans.php
M SpecialProofreadPages.php
3 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/77/211377/1

diff --git a/ProofreadPage.php b/ProofreadPage.php
index cd9510c..a53de7d 100644
--- a/ProofreadPage.php
+++ b/ProofreadPage.php
@@ -114,12 +114,10 @@
 # special page
 $wgAutoloadClasses['ProofreadPages'] = $dir . 'SpecialProofreadPages.php';
 $wgSpecialPages['IndexPages'] = 'ProofreadPages';
-$wgSpecialPageGroups['IndexPages'] = 'pages';
 
 # special page
 $wgAutoloadClasses['PagesWithoutScans'] = $dir . 
'SpecialPagesWithoutScans.php';
 $wgSpecialPages['PagesWithoutScans'] = 'PagesWithoutScans';
-$wgSpecialPageGroups['PagesWithoutScans'] = 'maintenance';
 
 # api prop
 $wgAutoloadClasses['ApiQueryProofread'] = $dir . 'ApiQueryProofread.php';
diff --git a/SpecialPagesWithoutScans.php b/SpecialPagesWithoutScans.php
index 308ced5..a1a42b9 100644
--- a/SpecialPagesWithoutScans.php
+++ b/SpecialPagesWithoutScans.php
@@ -146,4 +146,8 @@
? "({$hlink}) {$dm}{$plink} {$dm}[{$size}]"
: "({$hlink}) {$dm}{$plink} 
{$dm}[{$size}]";
}
+
+   protected function getGroupName() {
+   return 'maintenance';
+   }
 }
diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index 892b9f4..e5bb538 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -223,4 +223,8 @@
 
return $output;
}
+
+   protected function getGroupName() {
+   return 'pages';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id79f960c274b582f4be0ece4ab862975f4c0d094
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits