[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...TimedMediaHandler)

2015-05-16 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I9030d59f568927020300e33a91822cfdd51c4943
---
M SpecialTimedMediaHandler.php
M TimedMediaHandler.php
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php
index caab754..0808b18 100644
--- a/SpecialTimedMediaHandler.php
+++ b/SpecialTimedMediaHandler.php
@@ -228,4 +228,8 @@
}
return $states;
}
+
+   protected function getGroupName() {
+   return 'media';
+   }
 }
diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index ec45d18..f405176 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -259,7 +259,6 @@
 # add Special pages
 $wgSpecialPages['OrphanedTimedText'] = 'SpecialOrphanedTimedText';
 $wgSpecialPages['TimedMediaHandler'] = 'SpecialTimedMediaHandler';
-$wgSpecialPageGroups['TimedMediaHandler'] = 'media';
 
 // Extension Credits
 $wgExtensionCredits['media'][] = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/211378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9030d59f568927020300e33a91822cfdd51c4943
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...TimedMediaHandler)

2015-05-16 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211378

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I9030d59f568927020300e33a91822cfdd51c4943
---
M SpecialTimedMediaHandler.php
M TimedMediaHandler.php
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/78/211378/1

diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php
index caab754..0808b18 100644
--- a/SpecialTimedMediaHandler.php
+++ b/SpecialTimedMediaHandler.php
@@ -228,4 +228,8 @@
}
return $states;
}
+
+   protected function getGroupName() {
+   return 'media';
+   }
 }
diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index ec45d18..f405176 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -259,7 +259,6 @@
 # add Special pages
 $wgSpecialPages['OrphanedTimedText'] = 'SpecialOrphanedTimedText';
 $wgSpecialPages['TimedMediaHandler'] = 'SpecialTimedMediaHandler';
-$wgSpecialPageGroups['TimedMediaHandler'] = 'media';
 
 // Extension Credits
 $wgExtensionCredits['media'][] = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/211378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9030d59f568927020300e33a91822cfdd51c4943
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits