[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...WikibaseQuery)

2015-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated $wgSpecialPageGroups
..


Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I58c05a517f23fa72cbc40af76e27471bcec24a52
---
M src/Setup/ExtensionSetup.php
M src/Specials/SimpleQuery.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/Setup/ExtensionSetup.php b/src/Setup/ExtensionSetup.php
index 53601a8..a922166 100644
--- a/src/Setup/ExtensionSetup.php
+++ b/src/Setup/ExtensionSetup.php
@@ -77,9 +77,6 @@
private function registerSpecialPages() {
// Special page registration
$this->globalVars['wgSpecialPages']['SimpleQuery'] = 
'Wikibase\Query\Specials\SimpleQuery';
-
-   // Special page groups
-   $this->globalVars['wgSpecialPageGroups']['SimpleQuery'] = 
'wikibaserepo';
}
 
private function registerPermissions() {
diff --git a/src/Specials/SimpleQuery.php b/src/Specials/SimpleQuery.php
index 610191a..b4cc19c 100644
--- a/src/Specials/SimpleQuery.php
+++ b/src/Specials/SimpleQuery.php
@@ -87,4 +87,7 @@
return $entityIds;
}
 
+   protected function getGroupName() {
+   return 'wikibaserepo';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58c05a517f23fa72cbc40af76e27471bcec24a52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuery
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace deprecated $wgSpecialPageGroups - change (mediawiki...WikibaseQuery)

2015-05-16 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/211368

Change subject: Replace deprecated $wgSpecialPageGroups
..

Replace deprecated $wgSpecialPageGroups

$wgSpecialPageGroups is deprecated since 1.21
override SpecialPage::getGroupName instead

Change-Id: I58c05a517f23fa72cbc40af76e27471bcec24a52
---
M src/Setup/ExtensionSetup.php
M src/Specials/SimpleQuery.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQuery 
refs/changes/68/211368/1

diff --git a/src/Setup/ExtensionSetup.php b/src/Setup/ExtensionSetup.php
index 53601a8..a922166 100644
--- a/src/Setup/ExtensionSetup.php
+++ b/src/Setup/ExtensionSetup.php
@@ -77,9 +77,6 @@
private function registerSpecialPages() {
// Special page registration
$this->globalVars['wgSpecialPages']['SimpleQuery'] = 
'Wikibase\Query\Specials\SimpleQuery';
-
-   // Special page groups
-   $this->globalVars['wgSpecialPageGroups']['SimpleQuery'] = 
'wikibaserepo';
}
 
private function registerPermissions() {
diff --git a/src/Specials/SimpleQuery.php b/src/Specials/SimpleQuery.php
index 610191a..b4cc19c 100644
--- a/src/Specials/SimpleQuery.php
+++ b/src/Specials/SimpleQuery.php
@@ -87,4 +87,7 @@
return $entityIds;
}
 
+   protected function getGroupName() {
+   return 'wikibaserepo';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/211368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58c05a517f23fa72cbc40af76e27471bcec24a52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuery
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits