[MediaWiki-commits] [Gerrit] Replace erroneously removed cite styles - change (apps...wikipedia)
jenkins-bot has submitted this change and it was merged.
Change subject: Replace erroneously removed cite styles
..
Replace erroneously removed cite styles
Generating these requires the 'cite' role in mw-vagrant, which I didn't
have before (leading to an error generating the CSS).
Thus, I removed the reference from the CSS generation script.
This puts back the needed styles. I'll update the mobileapp role in a
follow-up patch to require the cite role.
Bug: T132253
Change-Id: I7a9c8ef804301bc81932886a2aec74fe96ba3f84
---
M app/src/main/assets/preview.css
M app/src/main/assets/styles.css
M scripts/make-css-assets.bash
3 files changed, 166 insertions(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/assets/preview.css b/app/src/main/assets/preview.css
index 8c85468..84e0395 100644
--- a/app/src/main/assets/preview.css
+++ b/app/src/main/assets/preview.css
@@ -467,6 +467,88 @@
display: block !important;
width: auto !important;
}
+}/* CSS for Parsoid Cite extension */
+
+/* Style for s */
+span.mw-ref {
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+ /* Make sure the brackets and the numbers aren't jumbled after LTR
words in RTL wikis */
+ unicode-bidi: embed;
+}
+
+/* With a group set */
+span.mw-ref a[data-mw-group]::after {
+ content: "[" attr(data-mw-group) " " counter(mw-Ref, decimal) "]"}
+
+/* Groups with special appearance */
+span.mw-ref a[data-mw-group="decimal"]::after {
+ content: "[" counter(mw-Ref, decimal) "]";
+}
+span.mw-ref a[data-mw-group="lower-alpha"]::after {
+ content: "[" counter(mw-Ref, lower-alpha) "]";
+}
+span.mw-ref a[data-mw-group="upper-alpha"]::after {
+ content: "[" counter(mw-Ref, upper-alpha) "]";
+}
+span.mw-ref a[data-mw-group="lower-greek"]::after {
+ content: "[" counter(mw-Ref, lower-greek) "]";
+}
+span.mw-ref a[data-mw-group="lower-roman"]::after {
+ content: "[" counter(mw-Ref, lower-roman) "]";
+}
+span.mw-ref a[data-mw-group="upper-roman"]::after {
+ content: "[" counter(mw-Ref, upper-roman) "]";
+}
+span.mw-ref a[data-mw-group="error-test"]::after {
+ content: "[" counter(mw-Ref, symbols(cyclic "first" "second" "last!"))
"]";
+}
+
+/* Without a group */
+span.mw-ref a::after {
+ content: "[" counter(mw-Ref, decimal) "]";
+}
+
+/* Hide the default rendering in browsers that support content
+ * generation by selecting for ::after pseudo-element.*/
+x-thereisnoelementwiththisname::after, span.mw-reflink-text {
+ display: none;
+}
+
+/* Style for linkbacks from to s */
+ol.mw-references {
+ counter-reset: mw-ref-linkback;
+}
+
+ol.mw-references li {
+ counter-increment: mw-ref-linkback;
+}
+
+[rel="mw:referencedBy"] {
+ counter-reset: mw-ref-linkback -1;
+}
+
+[rel="mw:referencedBy"]::before {
+ content: "↑ ";
+}
+
+span[rel="mw:referencedBy"] a::before {
+ counter-increment: mw-ref-linkback;
+ content: counters(mw-ref-linkback, ".", decimal);
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+}
+
+span[rel="mw:referencedBy"] a::after {
+ content: " ";
+}
+
+/* Hide the default rendering in browsers that support content
+ * generation by selecting for ::after pseudo-element.*/
+x-thereisnoelementwiththisname[rel="mw:referencedBy"]::before,
span.mw-linkback-text {
+ display: none;
}/* Hide the stupid editlink */
.edit-page {
display: none;
diff --git a/app/src/main/assets/styles.css b/app/src/main/assets/styles.css
index ad191a6..e29697a 100644
--- a/app/src/main/assets/styles.css
+++ b/app/src/main/assets/styles.css
@@ -467,6 +467,88 @@
display: block !important;
width: auto !important;
}
+}/* CSS for Parsoid Cite extension */
+
+/* Style for s */
+span.mw-ref {
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+ /* Make sure the brackets and the numbers aren't jumbled after LTR
words in RTL wikis */
+ unicode-bidi: embed;
+}
+
+/* With a group set */
+span.mw-ref a[data-mw-group]::after {
+ content: "[" attr(data-mw-group) " " counter(mw-Ref, decimal) "]"}
+
+/* Groups with special appearance */
+span.mw-ref a[data-mw-group="decimal"]::after {
+ content: "[" counter(mw-Ref, decimal) "]";
+}
+span.mw-ref a[data-mw-group="lower-alpha"]::after {
+ content: "[" counter(mw-Ref, lower-alpha) "]";
+}
+span.mw-ref a[data-mw-group="upper-alpha"]::after {
+ content: "[" counter(mw-Ref, upper-alpha) "]";
+}
+span.mw-ref a[data-mw-group="lower-greek"]::after {
+ content: "[" counter(mw-Ref, lower-greek) "]";
+}
+span.mw-ref a[data-mw-group="lower-roman"]::after {
+ content: "[" counter(mw-Ref, lower-roman) "]";
+}
+span.mw-ref a[data-mw-group="upper-roman"]::after {
+ content: "[" counter(mw-Ref, upper-roman) "]";
+}
+span.mw-ref
[MediaWiki-commits] [Gerrit] Replace erroneously removed cite styles - change (apps...wikipedia)
Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282483
Change subject: Replace erroneously removed cite styles
..
Replace erroneously removed cite styles
Generating these requires the 'cite' role in mw-vagrant, which I didn't
have before (leading to an error generating the CSS).
Thus, I removed the reference from the CSS generation script.
This puts back the needed styles. I'll update the mobileapp role in a
follow-up patch to require the cite role.
Bug: T132253
Change-Id: I7a9c8ef804301bc81932886a2aec74fe96ba3f84
---
M app/src/main/assets/preview.css
M app/src/main/assets/styles.css
M scripts/make-css-assets.bash
3 files changed, 296 insertions(+), 139 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/83/282483/1
diff --git a/app/src/main/assets/preview.css b/app/src/main/assets/preview.css
index 8c85468..84e0395 100644
--- a/app/src/main/assets/preview.css
+++ b/app/src/main/assets/preview.css
@@ -467,6 +467,88 @@
display: block !important;
width: auto !important;
}
+}/* CSS for Parsoid Cite extension */
+
+/* Style for s */
+span.mw-ref {
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+ /* Make sure the brackets and the numbers aren't jumbled after LTR
words in RTL wikis */
+ unicode-bidi: embed;
+}
+
+/* With a group set */
+span.mw-ref a[data-mw-group]::after {
+ content: "[" attr(data-mw-group) " " counter(mw-Ref, decimal) "]"}
+
+/* Groups with special appearance */
+span.mw-ref a[data-mw-group="decimal"]::after {
+ content: "[" counter(mw-Ref, decimal) "]";
+}
+span.mw-ref a[data-mw-group="lower-alpha"]::after {
+ content: "[" counter(mw-Ref, lower-alpha) "]";
+}
+span.mw-ref a[data-mw-group="upper-alpha"]::after {
+ content: "[" counter(mw-Ref, upper-alpha) "]";
+}
+span.mw-ref a[data-mw-group="lower-greek"]::after {
+ content: "[" counter(mw-Ref, lower-greek) "]";
+}
+span.mw-ref a[data-mw-group="lower-roman"]::after {
+ content: "[" counter(mw-Ref, lower-roman) "]";
+}
+span.mw-ref a[data-mw-group="upper-roman"]::after {
+ content: "[" counter(mw-Ref, upper-roman) "]";
+}
+span.mw-ref a[data-mw-group="error-test"]::after {
+ content: "[" counter(mw-Ref, symbols(cyclic "first" "second" "last!"))
"]";
+}
+
+/* Without a group */
+span.mw-ref a::after {
+ content: "[" counter(mw-Ref, decimal) "]";
+}
+
+/* Hide the default rendering in browsers that support content
+ * generation by selecting for ::after pseudo-element.*/
+x-thereisnoelementwiththisname::after, span.mw-reflink-text {
+ display: none;
+}
+
+/* Style for linkbacks from to s */
+ol.mw-references {
+ counter-reset: mw-ref-linkback;
+}
+
+ol.mw-references li {
+ counter-increment: mw-ref-linkback;
+}
+
+[rel="mw:referencedBy"] {
+ counter-reset: mw-ref-linkback -1;
+}
+
+[rel="mw:referencedBy"]::before {
+ content: "↑ ";
+}
+
+span[rel="mw:referencedBy"] a::before {
+ counter-increment: mw-ref-linkback;
+ content: counters(mw-ref-linkback, ".", decimal);
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+}
+
+span[rel="mw:referencedBy"] a::after {
+ content: " ";
+}
+
+/* Hide the default rendering in browsers that support content
+ * generation by selecting for ::after pseudo-element.*/
+x-thereisnoelementwiththisname[rel="mw:referencedBy"]::before,
span.mw-linkback-text {
+ display: none;
}/* Hide the stupid editlink */
.edit-page {
display: none;
diff --git a/app/src/main/assets/styles.css b/app/src/main/assets/styles.css
index ad191a6..6264352 100644
--- a/app/src/main/assets/styles.css
+++ b/app/src/main/assets/styles.css
@@ -467,26 +467,98 @@
display: block !important;
width: auto !important;
}
-}/* Loading animation in pure CSS
- Thanks to http://dabblet.com/gist/7708654 */
-.loading {
- border: 4px solid rgba(0, 0, 0, 0.1);
- border-top: 4px solid rgba(0, 0, 0, 0.4);
- border-radius: 100%;
- -webkit-animation: rot .6s infinite linear;
+}/* CSS for Parsoid Cite extension */
+
+/* Style for s */
+span.mw-ref {
+ vertical-align: super;
+ line-height: 1;
+ font-size: smaller;
+ /* Make sure the brackets and the numbers aren't jumbled after LTR
words in RTL wikis */
+ unicode-bidi: embed;
}
-@-webkit-keyframes rot {
- from {
--webkit-transform: rotate(0deg);
- }
- to {
--webkit-transform: rotate(359deg);
- }
+
+/* With a group set */
+span.mw-ref a[data-mw-group]::after {
+ content: "[" attr(data-mw-group) " " counter(mw-Ref, decimal) "]"}
+
+/* Groups with special appearance */
+span.mw-ref a[data-mw-group="decimal"]::after {
+ content: "[" counter(mw-Ref, decimal) "]";
}
-#loading_sections {
- margin: 8px auto;
- height: 24px;
- width: 24px;
+span.mw-ref a[data-mw-group="lower-alpha"]::after {
