[MediaWiki-commits] [Gerrit] Replace obsolete live() with $( document ).on() - change (mediawiki...LiquidThreads)

2014-06-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Replace obsolete live() with $( document ).on()
..


Replace obsolete live() with $( document ).on()

Bug: 65666
Change-Id: I9efdea82603c1646d68db19e513fd0ce08fd469a
---
M lqt.js
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lqt.js b/lqt.js
index 7f798ef..af3aa5d 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1593,27 +1593,27 @@
} );
 
// Live bind for unwatch/watch stuff.
-   $( '.lqt-command-watch' ).live( 'click', liquidThreads.asyncWatch );
-   $( '.lqt-command-unwatch' ).live( 'click', liquidThreads.asyncWatch );
+   $( document ).on( 'click', '.lqt-command-watch', 
liquidThreads.asyncWatch );
+   $( document ).on( 'click', '.lqt-command-unwatch', 
liquidThreads.asyncWatch );
 
// Live bind for link window
-   $( '.lqt-command-link' ).live( 'click', 
liquidThreads.showThreadLinkWindow );
+   $( document ).on( 'click', '.lqt-command-link', 
liquidThreads.showThreadLinkWindow );
 
// Live bind for summary links
-   $( '.lqt-summary-link' ).live( 'click', 
liquidThreads.showSummaryLinkWindow );
+   $( document ).on( 'click', '.lqt-summary-link', 
liquidThreads.showSummaryLinkWindow );
 
// For "show replies"
-   $( 'a.lqt-show-replies' ).live( 'click', liquidThreads.showReplies );
+   $( document ).on( 'click', 'a.lqt-show-replies', 
liquidThreads.showReplies );
 
// "Show more posts" link
-   $( 'a.lqt-show-more-posts' ).live( 'click', liquidThreads.showMore );
+   $( document ).on( 'click', 'a.lqt-show-more-posts', 
liquidThreads.showMore );
 
// Edit link handler
-   $( '.lqt-command-edit > a' ).live( 'click', 
liquidThreads.handleEditLink );
+   $( document ).on( 'click', '.lqt-command-edit > a', 
liquidThreads.handleEditLink );
 
// Save handlers
-   $( '#wpSave' ).live( 'click', liquidThreads.handleAJAXSave );
-   $( '#wpTextbox1' ).live( 'keyup', liquidThreads.onTextboxKeyUp );
+   $( document ).on( 'click', '#wpSave', liquidThreads.handleAJAXSave );
+   $( document ).on( 'keyup', '#wpTextbox1', liquidThreads.onTextboxKeyUp 
);
 
// Hide menus when a click happens outside them
$( document ).click( liquidThreads.handleDocumentClick );

-- 
To view, visit https://gerrit.wikimedia.org/r/140221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9efdea82603c1646d68db19e513fd0ce08fd469a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Replace obsolete live() with $( document ).on() - change (mediawiki...LiquidThreads)

2014-06-17 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/140221

Change subject: Replace obsolete live() with $( document ).on()
..

Replace obsolete live() with $( document ).on()

Bug: 65666
Change-Id: I9efdea82603c1646d68db19e513fd0ce08fd469a
---
M lqt.js
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/21/140221/1

diff --git a/lqt.js b/lqt.js
index 7f798ef..af3aa5d 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1593,27 +1593,27 @@
} );
 
// Live bind for unwatch/watch stuff.
-   $( '.lqt-command-watch' ).live( 'click', liquidThreads.asyncWatch );
-   $( '.lqt-command-unwatch' ).live( 'click', liquidThreads.asyncWatch );
+   $( document ).on( 'click', '.lqt-command-watch', 
liquidThreads.asyncWatch );
+   $( document ).on( 'click', '.lqt-command-unwatch', 
liquidThreads.asyncWatch );
 
// Live bind for link window
-   $( '.lqt-command-link' ).live( 'click', 
liquidThreads.showThreadLinkWindow );
+   $( document ).on( 'click', '.lqt-command-link', 
liquidThreads.showThreadLinkWindow );
 
// Live bind for summary links
-   $( '.lqt-summary-link' ).live( 'click', 
liquidThreads.showSummaryLinkWindow );
+   $( document ).on( 'click', '.lqt-summary-link', 
liquidThreads.showSummaryLinkWindow );
 
// For "show replies"
-   $( 'a.lqt-show-replies' ).live( 'click', liquidThreads.showReplies );
+   $( document ).on( 'click', 'a.lqt-show-replies', 
liquidThreads.showReplies );
 
// "Show more posts" link
-   $( 'a.lqt-show-more-posts' ).live( 'click', liquidThreads.showMore );
+   $( document ).on( 'click', 'a.lqt-show-more-posts', 
liquidThreads.showMore );
 
// Edit link handler
-   $( '.lqt-command-edit > a' ).live( 'click', 
liquidThreads.handleEditLink );
+   $( document ).on( 'click', '.lqt-command-edit > a', 
liquidThreads.handleEditLink );
 
// Save handlers
-   $( '#wpSave' ).live( 'click', liquidThreads.handleAJAXSave );
-   $( '#wpTextbox1' ).live( 'keyup', liquidThreads.onTextboxKeyUp );
+   $( document ).on( 'click', '#wpSave', liquidThreads.handleAJAXSave );
+   $( document ).on( 'keyup', '#wpTextbox1', liquidThreads.onTextboxKeyUp 
);
 
// Hide menus when a click happens outside them
$( document ).click( liquidThreads.handleDocumentClick );

-- 
To view, visit https://gerrit.wikimedia.org/r/140221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9efdea82603c1646d68db19e513fd0ce08fd469a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits